netty5/resolver-dns/src/main/java/io/netty/resolver/dns/SingletonDnsServerAddresses.java
Trustin Lee 719d1dbad1 Replace infinite Iterable/Iterator with dedicated types
Related: #4065

Motivation:

DnsNameResolver was using a special Iterable/Iterator implementation
that yields an infinite stream of DNS server addresses. However, this
seems to cause confusion.

Modifications:

- Make DnsServerAddresses an abstract class with an abstract stream()
  method that returns DnsServerAddressStream
- Add DnsServerAddressStream that yields DNS server address infinitely
- Remove DnsServerResolver(Group) constructors that accept only a single
  server address, which wasn't very useful in practice
- Extract the DnsServerAddresses implementations to top level
- DnsServerAddresses.defaultAddresses() now returns DnsServerAddresses.
  - Add DnsServerAddresses.defaultAddressList() instead

Result:

Less confusion and more explicitness
2015-08-26 17:38:43 +09:00

53 lines
1.5 KiB
Java

/*
* Copyright 2015 The Netty Project
*
* The Netty Project licenses this file to you under the Apache License,
* version 2.0 (the "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at:
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
* License for the specific language governing permissions and limitations
* under the License.
*/
package io.netty.resolver.dns;
import java.net.InetSocketAddress;
final class SingletonDnsServerAddresses extends DnsServerAddresses {
private final InetSocketAddress address;
private final String strVal;
private final DnsServerAddressStream stream = new DnsServerAddressStream() {
@Override
public InetSocketAddress next() {
return address;
}
@Override
public String toString() {
return SingletonDnsServerAddresses.this.toString();
}
};
SingletonDnsServerAddresses(InetSocketAddress address) {
this.address = address;
strVal = new StringBuilder(32).append("singleton(").append(address).append(')').toString();
}
@Override
public DnsServerAddressStream stream() {
return stream;
}
@Override
public String toString() {
return strVal;
}
}