netty5/codec-http/src/main/java/io/netty/handler/codec/http/multipart/MixedAttribute.java
Violeta Georgieva 47bababfc7
Ensure HttpData#addContent/setContent releases the buffer before throwing IOException (#11621)
Motivation:
When the ByteBuf size exceeds the max limit/defined size, IOException is thrown.
HttpData#addContent/setContent should release the buffer in such cases otherwise memory leak will happen.

Modification:
- Release the provided ByteBuf before throwing IOException
- Add unit tests

Result:
Fixes #11618
2021-09-02 13:59:44 -07:00

360 lines
10 KiB
Java

/*
* Copyright 2012 The Netty Project
*
* The Netty Project licenses this file to you under the Apache License,
* version 2.0 (the "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at:
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
* License for the specific language governing permissions and limitations
* under the License.
*/
package io.netty.handler.codec.http.multipart;
import io.netty.buffer.ByteBuf;
import io.netty.handler.codec.http.HttpConstants;
import java.io.File;
import java.io.IOException;
import java.io.InputStream;
import java.nio.charset.Charset;
/**
* Mixed implementation using both in Memory and in File with a limit of size
*/
public class MixedAttribute implements Attribute {
private final String baseDir;
private final boolean deleteOnExit;
private Attribute attribute;
private final long limitSize;
private long maxSize = DefaultHttpDataFactory.MAXSIZE;
public MixedAttribute(String name, long limitSize) {
this(name, limitSize, HttpConstants.DEFAULT_CHARSET);
}
public MixedAttribute(String name, long definedSize, long limitSize) {
this(name, definedSize, limitSize, HttpConstants.DEFAULT_CHARSET);
}
public MixedAttribute(String name, long limitSize, Charset charset) {
this(name, limitSize, charset, DiskAttribute.baseDirectory, DiskAttribute.deleteOnExitTemporaryFile);
}
public MixedAttribute(String name, long limitSize, Charset charset, String baseDir, boolean deleteOnExit) {
this.limitSize = limitSize;
attribute = new MemoryAttribute(name, charset);
this.baseDir = baseDir;
this.deleteOnExit = deleteOnExit;
}
public MixedAttribute(String name, long definedSize, long limitSize, Charset charset) {
this(name, definedSize, limitSize, charset,
DiskAttribute.baseDirectory, DiskAttribute.deleteOnExitTemporaryFile);
}
public MixedAttribute(String name, long definedSize, long limitSize, Charset charset,
String baseDir, boolean deleteOnExit) {
this.limitSize = limitSize;
attribute = new MemoryAttribute(name, definedSize, charset);
this.baseDir = baseDir;
this.deleteOnExit = deleteOnExit;
}
public MixedAttribute(String name, String value, long limitSize) {
this(name, value, limitSize, HttpConstants.DEFAULT_CHARSET,
DiskAttribute.baseDirectory, DiskFileUpload.deleteOnExitTemporaryFile);
}
public MixedAttribute(String name, String value, long limitSize, Charset charset) {
this(name, value, limitSize, charset,
DiskAttribute.baseDirectory, DiskFileUpload.deleteOnExitTemporaryFile);
}
public MixedAttribute(String name, String value, long limitSize, Charset charset,
String baseDir, boolean deleteOnExit) {
this.limitSize = limitSize;
if (value.length() > this.limitSize) {
try {
attribute = new DiskAttribute(name, value, charset, baseDir, deleteOnExit);
} catch (IOException e) {
// revert to Memory mode
try {
attribute = new MemoryAttribute(name, value, charset);
} catch (IOException ignore) {
throw new IllegalArgumentException(e);
}
}
} else {
try {
attribute = new MemoryAttribute(name, value, charset);
} catch (IOException e) {
throw new IllegalArgumentException(e);
}
}
this.baseDir = baseDir;
this.deleteOnExit = deleteOnExit;
}
@Override
public long getMaxSize() {
return maxSize;
}
@Override
public void setMaxSize(long maxSize) {
this.maxSize = maxSize;
attribute.setMaxSize(maxSize);
}
@Override
public void checkSize(long newSize) throws IOException {
if (maxSize >= 0 && newSize > maxSize) {
throw new IOException("Size exceed allowed maximum capacity");
}
}
@Override
public void addContent(ByteBuf buffer, boolean last) throws IOException {
if (attribute instanceof MemoryAttribute) {
try {
checkSize(attribute.length() + buffer.readableBytes());
if (attribute.length() + buffer.readableBytes() > limitSize) {
DiskAttribute diskAttribute = new DiskAttribute(attribute
.getName(), attribute.definedLength(), baseDir, deleteOnExit);
diskAttribute.setMaxSize(maxSize);
if (((MemoryAttribute) attribute).getByteBuf() != null) {
diskAttribute.addContent(((MemoryAttribute) attribute)
.getByteBuf(), false);
}
attribute = diskAttribute;
}
} catch (IOException e) {
buffer.release();
throw e;
}
}
attribute.addContent(buffer, last);
}
@Override
public void delete() {
attribute.delete();
}
@Override
public byte[] get() throws IOException {
return attribute.get();
}
@Override
public ByteBuf getByteBuf() throws IOException {
return attribute.getByteBuf();
}
@Override
public Charset getCharset() {
return attribute.getCharset();
}
@Override
public String getString() throws IOException {
return attribute.getString();
}
@Override
public String getString(Charset encoding) throws IOException {
return attribute.getString(encoding);
}
@Override
public boolean isCompleted() {
return attribute.isCompleted();
}
@Override
public boolean isInMemory() {
return attribute.isInMemory();
}
@Override
public long length() {
return attribute.length();
}
@Override
public long definedLength() {
return attribute.definedLength();
}
@Override
public boolean renameTo(File dest) throws IOException {
return attribute.renameTo(dest);
}
@Override
public void setCharset(Charset charset) {
attribute.setCharset(charset);
}
@Override
public void setContent(ByteBuf buffer) throws IOException {
try {
checkSize(buffer.readableBytes());
} catch (IOException e) {
buffer.release();
throw e;
}
if (buffer.readableBytes() > limitSize) {
if (attribute instanceof MemoryAttribute) {
// change to Disk
attribute = new DiskAttribute(attribute.getName(), attribute.definedLength(), baseDir, deleteOnExit);
attribute.setMaxSize(maxSize);
}
}
attribute.setContent(buffer);
}
@Override
public void setContent(File file) throws IOException {
checkSize(file.length());
if (file.length() > limitSize) {
if (attribute instanceof MemoryAttribute) {
// change to Disk
attribute = new DiskAttribute(attribute.getName(), attribute.definedLength(), baseDir, deleteOnExit);
attribute.setMaxSize(maxSize);
}
}
attribute.setContent(file);
}
@Override
public void setContent(InputStream inputStream) throws IOException {
if (attribute instanceof MemoryAttribute) {
// change to Disk even if we don't know the size
attribute = new DiskAttribute(attribute.getName(), attribute.definedLength(), baseDir, deleteOnExit);
attribute.setMaxSize(maxSize);
}
attribute.setContent(inputStream);
}
@Override
public HttpDataType getHttpDataType() {
return attribute.getHttpDataType();
}
@Override
public String getName() {
return attribute.getName();
}
@Override
public int hashCode() {
return attribute.hashCode();
}
@Override
public boolean equals(Object obj) {
return attribute.equals(obj);
}
@Override
public int compareTo(InterfaceHttpData o) {
return attribute.compareTo(o);
}
@Override
public String toString() {
return "Mixed: " + attribute;
}
@Override
public String getValue() throws IOException {
return attribute.getValue();
}
@Override
public void setValue(String value) throws IOException {
attribute.setValue(value);
}
@Override
public ByteBuf getChunk(int length) throws IOException {
return attribute.getChunk(length);
}
@Override
public File getFile() throws IOException {
return attribute.getFile();
}
@Override
public Attribute copy() {
return attribute.copy();
}
@Override
public Attribute duplicate() {
return attribute.duplicate();
}
@Override
public Attribute retainedDuplicate() {
return attribute.retainedDuplicate();
}
@Override
public Attribute replace(ByteBuf content) {
return attribute.replace(content);
}
@Override
public ByteBuf content() {
return attribute.content();
}
@Override
public int refCnt() {
return attribute.refCnt();
}
@Override
public Attribute retain() {
attribute.retain();
return this;
}
@Override
public Attribute retain(int increment) {
attribute.retain(increment);
return this;
}
@Override
public Attribute touch() {
attribute.touch();
return this;
}
@Override
public Attribute touch(Object hint) {
attribute.touch(hint);
return this;
}
@Override
public boolean release() {
return attribute.release();
}
@Override
public boolean release(int decrement) {
return attribute.release(decrement);
}
}