a4c9fb7729
Motivation:
EpollDatagramChannel#localAddress returns wrong information when
EpollDatagramChannel is created with InternetProtocolFamily,
and EpollDatagramChannel#localAddress is invoked BEFORE the actual binding.
This is a regression caused by change
e17ce934da
Modifications:
EpollDatagramChannel() and EpollDatagramChannel(InternetProtocolFamily family)
do not cache local/remote address
Result:
Rebinding on the same address without "reuse port" works
EpollDatagramChannel#localAddress returns correct address
120 lines
4.4 KiB
Java
120 lines
4.4 KiB
Java
/*
|
|
* Copyright 2019 The Netty Project
|
|
*
|
|
* The Netty Project licenses this file to you under the Apache License,
|
|
* version 2.0 (the "License"); you may not use this file except in compliance
|
|
* with the License. You may obtain a copy of the License at:
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
* License for the specific language governing permissions and limitations
|
|
* under the License.
|
|
*/
|
|
package io.netty.channel.epoll;
|
|
|
|
import io.netty.bootstrap.Bootstrap;
|
|
import io.netty.channel.ChannelFuture;
|
|
import io.netty.channel.ChannelHandler;
|
|
import io.netty.channel.ChannelHandlerContext;
|
|
import io.netty.channel.EventLoopGroup;
|
|
import io.netty.channel.MultithreadEventLoopGroup;
|
|
import io.netty.channel.socket.InternetProtocolFamily;
|
|
import io.netty.channel.unix.Socket;
|
|
import org.junit.Before;
|
|
import org.junit.Test;
|
|
|
|
import java.io.IOException;
|
|
import java.net.InetSocketAddress;
|
|
import java.net.SocketAddress;
|
|
|
|
import static io.netty.util.NetUtil.LOCALHOST;
|
|
import static org.junit.Assert.assertEquals;
|
|
import static org.junit.Assert.assertFalse;
|
|
import static org.junit.Assert.assertNotNull;
|
|
import static org.junit.Assert.assertNull;
|
|
import static org.junit.Assert.assertTrue;
|
|
|
|
public class EpollDatagramChannelTest {
|
|
|
|
@Before
|
|
public void setUp() {
|
|
Epoll.ensureAvailability();
|
|
}
|
|
|
|
@Test
|
|
public void testNotActiveNoLocalRemoteAddress() throws IOException {
|
|
EventLoopGroup group = new MultithreadEventLoopGroup(1, EpollHandler.newFactory());
|
|
try {
|
|
checkNotActiveNoLocalRemoteAddress(new EpollDatagramChannel(group.next()));
|
|
checkNotActiveNoLocalRemoteAddress(new EpollDatagramChannel(group.next(), InternetProtocolFamily.IPv4));
|
|
checkNotActiveNoLocalRemoteAddress(new EpollDatagramChannel(group.next(), InternetProtocolFamily.IPv6));
|
|
} finally {
|
|
group.shutdownGracefully();
|
|
}
|
|
}
|
|
|
|
@Test
|
|
public void testActiveHasLocalAddress() throws IOException {
|
|
EventLoopGroup group = new MultithreadEventLoopGroup(1, EpollHandler.newFactory());
|
|
try {
|
|
Socket socket = Socket.newSocketDgram();
|
|
EpollDatagramChannel channel = new EpollDatagramChannel(group.next(), socket.intValue());
|
|
InetSocketAddress localAddress = channel.localAddress();
|
|
assertTrue(channel.active);
|
|
assertNotNull(localAddress);
|
|
assertEquals(socket.localAddress(), localAddress);
|
|
channel.fd().close();
|
|
} finally {
|
|
group.shutdownGracefully();
|
|
}
|
|
}
|
|
|
|
@Test
|
|
public void testLocalAddressBeforeAndAfterBind() {
|
|
EventLoopGroup group = new MultithreadEventLoopGroup(1, EpollHandler.newFactory());
|
|
try {
|
|
TestHandler handler = new TestHandler();
|
|
InetSocketAddress localAddressBeforeBind = new InetSocketAddress(LOCALHOST, 0);
|
|
|
|
Bootstrap bootstrap = new Bootstrap();
|
|
bootstrap.group(group)
|
|
.channel(EpollDatagramChannel.class)
|
|
.localAddress(localAddressBeforeBind)
|
|
.handler(handler);
|
|
|
|
ChannelFuture future = bootstrap.bind().syncUninterruptibly();
|
|
|
|
assertNull(handler.localAddress);
|
|
|
|
SocketAddress localAddressAfterBind = future.channel().localAddress();
|
|
assertNotNull(localAddressAfterBind);
|
|
assertTrue(localAddressAfterBind instanceof InetSocketAddress);
|
|
assertTrue(((InetSocketAddress) localAddressAfterBind).getPort() != 0);
|
|
|
|
future.channel().close().syncUninterruptibly();
|
|
} finally {
|
|
group.shutdownGracefully();
|
|
}
|
|
}
|
|
|
|
private static void checkNotActiveNoLocalRemoteAddress(EpollDatagramChannel channel) throws IOException {
|
|
assertFalse(channel.active);
|
|
assertNull(channel.localAddress());
|
|
assertNull(channel.remoteAddress());
|
|
channel.fd().close();
|
|
}
|
|
|
|
private static final class TestHandler implements ChannelHandler {
|
|
private volatile SocketAddress localAddress;
|
|
|
|
@Override
|
|
public void channelRegistered(ChannelHandlerContext ctx) throws Exception {
|
|
this.localAddress = ctx.channel().localAddress();
|
|
ctx.fireChannelRegistered();
|
|
}
|
|
}
|
|
}
|