4e2530c171
Motivation: Windows 7 hosts file is empty by default (at least on my machine? see http://serverfault.com/questions/4689/windows-7-localhost-name-resolution-is-handled-within-dns-itself-why for details and reasoning. the test relies on the file containing an entry for localhost. Modifications: refactor class code to 1st normalize the input host name and then look it up, change the test to verify that hostnames are normalized in a case-insensitive way before being looked up (which was the intent of the original test) Result: test should pass on vanilla windows 7 (and any other machine with no localhost in the hosts file). no effect anywhere else or on actual netty code. Signed-off-by: radai-rosenblatt <radai.rosenblatt@gmail.com>
34 lines
1.2 KiB
Java
34 lines
1.2 KiB
Java
/*
|
|
* Copyright 2016 The Netty Project
|
|
*
|
|
* The Netty Project licenses this file to you under the Apache License,
|
|
* version 2.0 (the "License"); you may not use this file except in compliance
|
|
* with the License. You may obtain a copy of the License at:
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
* License for the specific language governing permissions and limitations
|
|
* under the License.
|
|
*/
|
|
/**
|
|
* show issue https://github.com/netty/netty/issues/5182
|
|
* HostsFileParser tries to resolve hostnames as case-sensitive
|
|
*/
|
|
package io.netty.resolver;
|
|
|
|
import org.junit.Assert;
|
|
import org.junit.Test;
|
|
|
|
public class DefaultHostsFileEntriesResolverTest {
|
|
|
|
@Test
|
|
public void testCaseInsensitivity() throws Exception {
|
|
DefaultHostsFileEntriesResolver resolver = new DefaultHostsFileEntriesResolver();
|
|
//normalized somehow
|
|
Assert.assertEquals(resolver.normalize("localhost"), resolver.normalize("LOCALHOST"));
|
|
}
|
|
}
|