a469c2eaac
Motivation: We should not propage Http2WindowUpdateFrames to the child channels at all as these are not really use-ful and should not be flow-controlled via `read()` anyway. In the other hand Http2ResetFrame is very useful but should be propagated via an user event so the user is aware of it directly even if the user stops reading. Modifications: - Dont propagate Http2WindowUpdateFrames when using Http2MultiplexHandler - Use user event for Http2ResetFrame when using Http2MultiplexHandler - Adjust javadoc of Http2MultiplexHandler - Add unit tests Result: Fixes https://github.com/netty/netty/pull/8889 and https://github.com/netty/netty/pull/7635
41 lines
1.3 KiB
Java
41 lines
1.3 KiB
Java
/*
|
|
* Copyright 2019 The Netty Project
|
|
*
|
|
* The Netty Project licenses this file to you under the Apache License, version 2.0 (the
|
|
* "License"); you may not use this file except in compliance with the License. You may obtain a
|
|
* copy of the License at:
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software distributed under the License
|
|
* is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
|
|
* or implied. See the License for the specific language governing permissions and limitations under
|
|
* the License.
|
|
*/
|
|
package io.netty.handler.codec.http2;
|
|
|
|
import io.netty.channel.ChannelHandler;
|
|
|
|
public class Http2MultiplexCodecTest extends Http2MultiplexTest<Http2FrameCodec> {
|
|
|
|
@Override
|
|
protected Http2FrameCodec newCodec(TestChannelInitializer childChannelInitializer, Http2FrameWriter frameWriter) {
|
|
return new Http2MultiplexCodecBuilder(true, childChannelInitializer).frameWriter(frameWriter).build();
|
|
}
|
|
|
|
@Override
|
|
protected ChannelHandler newMultiplexer(TestChannelInitializer childChannelInitializer) {
|
|
return null;
|
|
}
|
|
|
|
@Override
|
|
protected boolean useUserEventForResetFrame() {
|
|
return false;
|
|
}
|
|
|
|
@Override
|
|
protected boolean ignoreWindowUpdateFrames() {
|
|
return false;
|
|
}
|
|
}
|