netty5/codec-http/src/main/java/io/netty/handler/codec/http/ComposedLastHttpContent.java
Bartek Kowalczyk 83b286f5d9 Set result for decoded request and add test for #8721 (#8721)
Motivation:
I want to fix bug in vert.x project (eclipse-vertx/vert.x#2562) caused by ComposedLastHttpContent result being null. I don't know if it is intentional that this last decoded chuck in the issue returns null, but if not - I am providing fix for that.

Modification:
* Added new constructor in ComposedLastHttpContent allowing to pass DecoderResult
* set DecoderResult.SUCCESS for created ComposedLastHttpContent in HttpContentEncoder
* set DecoderResult.SUCCESS for created ComposedLastHttpContent in HttpContentDecoder

Result:
Fixes eclipse-vertx/vert.x#2562
2019-01-21 07:45:03 +01:00

120 lines
2.8 KiB
Java

/*
* Copyright 2013 The Netty Project
*
* The Netty Project licenses this file to you under the Apache License,
* version 2.0 (the "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at:
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
* License for the specific language governing permissions and limitations
* under the License.
*/
package io.netty.handler.codec.http;
import io.netty.buffer.ByteBuf;
import io.netty.buffer.Unpooled;
import io.netty.handler.codec.DecoderResult;
final class ComposedLastHttpContent implements LastHttpContent {
private final HttpHeaders trailingHeaders;
private DecoderResult result;
ComposedLastHttpContent(HttpHeaders trailingHeaders) {
this.trailingHeaders = trailingHeaders;
}
ComposedLastHttpContent(HttpHeaders trailingHeaders, DecoderResult result) {
this(trailingHeaders);
this.result = result;
}
@Override
public HttpHeaders trailingHeaders() {
return trailingHeaders;
}
@Override
public LastHttpContent copy() {
LastHttpContent content = new DefaultLastHttpContent(Unpooled.EMPTY_BUFFER);
content.trailingHeaders().set(trailingHeaders());
return content;
}
@Override
public LastHttpContent duplicate() {
return copy();
}
@Override
public LastHttpContent retainedDuplicate() {
return copy();
}
@Override
public LastHttpContent replace(ByteBuf content) {
final LastHttpContent dup = new DefaultLastHttpContent(content);
dup.trailingHeaders().setAll(trailingHeaders());
return dup;
}
@Override
public LastHttpContent retain(int increment) {
return this;
}
@Override
public LastHttpContent retain() {
return this;
}
@Override
public LastHttpContent touch() {
return this;
}
@Override
public LastHttpContent touch(Object hint) {
return this;
}
@Override
public ByteBuf content() {
return Unpooled.EMPTY_BUFFER;
}
@Override
public DecoderResult decoderResult() {
return result;
}
@Override
public DecoderResult getDecoderResult() {
return decoderResult();
}
@Override
public void setDecoderResult(DecoderResult result) {
this.result = result;
}
@Override
public int refCnt() {
return 1;
}
@Override
public boolean release() {
return false;
}
@Override
public boolean release(int decrement) {
return false;
}
}