Go to file
Sergio Bossa 60a240316a Improved DefaultChannelPipeline#destroy() to avoid spinning continuously in case of custom executors.
Motivation:

The previous DefaultChannelPipeline#destroy() implementation, introduced in #3156, is suboptimal as it can cause the for loop to continuously spin if the executor used by a given handler is unable to "recognize" the event loop.
It could be objected that it's the custom executor responsibility to properly implement the inEventLoop() method, but some implementetaions might not be able to do that for performance reasons, and even so, it's always better to be safe against API misuse, in particular when it is not possible to fail fast and the alternative is rather some sutle behaviour.

Modifications:

The patch simply avoids the recursive spin by explicitly passing the "in event loop" condition as a boolean parameter, preserving the same guarantees offered by #3156. A unit test has also been added.

Result:

All channel events are correctly called and no high CPU usage is seen anymore.
2015-11-06 19:37:41 +01:00
all [maven-release-plugin] prepare release netty-4.0.33.Final 2015-11-03 14:18:17 +01:00
buffer [maven-release-plugin] prepare release netty-4.0.33.Final 2015-11-03 14:18:17 +01:00
codec [maven-release-plugin] prepare release netty-4.0.33.Final 2015-11-03 14:18:17 +01:00
codec-haproxy [maven-release-plugin] prepare release netty-4.0.33.Final 2015-11-03 14:18:17 +01:00
codec-http Make HttpHeaders.set(self) a no-op consistently rather than having some implementations throw and others not 2015-11-06 07:12:50 -08:00
codec-socks [maven-release-plugin] prepare release netty-4.0.33.Final 2015-11-03 14:18:17 +01:00
common configurable service thread name prefix 2015-11-05 08:51:59 +01:00
example [maven-release-plugin] prepare release netty-4.0.33.Final 2015-11-03 14:18:17 +01:00
handler [maven-release-plugin] prepare release netty-4.0.33.Final 2015-11-03 14:18:17 +01:00
license Let PoolThreadCache work even if allocation and deallocation Thread are different 2015-05-27 14:35:22 +02:00
microbench [maven-release-plugin] prepare release netty-4.0.33.Final 2015-11-03 14:18:17 +01:00
tarball [maven-release-plugin] prepare release netty-4.0.33.Final 2015-11-03 14:18:17 +01:00
testsuite [maven-release-plugin] prepare release netty-4.0.33.Final 2015-11-03 14:18:17 +01:00
testsuite-osgi [maven-release-plugin] prepare release netty-4.0.33.Final 2015-11-03 14:18:17 +01:00
transport Improved DefaultChannelPipeline#destroy() to avoid spinning continuously in case of custom executors. 2015-11-06 19:37:41 +01:00
transport-native-epoll [maven-release-plugin] prepare release netty-4.0.33.Final 2015-11-03 14:18:17 +01:00
transport-rxtx [maven-release-plugin] prepare release netty-4.0.33.Final 2015-11-03 14:18:17 +01:00
transport-sctp [maven-release-plugin] prepare release netty-4.0.33.Final 2015-11-03 14:18:17 +01:00
transport-udt [maven-release-plugin] prepare release netty-4.0.33.Final 2015-11-03 14:18:17 +01:00
.fbprefs Updated Find Bugs configuration 2009-03-04 10:33:09 +00:00
.gitignore Add JVM crash logs to .gitignore 2014-05-18 21:37:12 +09:00
.travis.yml Travis CI branch whitelisting 2013-03-11 09:55:43 +09:00
CONTRIBUTING.md Move the pull request guide to the developer guide 2014-03-12 13:18:14 +09:00
LICENSE.txt Relicensed to Apache License v2 2009-08-28 07:15:49 +00:00
NOTICE.txt Let PoolThreadCache work even if allocation and deallocation Thread are different 2015-05-27 14:35:22 +02:00
pom.xml [maven-release-plugin] prepare release netty-4.0.33.Final 2015-11-03 14:18:17 +01:00
README.md Fix the 'branches to look' section 2015-10-27 13:58:06 +01:00
run-example.sh Add logLevel property to enable different log levels for the examples. 2014-11-21 10:48:13 +09:00

Netty Project

Netty is an asynchronous event-driven network application framework for rapid development of maintainable high performance protocol servers & clients.

How to build

For the detailed information about building and developing Netty, please visit the developer guide. This page only gives very basic information.

You require the following to build Netty:

Note that this is build-time requirement. JDK 5 (for 3.x) or 6 (for 4.0+) is enough to run your Netty-based application.

Branches to look

The 'master' branch is where the development of the latest major version lives on. The development of all other versions takes place in each branch whose name is identical to <majorVersion>.<minorVersion>. For example, the development of 3.9 and 4.0 resides in the branch '3.9' and the branch '4.0' respectively.