Motivation: The previous used maxHeaderListSize was too low which resulted in exceptions during the benchmark run: ``` io.netty.handler.codec.http2.Http2Exception: Header size exceeded max allowed size (8192) at io.netty.handler.codec.http2.Http2Exception.connectionError(Http2Exception.java:103) at io.netty.handler.codec.http2.Http2Exception.headerListSizeError(Http2Exception.java:188) at io.netty.handler.codec.http2.Http2CodecUtil.headerListSizeExceeded(Http2CodecUtil.java:231) at io.netty.handler.codec.http2.HpackDecoder$Http2HeadersSink.finish(HpackDecoder.java:545) at io.netty.handler.codec.http2.HpackDecoder.decode(HpackDecoder.java:132) at io.netty.handler.codec.http2.HpackDecoderBenchmark.decode(HpackDecoderBenchmark.java:85) at io.netty.handler.codec.http2.generated.HpackDecoderBenchmark_decode_jmhTest.decode_thrpt_jmhStub(HpackDecoderBenchmark_decode_jmhTest.java:120) at io.netty.handler.codec.http2.generated.HpackDecoderBenchmark_decode_jmhTest.decode_Throughput(HpackDecoderBenchmark_decode_jmhTest.java:83) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.openjdk.jmh.runner.BenchmarkHandler$BenchmarkTask.call(BenchmarkHandler.java:453) at org.openjdk.jmh.runner.BenchmarkHandler$BenchmarkTask.call(BenchmarkHandler.java:437) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) at java.lang.Thread.run(Thread.java:748) ``` Also we should ensure we only use ascii for header names. Modifications: Just use Integer.MAX_VALUE as limit Result: Be able to run benchmark without exceptions
103 lines
3.6 KiB
Java
103 lines
3.6 KiB
Java
/*
|
|
* Copyright 2015 The Netty Project
|
|
*
|
|
* The Netty Project licenses this file to you under the Apache License,
|
|
* version 2.0 (the "License"); you may not use this file except in compliance
|
|
* with the License. You may obtain a copy of the License at:
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
* License for the specific language governing permissions and limitations
|
|
* under the License.
|
|
*/
|
|
|
|
/*
|
|
* Copyright 2015 Twitter, Inc.
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
package io.netty.handler.codec.http2;
|
|
|
|
import io.netty.buffer.ByteBuf;
|
|
import io.netty.microbench.util.AbstractMicrobenchmark;
|
|
import org.openjdk.jmh.annotations.Benchmark;
|
|
import org.openjdk.jmh.annotations.BenchmarkMode;
|
|
import org.openjdk.jmh.annotations.Level;
|
|
import org.openjdk.jmh.annotations.Mode;
|
|
import org.openjdk.jmh.annotations.Param;
|
|
import org.openjdk.jmh.annotations.Setup;
|
|
import org.openjdk.jmh.annotations.TearDown;
|
|
import org.openjdk.jmh.infra.Blackhole;
|
|
|
|
import static io.netty.buffer.Unpooled.wrappedBuffer;
|
|
import static io.netty.handler.codec.http2.HpackBenchmarkUtil.http2Headers;
|
|
import static io.netty.handler.codec.http2.Http2CodecUtil.DEFAULT_HEADER_LIST_SIZE;
|
|
|
|
public class HpackDecoderBenchmark extends AbstractMicrobenchmark {
|
|
|
|
@Param
|
|
public HpackHeadersSize size;
|
|
|
|
@Param({ "true", "false" })
|
|
public boolean sensitive;
|
|
|
|
@Param({ "true", "false" })
|
|
public boolean limitToAscii;
|
|
|
|
private ByteBuf input;
|
|
|
|
@Setup(Level.Trial)
|
|
public void setup() throws Http2Exception {
|
|
input = wrappedBuffer(getSerializedHeaders(http2Headers(size, limitToAscii), sensitive));
|
|
}
|
|
|
|
@TearDown(Level.Trial)
|
|
public void teardown() {
|
|
input.release();
|
|
}
|
|
|
|
@Benchmark
|
|
@BenchmarkMode(Mode.Throughput)
|
|
public void decode(final Blackhole bh) throws Http2Exception {
|
|
HpackDecoder hpackDecoder = new HpackDecoder(Integer.MAX_VALUE);
|
|
@SuppressWarnings("unchecked")
|
|
Http2Headers headers =
|
|
new DefaultHttp2Headers() {
|
|
@Override
|
|
public Http2Headers add(CharSequence name, CharSequence value) {
|
|
bh.consume(sensitive);
|
|
return this;
|
|
}
|
|
};
|
|
hpackDecoder.decode(0, input.duplicate(), headers, true);
|
|
}
|
|
|
|
private byte[] getSerializedHeaders(Http2Headers headers, boolean sensitive) throws Http2Exception {
|
|
HpackEncoder hpackEncoder = HpackUtilBenchmark.newTestEncoder();
|
|
ByteBuf out = size.newOutBuffer();
|
|
try {
|
|
hpackEncoder.encodeHeaders(3 /* randomly chosen */, out, headers,
|
|
sensitive ? Http2HeadersEncoder.ALWAYS_SENSITIVE
|
|
: Http2HeadersEncoder.NEVER_SENSITIVE);
|
|
byte[] bytes = new byte[out.readableBytes()];
|
|
out.readBytes(bytes);
|
|
return bytes;
|
|
} finally {
|
|
out.release();
|
|
}
|
|
}
|
|
}
|