James Baldassari 3e3a748eb6 SocksAuthRequest constructor occasionally throws IllegalStateException (#9558) ... Motivation: There appears to be a thread-safety issue in the way that `SocksAuthRequest` is using its `CharsetEncoder` instance. `CharsetUtil#encoder` returns a cached thread-local encoder instance, so it is not correct to store this instance in a static member variable and reuse it across multiple threads. The result is an occasional `IllegalStateException` as in the following example: ``` java.lang.IllegalStateException: Current state = RESET, new state = FLUSHED at java.base/java.nio.charset.CharsetEncoder.throwIllegalStateException(CharsetEncoder.java:989) at java.base/java.nio.charset.CharsetEncoder.flush(CharsetEncoder.java:672) at java.base/java.nio.charset.CharsetEncoder.encode(CharsetEncoder.java:801) at java.base/java.nio.charset.CharsetEncoder.canEncode(CharsetEncoder.java:907) at java.base/java.nio.charset.CharsetEncoder.canEncode(CharsetEncoder.java:982) at io.netty.handler.codec.socks.SocksAuthRequest.<init>(SocksAuthRequest.java:43) ``` Modification: Instead of retrieving the thread-local encoder instance once and storing it as a static member instance, the encoder should be retrieved each time the constructor is invoked. This change prevents any potential concurrency issues where multiple threads may end up using the same encoder instance. Result: Fixes #9556.		2019-09-09 21:08:21 +02:00
..
src	SocksAuthRequest constructor occasionally throws IllegalStateException (#9558)	2019-09-09 21:08:21 +02:00
pom.xml	[maven-release-plugin] prepare for next development iteration	2019-08-13 17:16:42 +00:00