andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
10,347 Commits 27 Branches 234 Tags 84 MiB
Java 99.8%
Shell 0.1%
7b39415543
Go to file
Julien Viet 7b39415543 The MqttDecoder incorrectly skip bytes before throwing TooLongFrameException (#11362) 
Motivation:

Commit c32c520edd incorrectly skip the bytes of the replay decoder buffer. The number of bytes to skip is determined by ByteBuf#readableBytes() instead of using ByteToMessageDecoder#actualReadableBytes(). As result it throws an exception because the ByteBuf provided will return a too large value (Integer.MAX_VALUE - reader index) causing a bound check error in the skipBytes method. This is not detected by the tests because most tests are calling the decode(...) method with a regular ByteBuf. In practice when this method is called with a specialized ByteBuf when channelRead(...) is called. Such tests should actually use channelRead with proper mocking of the ChannelHandlerContext

Modification:

- Rewrite the MqttCodecTest to use channelRead(...) instead of decode(...) and use proper mocking of ChannelHandlerContext to get the message emitted by the decoder.
- Use actualReadableBytes() instead of buff.readableBytes() to compute the number of bytes to skip

Result:

Skip correctly the number of bytes when a too large message is found and improve testing. See #11361

Signed-off-by: Julien Viet <julien@julienviet.com>
2021-06-10 15:21:41 +02:00
.github Make build log output less chatty (#11365) 2021-06-07 10:54:43 +02:00
.mvn/wrapper Use MAVEN_OPTS to setup timeouts for dependency downloads (#11250) 2021-05-12 18:04:33 +02:00
all Fix netty-all artifact (#11274) 2021-05-19 11:18:43 +02:00
bom Fix classifier usage in bom 2020-12-08 14:56:38 +01:00
buffer Fix typo in AbstractMultiSearchProcessorFactory (#11368) 2021-06-07 08:46:15 +02:00
codec Remove Progressive*Promise / Progressive*Future (#11374) 2021-06-09 08:32:38 +02:00
codec-dns Remove unUsed import statement (#11338) 2021-05-31 08:39:11 +02:00
codec-haproxy Migrate codec-haproxy tests to JUnit 5 (#11308) 2021-05-26 09:50:54 +02:00
codec-http HttpUtil.getCharset() fails for charset in double-quotes (#11373) 2021-06-09 12:43:23 +02:00
codec-http2 Remove Progressive*Promise / Progressive*Future (#11374) 2021-06-09 08:32:38 +02:00
codec-memcache Remove Progressive*Promise / Progressive*Future (#11374) 2021-06-09 08:32:38 +02:00
codec-mqtt The MqttDecoder incorrectly skip bytes before throwing TooLongFrameException (#11362) 2021-06-10 15:21:41 +02:00
codec-redis Modify List to Map of pooled redis message in FixedRedisMessagePool (#11300) 2021-06-09 13:19:28 +02:00
codec-smtp Migrate codec-smtp tests to JUnit 5 (#11309) 2021-05-26 09:44:06 +02:00
codec-socks Migrate codec-socks tests to JUnit 5 (#11314) 2021-05-26 10:39:13 +02:00
codec-stomp Migrate codec-stomp tests to JUnit 5 (#11312) 2021-05-26 10:17:27 +02:00
codec-xml Migrate codec-xml tests to JUnit 5 (#11311) 2021-05-26 10:06:05 +02:00
common Remove Progressive*Promise / Progressive*Future (#11374) 2021-06-09 08:32:38 +02:00
dev-tools Use http in xmlns URIs to make maven release plugin happy again (#10788) 2020-11-10 10:51:05 +01:00
docker Make build log output less chatty (#11365) 2021-06-07 10:54:43 +02:00
example Remove Progressive*Promise / Progressive*Future (#11374) 2021-06-09 08:32:38 +02:00
handler Remove Progressive*Promise / Progressive*Future (#11374) 2021-06-09 08:32:38 +02:00
handler-proxy Migrate handler-proxy tests to JUnit 5 (#11313) 2021-05-26 10:36:59 +02:00
license Enable nohttp check during the build (#10708) 2020-10-23 15:26:25 +02:00
microbench Remove Progressive*Promise / Progressive*Future (#11374) 2021-06-09 08:32:38 +02:00
resolver Remove Future.removeListener* and addListeners (#11375) 2021-06-09 08:31:02 +02:00
resolver-dns Remove Void*Promise (#11348) 2021-06-08 14:22:16 +02:00
resolver-dns-native-macos Ensure we fail if native lib can not be loaded on macos (#11261) 2021-05-18 08:14:01 +02:00
scripts Remove tarball module (#11377) 2021-06-10 10:20:32 +02:00
testsuite Remove Void*Promise (#11348) 2021-06-08 14:22:16 +02:00
testsuite-autobahn Add WebSocketClientHandshaker / WebSocketServerHandshaker close methods that take ChannelHandlerContext as parameter (#11171) 2021-04-21 15:22:34 +02:00
testsuite-http2 Skip deployment of testsuite jars (#11127) 2021-03-30 19:06:34 +02:00
testsuite-native Skip deployment of testsuite jars (#11127) 2021-03-30 19:06:34 +02:00
testsuite-native-image Skip deployment of testsuite jars (#11127) 2021-03-30 19:06:34 +02:00
testsuite-native-image-client Skip deployment of testsuite jars (#11127) 2021-03-30 19:06:34 +02:00
testsuite-native-image-client-runtime-init Skip deployment of testsuite jars (#11127) 2021-03-30 19:06:34 +02:00
testsuite-osgi Skip deployment of testsuite jars (#11127) 2021-03-30 19:06:34 +02:00
testsuite-shading Migrate testsuite-shading tests to JUnit 5 (#11323) 2021-05-27 15:59:36 +02:00
transport Remove Progressive*Promise / Progressive*Future (#11374) 2021-06-09 08:32:38 +02:00
transport-blockhound-tests Migrate transport-blockhound-tests tests to JUnit 5 (#11322) 2021-05-27 16:00:30 +02:00
transport-native-epoll Remove Void*Promise (#11348) 2021-06-08 14:22:16 +02:00
transport-native-kqueue Remove Void*Promise (#11348) 2021-06-08 14:22:16 +02:00
transport-native-unix-common Migrate transport-native-unix-common tests to JUnit 5 (#11321) 2021-05-27 15:57:36 +02:00
transport-native-unix-common-tests Migrate testsuite, transport-native-epoll, transport-native-kqueue, and transport-native-unix-common-tests tests to JUnit 5 (#11320) 2021-05-27 14:07:41 +02:00
transport-sctp Fix compile errors introduced by f805c50f9f 2021-05-28 15:14:55 +02:00
transport-udt/lib/bin/lib/x86_64-MacOSX-gpp/jni Replace reflection usage with MethodHandles when performance matters (#10097) 2020-03-11 21:04:40 +01:00
.fbprefs Updated Find Bugs configuration 2009-03-04 10:33:09 +00:00
.gitattributes Include mvn wrapper to make setup of development env easier 2018-01-26 08:13:17 +01:00
.gitignore Ignore .shelf/ folder generated by IntelliJ IDEA (#10445) 2020-08-03 07:52:18 +02:00
.lgtm.yml Enables lgtm.com to process this project and create a CodeQL database 2020-01-20 19:22:49 +01:00
CONTRIBUTING.md Change the netty.io homepage scheme(http -> https) (#9344) 2019-07-09 21:10:14 +02:00
LICENSE.txt Enable nohttp check during the build (#10708) 2020-10-23 15:26:25 +02:00
mvnw Enable nohttp check during the build (#10708) 2020-10-23 15:26:25 +02:00
mvnw.cmd Enable nohttp check during the build (#10708) 2020-10-23 15:26:25 +02:00
nohttp-checkstyle-suppressions.xml Ensure Checkstyle suppression for dependency-reduced-pom.xml on Windows (#10899) 2021-01-01 19:31:01 +01:00
nohttp-checkstyle.xml Enable nohttp check during the build (#10708) 2020-10-23 15:26:25 +02:00
NOTICE.txt Fix License type of dnsinfo (#10773) 2020-11-04 10:41:41 +01:00
pom.xml Remove tarball module (#11377) 2021-06-10 10:20:32 +02:00
README.md Fix url in README.md (#10915) 2021-01-11 07:50:43 +01:00
run-example.sh Add license header to our scripts and workflows (#11282) 2021-05-19 14:07:00 +02:00
SECURITY.md Added a security policy (#10692) 2020-10-15 20:40:05 +02:00

README.md

Build project

Netty Project

Netty is an asynchronous event-driven network application framework for rapid development of maintainable high performance protocol servers & clients.

Links

How to build

For the detailed information about building and developing Netty, please visit the developer guide. This page only gives very basic information.

You require the following to build Netty:

Note that this is build-time requirement. JDK 5 (for 3.x) or 6 (for 4.0+ / 4.1+) is enough to run your Netty-based application.

Branches to look

Development of all versions takes place in each branch whose name is identical to <majorVersion>.<minorVersion>. For example, the development of 3.9 and 4.1 resides in the branch '3.9' and the branch '4.1' respectively.

Usage with JDK 9+

Netty can be used in modular JDK9+ applications as a collection of automatic modules. The module names follow the reverse-DNS style, and are derived from subproject names rather than root packages due to historical reasons. They are listed below:

  • io.netty.all
  • io.netty.buffer
  • io.netty.codec
  • io.netty.codec.dns
  • io.netty.codec.haproxy
  • io.netty.codec.http
  • io.netty.codec.http2
  • io.netty.codec.memcache
  • io.netty.codec.mqtt
  • io.netty.codec.redis
  • io.netty.codec.smtp
  • io.netty.codec.socks
  • io.netty.codec.stomp
  • io.netty.codec.xml
  • io.netty.common
  • io.netty.handler
  • io.netty.handler.proxy
  • io.netty.resolver
  • io.netty.resolver.dns
  • io.netty.transport
  • io.netty.transport.epoll (native omitted - reserved keyword in Java)
  • io.netty.transport.kqueue (native omitted - reserved keyword in Java)
  • io.netty.transport.unix.common (native omitted - reserved keyword in Java)
  • io.netty.transport.rxtx
  • io.netty.transport.sctp
  • io.netty.transport.udt

Automatic modules do not provide any means to declare dependencies, so you need to list each used module separately in your module-info file.