Go to file

Reduce overhead by ByteBufUtil.decodeString(...) which is used by AbstractByteBuf.toString(...) and AbstractByteBuf.getCharSequence(...) (#8388 )

Motivation:

Our current implementation that is used for toString(Charset) operations on AbstractByteBuf implementation is quite slow as it does a lot of uncessary memory copies. We should just use new String(...) as it has a lot of optimizations to handle these cases.

Modifications:

Rewrite ByteBufUtil.decodeString(...) to use new String(...)

Result:

Less overhead for toString(Charset) operations.

Benchmark                                         (charsetName)  (direct)  (size)   Mode  Cnt         Score         Error  Units
ByteBufUtilDecodeStringBenchmark.decodeString          US-ASCII     false       8  thrpt   20  22401645.093 ? 4671452.479  ops/s
ByteBufUtilDecodeStringBenchmark.decodeString          US-ASCII     false      64  thrpt   20  23678483.384 ? 3749164.446  ops/s
ByteBufUtilDecodeStringBenchmark.decodeString          US-ASCII      true       8  thrpt   20  15731142.651 ? 3782931.591  ops/s
ByteBufUtilDecodeStringBenchmark.decodeString          US-ASCII      true      64  thrpt   20  16244232.229 ? 1886259.658  ops/s
ByteBufUtilDecodeStringBenchmark.decodeString             UTF-8     false       8  thrpt   20  25983680.959 ? 5045782.289  ops/s
ByteBufUtilDecodeStringBenchmark.decodeString             UTF-8     false      64  thrpt   20  26235589.339 ? 2867004.950  ops/s
ByteBufUtilDecodeStringBenchmark.decodeString             UTF-8      true       8  thrpt   20  18499027.808 ? 4784684.268  ops/s
ByteBufUtilDecodeStringBenchmark.decodeString             UTF-8      true      64  thrpt   20  16825286.141 ? 1008712.342  ops/s
ByteBufUtilDecodeStringBenchmark.decodeString            UTF-16     false       8  thrpt   20   5789879.092 ? 1201786.359  ops/s
ByteBufUtilDecodeStringBenchmark.decodeString            UTF-16     false      64  thrpt   20   2173243.225 ?  417809.341  ops/s
ByteBufUtilDecodeStringBenchmark.decodeString            UTF-16      true       8  thrpt   20   5035583.011 ? 1001978.854  ops/s
ByteBufUtilDecodeStringBenchmark.decodeString            UTF-16      true      64  thrpt   20   2162345.301 ?  402410.408  ops/s
ByteBufUtilDecodeStringBenchmark.decodeString        ISO-8859-1     false       8  thrpt   20  30039052.376 ? 6539111.622  ops/s
ByteBufUtilDecodeStringBenchmark.decodeString        ISO-8859-1     false      64  thrpt   20  31414163.515 ? 2096710.526  ops/s
ByteBufUtilDecodeStringBenchmark.decodeString        ISO-8859-1      true       8  thrpt   20  19538587.855 ? 4639115.572  ops/s
ByteBufUtilDecodeStringBenchmark.decodeString        ISO-8859-1      true      64  thrpt   20  19467839.722 ? 1672687.213  ops/s
ByteBufUtilDecodeStringBenchmark.decodeStringOld       US-ASCII     false       8  thrpt   20  10787326.745 ? 1034197.864  ops/s
ByteBufUtilDecodeStringBenchmark.decodeStringOld       US-ASCII     false      64  thrpt   20   7129801.930 ? 1363019.209  ops/s
ByteBufUtilDecodeStringBenchmark.decodeStringOld       US-ASCII      true       8  thrpt   20   9002529.605 ? 2017642.445  ops/s
ByteBufUtilDecodeStringBenchmark.decodeStringOld       US-ASCII      true      64  thrpt   20   3860192.352 ?  826218.738  ops/s
ByteBufUtilDecodeStringBenchmark.decodeStringOld          UTF-8     false       8  thrpt   20  10532838.027 ? 2151743.968  ops/s
ByteBufUtilDecodeStringBenchmark.decodeStringOld          UTF-8     false      64  thrpt   20   7185554.597 ? 1387685.785  ops/s
ByteBufUtilDecodeStringBenchmark.decodeStringOld          UTF-8      true       8  thrpt   20   7352253.316 ? 1333823.850  ops/s
ByteBufUtilDecodeStringBenchmark.decodeStringOld          UTF-8      true      64  thrpt   20   2825578.707 ?  349701.156  ops/s
ByteBufUtilDecodeStringBenchmark.decodeStringOld         UTF-16     false       8  thrpt   20   7277446.665 ? 1447034.346  ops/s
ByteBufUtilDecodeStringBenchmark.decodeStringOld         UTF-16     false      64  thrpt   20   2445929.579 ?  562816.641  ops/s
ByteBufUtilDecodeStringBenchmark.decodeStringOld         UTF-16      true       8  thrpt   20   6201174.401 ? 1236137.786  ops/s
ByteBufUtilDecodeStringBenchmark.decodeStringOld         UTF-16      true      64  thrpt   20   2310674.973 ?  525587.959  ops/s
ByteBufUtilDecodeStringBenchmark.decodeStringOld     ISO-8859-1     false       8  thrpt   20  11142625.392 ? 1680556.468  ops/s
ByteBufUtilDecodeStringBenchmark.decodeStringOld     ISO-8859-1     false      64  thrpt   20   8127116.405 ? 1128513.860  ops/s
ByteBufUtilDecodeStringBenchmark.decodeStringOld     ISO-8859-1      true       8  thrpt   20   9405751.952 ? 2193324.806  ops/s
ByteBufUtilDecodeStringBenchmark.decodeStringOld     ISO-8859-1      true      64  thrpt   20   3943282.076 ?  737798.070  ops/s

Benchmark result is saved to /home/norman/mainframer/netty/microbench/target/reports/performance/ByteBufUtilDecodeStringBenchmark.json
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1,030.173 sec - in io.netty.buffer.ByteBufUtilDecodeStringBenchmark
[1030.460s][info   ][gc,heap,exit ] Heap
[1030.460s][info   ][gc,heap,exit ]  garbage-first heap   total 516096K, used 257918K [0x0000000609a00000, 0x0000000800000000)
[1030.460s][info   ][gc,heap,exit ]   region size 2048K, 127 young (260096K), 2 survivors (4096K)
[1030.460s][info   ][gc,heap,exit ]  Metaspace       used 17123K, capacity 17438K, committed 17792K, reserved 1064960K
[1030.460s][info   ][gc,heap,exit ]   class space    used 1709K, capacity 1827K, committed 1920K, reserved 1048576K

2018-10-19 14:00:13 +02:00

.github

Use GitHub Issue/PR Template Feature

2016-12-07 11:40:26 -08:00

.mvn/wrapper

Include mvn wrapper to make setup of development env easier

2018-01-26 08:13:17 +01:00

all

[maven-release-plugin] prepare for next development iteration

2018-09-27 19:00:45 +00:00

bom

[maven-release-plugin] prepare for next development iteration

2018-09-27 19:00:45 +00:00

buffer

Reduce overhead by ByteBufUtil.decodeString(...) which is used by AbstractByteBuf.toString(...) and AbstractByteBuf.getCharSequence(...) (#8388 )

2018-10-19 14:00:13 +02:00

codec

[maven-release-plugin] prepare for next development iteration

2018-09-27 19:00:45 +00:00

codec-dns

[maven-release-plugin] prepare for next development iteration

2018-09-27 19:00:45 +00:00

codec-haproxy

[maven-release-plugin] prepare for next development iteration

2018-09-27 19:00:45 +00:00

codec-http

Fix context and window sizes sides. (#8395 )

2018-10-18 13:55:30 +02:00

codec-http2

Notify http2 error handler before closeStreamLocal on HEADERS write failure (#8332 )

2018-09-28 10:29:12 -07:00

codec-memcache

[maven-release-plugin] prepare for next development iteration

2018-09-27 19:00:45 +00:00

codec-mqtt

[maven-release-plugin] prepare for next development iteration

2018-09-27 19:00:45 +00:00

codec-redis

[maven-release-plugin] prepare for next development iteration

2018-09-27 19:00:45 +00:00

codec-smtp

[maven-release-plugin] prepare for next development iteration

2018-09-27 19:00:45 +00:00

codec-socks

[maven-release-plugin] prepare for next development iteration

2018-09-27 19:00:45 +00:00

codec-stomp

[maven-release-plugin] prepare for next development iteration

2018-09-27 19:00:45 +00:00

codec-xml

[maven-release-plugin] prepare for next development iteration

2018-09-27 19:00:45 +00:00

common

deprecate own ConcurrentSet for removal (#8340 )

2018-10-15 19:36:05 +02:00

dev-tools

[maven-release-plugin] prepare for next development iteration

2018-09-27 19:00:45 +00:00

docker

Fix broken testsuite-shading when using with netty-tcnative-boringssl-static (#8404 )

2018-10-18 19:31:01 +02:00

example

[maven-release-plugin] prepare for next development iteration

2018-09-27 19:00:45 +00:00

handler

Allow to use TLSv1.3 with netty-tcnative withe java versions prior to 11. (#8394 )

2018-10-18 13:50:12 +02:00

handler-proxy

[maven-release-plugin] prepare for next development iteration

2018-09-27 19:00:45 +00:00

license

Add the NOTICE of the forked portion of Apache Harmony

2018-01-30 11:22:51 +01:00

microbench

Reduce overhead by ByteBufUtil.decodeString(...) which is used by AbstractByteBuf.toString(...) and AbstractByteBuf.getCharSequence(...) (#8388 )

2018-10-19 14:00:13 +02:00

resolver

[maven-release-plugin] prepare for next development iteration

2018-09-27 19:00:45 +00:00

resolver-dns

Correctly parse /etc/resolv.conf when contain multiple entries for searchdomain. (#8351 )

2018-10-12 05:00:32 +02:00

tarball

[maven-release-plugin] prepare for next development iteration

2018-09-27 19:00:45 +00:00

testsuite

Add support for TLSv1.3 (#8293 )

2018-10-17 08:35:35 +02:00

testsuite-autobahn

[maven-release-plugin] prepare for next development iteration

2018-09-27 19:00:45 +00:00

testsuite-http2

Upgrade h2spec-maven-plugin (#8386 )

2018-10-16 07:05:45 +02:00

testsuite-osgi

[maven-release-plugin] prepare for next development iteration

2018-09-27 19:00:45 +00:00

testsuite-shading

Fix broken testsuite-shading when using with netty-tcnative-boringssl-static (#8404 )

2018-10-18 19:31:01 +02:00

transport

Increase test timeout (#8385 )

2018-10-15 15:10:22 +02:00

transport-native-epoll

epoll_wait produces an EINVAL error since 4.1.30 (#8350 )

2018-10-12 05:02:41 +02:00

transport-native-kqueue

Use MACOSX_DEPLOYMENT_TARGET=10.6 when compile native transport on MacOS (#8379 )

2018-10-13 04:25:56 +02:00

transport-native-unix-common

[maven-release-plugin] prepare for next development iteration

2018-09-27 19:00:45 +00:00

transport-native-unix-common-tests

[maven-release-plugin] prepare for next development iteration

2018-09-27 19:00:45 +00:00

transport-rxtx

[maven-release-plugin] prepare for next development iteration

2018-09-27 19:00:45 +00:00

transport-sctp

[maven-release-plugin] prepare for next development iteration

2018-09-27 19:00:45 +00:00

transport-udt

[maven-release-plugin] prepare for next development iteration

2018-09-27 19:00:45 +00:00

.fbprefs

Updated Find Bugs configuration

2009-03-04 10:33:09 +00:00

.gitattributes

Include mvn wrapper to make setup of development env easier

2018-01-26 08:13:17 +01:00

.gitignore

Exclude mainframer related files from git

2018-10-14 13:20:18 +02:00

CONTRIBUTING.md

Move the pull request guide to the developer guide

2014-03-12 13:13:58 +09:00

LICENSE.txt

Relicensed to Apache License v2

2009-08-28 07:15:49 +00:00

mvnw

Include mvn wrapper to make setup of development env easier

2018-01-26 08:13:17 +01:00

mvnw.cmd

Include mvn wrapper to make setup of development env easier

2018-01-26 08:13:17 +01:00

NOTICE.txt

Add the NOTICE of the forked portion of Apache Harmony

2018-01-30 11:22:51 +01:00

pom.xml

Update jetty-alpn-agent version to support latest JDK 8 release. (#8402 )

2018-10-18 08:22:20 +02:00

README.md

Provide an Automatic-Module-Name for the netty-all artifact fixes #7644

2018-01-27 20:31:16 +01:00

run-example.sh

Add UptimeServer and adjust UptimeClient's code style.

2017-04-28 07:41:07 +02:00

README.md

Netty Project

Netty is an asynchronous event-driven network application framework for rapid development of maintainable high performance protocol servers & clients.

How to build

For the detailed information about building and developing Netty, please visit the developer guide. This page only gives very basic information.

You require the following to build Netty:

Latest stable Oracle JDK 7
Latest stable Apache Maven
If you are on Linux, you need additional development packages installed on your system, because you'll build the native transport.

Note that this is build-time requirement. JDK 5 (for 3.x) or 6 (for 4.0+) is enough to run your Netty-based application.

Branches to look

Development of all versions takes place in each branch whose name is identical to <majorVersion>.<minorVersion>. For example, the development of 3.9 and 4.0 resides in the branch '3.9' and the branch '4.0' respectively.

Usage with JDK 9

Netty can be used in modular JDK9 applications as a collection of automatic modules. The module names follow the reverse-DNS style, and are derived from subproject names rather than root packages due to historical reasons. They are listed below:

io.netty.all
io.netty.buffer
io.netty.codec
io.netty.codec.dns
io.netty.codec.haproxy
io.netty.codec.http
io.netty.codec.http2
io.netty.codec.memcache
io.netty.codec.mqtt
io.netty.codec.redis
io.netty.codec.smtp
io.netty.codec.socks
io.netty.codec.stomp
io.netty.codec.xml
io.netty.common
io.netty.handler
io.netty.handler.proxy
io.netty.resolver
io.netty.resolver.dns
io.netty.transport
io.netty.transport.epoll (native omitted - reserved keyword in Java)
io.netty.transport.kqueue (native omitted - reserved keyword in Java)
io.netty.transport.unix.common (native omitted - reserved keyword in Java)
io.netty.transport.rxtx
io.netty.transport.sctp
io.netty.transport.udt

Automatic modules do not provide any means to declare dependencies, so you need to list each used module separately in your module-info file.

README.md

Netty Project

Links

How to build

Branches to look

Usage with JDK 9