Go to file
Dmitry Minkovsky 8aeba78ecc HttpPostMultipartRequestDecoder should decode header field parameters
Motivation:

I am receiving a multipart/form_data upload from a Mailgun webhook. This webhook used to send parts like this:

--74e78d11b0214bdcbc2f86491eeb4902
Content-Disposition: form-data; name="attachment-2"; filename="attached_�айл.txt"
Content-Type: text/plain
Content-Length: 32

This is the content of the file

--74e78d11b0214bdcbc2f86491eeb4902--
but now it posts parts like this:

--74e78d11b0214bdcbc2f86491eeb4902
Content-Disposition: form-data; name="attachment-2"; filename*=utf-8''attached_%D1%84%D0%B0%D0%B9%D0%BB.txt

This is the content of the file

--74e78d11b0214bdcbc2f86491eeb4902--
This new format uses field parameter encoding described in RFC 5987. More about this encoding can be found here.

Netty does not parse this format. The result is the filename is not decoded and the part is not parsed into a FileUpload.

Modification:

Added failing test in HttpPostRequestDecoderTest.java and updated HttpPostMultipartRequestDecoder.java
Refactored to please Netkins
Result:

Fixes:

HttpPostMultipartRequestDecoder identifies the RFC 5987 format and parses it.
Previous functionality is retained.
2017-10-24 19:30:59 +02:00
.github Use GitHub Issue/PR Template Feature 2016-12-07 11:40:26 -08:00
all Update links for actual Protobuf repo and documentation 2017-10-23 07:41:35 +02:00
bom [maven-release-plugin] prepare for next development iteration 2017-09-25 06:12:32 +02:00
buffer Make methods 'static' where it possible 2017-10-21 14:59:26 +02:00
codec Update links for actual Protobuf repo and documentation 2017-10-23 07:41:35 +02:00
codec-dns [maven-release-plugin] prepare for next development iteration 2017-09-25 06:12:32 +02:00
codec-haproxy Do not treat errors as decoder exception (redux) 2017-10-07 18:17:00 +02:00
codec-http HttpPostMultipartRequestDecoder should decode header field parameters 2017-10-24 19:30:59 +02:00
codec-http2 Trigger user event when H2 conn preface & SETTINGS frame are sent 2017-10-24 09:17:06 +02:00
codec-memcache [maven-release-plugin] prepare for next development iteration 2017-09-25 06:12:32 +02:00
codec-mqtt [maven-release-plugin] prepare for next development iteration 2017-09-25 06:12:32 +02:00
codec-redis [maven-release-plugin] prepare for next development iteration 2017-09-25 06:12:32 +02:00
codec-smtp [maven-release-plugin] prepare for next development iteration 2017-09-25 06:12:32 +02:00
codec-socks Do not treat errors as decoder exception (redux) 2017-10-07 18:17:00 +02:00
codec-stomp [maven-release-plugin] prepare for next development iteration 2017-09-25 06:12:32 +02:00
codec-xml [maven-release-plugin] prepare for next development iteration 2017-09-25 06:12:32 +02:00
common Use WeakReferences for Resource Leaks 2017-10-24 19:21:33 +02:00
dev-tools [maven-release-plugin] prepare for next development iteration 2017-09-25 06:12:32 +02:00
example Make methods 'static' where it possible 2017-10-21 14:59:26 +02:00
handler Fix possible leak in SslHandler if wrap(...) throws. 2017-10-24 18:52:20 +02:00
handler-proxy [maven-release-plugin] prepare for next development iteration 2017-09-25 06:12:32 +02:00
license Remove reference to akka code and ArrayDeque which is not part of netty anymore 2017-03-07 21:30:51 +01:00
microbench Optimistically update ref counts 2017-10-04 08:42:33 +02:00
resolver [maven-release-plugin] prepare for next development iteration 2017-09-25 06:12:32 +02:00
resolver-dns DnsResolver CNAME redirect bug 2017-10-23 09:37:32 -07:00
tarball [maven-release-plugin] prepare for next development iteration 2017-09-25 06:12:32 +02:00
testsuite [maven-release-plugin] prepare for next development iteration 2017-09-25 06:12:32 +02:00
testsuite-autobahn [maven-release-plugin] prepare for next development iteration 2017-09-25 06:12:32 +02:00
testsuite-osgi [maven-release-plugin] prepare for next development iteration 2017-09-25 06:12:32 +02:00
transport Correctly update Channel writability when queueing data in SslHandler. 2017-10-24 09:13:15 +02:00
transport-native-epoll Make methods 'static' where it possible 2017-10-21 14:59:26 +02:00
transport-native-kqueue Make methods 'static' where it possible 2017-10-21 14:59:26 +02:00
transport-native-unix-common Ensure setting / getting the traffic class on an ipv4 only system works when using the native transport. 2017-10-24 09:03:28 +02:00
transport-native-unix-common-tests Ensure setting / getting the traffic class on an ipv4 only system works when using the native transport. 2017-10-24 09:03:28 +02:00
transport-rxtx [maven-release-plugin] prepare for next development iteration 2017-09-25 06:12:32 +02:00
transport-sctp [maven-release-plugin] prepare for next development iteration 2017-09-25 06:12:32 +02:00
transport-udt [maven-release-plugin] prepare for next development iteration 2017-09-25 06:12:32 +02:00
.fbprefs Updated Find Bugs configuration 2009-03-04 10:33:09 +00:00
.gitignore Use shaded dependency on JCTools instead of copy and paste 2016-06-10 13:19:45 +02:00
.travis.yml Travis CI branch whitelisting 2013-03-11 09:55:43 +09:00
CONTRIBUTING.md Move the pull request guide to the developer guide 2014-03-12 13:13:58 +09:00
LICENSE.txt Relicensed to Apache License v2 2009-08-28 07:15:49 +00:00
NOTICE.txt Remove reference to akka code and ArrayDeque which is not part of netty anymore 2017-03-07 21:30:51 +01:00
pom.xml Update JCTools version 2017-10-07 18:10:29 +02:00
README.md Updating Branches to look section to match the current branching structure of the project 2016-03-10 22:08:01 +01:00
run-example.sh Add UptimeServer and adjust UptimeClient's code style. 2017-04-28 07:41:07 +02:00

Netty Project

Netty is an asynchronous event-driven network application framework for rapid development of maintainable high performance protocol servers & clients.

How to build

For the detailed information about building and developing Netty, please visit the developer guide. This page only gives very basic information.

You require the following to build Netty:

Note that this is build-time requirement. JDK 5 (for 3.x) or 6 (for 4.0+) is enough to run your Netty-based application.

Branches to look

Development of all versions takes place in each branch whose name is identical to <majorVersion>.<minorVersion>. For example, the development of 3.9 and 4.0 resides in the branch '3.9' and the branch '4.0' respectively.