Go to file
Eric Anderson a95b7a791e
Notify http2 error handler before closeStreamLocal on HEADERS write failure (#8332)
Motivation:

When writing an HTTP/2 HEADERS with END_STREAM=1, the application expects
the stream to be closed afterward. However, the write can fail locally
due to HPACK encoder and similar. When that happens we need to make sure
to issue a RST_STREAM otherwise the stream can be closed locally but
orphaned remotely. The RST_STREAM is typically handled by
Http2ConnectionHandler.onStreamError, which will only send a RST_STREAM
if that stream still exists locally.

There are two possible flows for trailers, one handled immediately and
one going through the flow controller. Previously they behaved
differently, with the immedate code calling the error handler after
closing the stream. The immediate code also used a listener for calling
closeStreamLocal while the flow controlled code did so immediately after
the write.

The two code paths also differed in their VoidChannelPromise handling,
but both were broken. The immediate code path called unvoid() only if
END_STREAM=1, however it could always potentially add a listener via
notifyLifecycleManagerOnError(). And the flow controlled code path
unvoided incorrectly, changing the promise completion behavior. It also
passed the wrong promise to closeStreamLocal() in FlowControlledBase.

Modifications:

Move closeStreamLocal handling after calls to onError. This is the
primary change.

Now call closeStreamLocal immediately instead of when the future
completes. This is the more likely correct behavior as it matches that
of DATA frames.

Fix all the VoidChannelPromise handling.

Result:

Http2ConnectionHandler.onStreamError sees the same state as the remote
and issues a RST_STREAM, properly cleaning up the stream.
2018-09-28 10:29:12 -07:00
.github Use GitHub Issue/PR Template Feature 2016-12-07 11:40:26 -08:00
.mvn/wrapper Include mvn wrapper to make setup of development env easier 2018-01-26 08:13:17 +01:00
all [maven-release-plugin] prepare for next development iteration 2018-09-27 19:00:45 +00:00
bom [maven-release-plugin] prepare for next development iteration 2018-09-27 19:00:45 +00:00
buffer [maven-release-plugin] prepare for next development iteration 2018-09-27 19:00:45 +00:00
codec [maven-release-plugin] prepare for next development iteration 2018-09-27 19:00:45 +00:00
codec-dns [maven-release-plugin] prepare for next development iteration 2018-09-27 19:00:45 +00:00
codec-haproxy [maven-release-plugin] prepare for next development iteration 2018-09-27 19:00:45 +00:00
codec-http [maven-release-plugin] prepare for next development iteration 2018-09-27 19:00:45 +00:00
codec-http2 Notify http2 error handler before closeStreamLocal on HEADERS write failure (#8332) 2018-09-28 10:29:12 -07:00
codec-memcache [maven-release-plugin] prepare for next development iteration 2018-09-27 19:00:45 +00:00
codec-mqtt [maven-release-plugin] prepare for next development iteration 2018-09-27 19:00:45 +00:00
codec-redis [maven-release-plugin] prepare for next development iteration 2018-09-27 19:00:45 +00:00
codec-smtp [maven-release-plugin] prepare for next development iteration 2018-09-27 19:00:45 +00:00
codec-socks [maven-release-plugin] prepare for next development iteration 2018-09-27 19:00:45 +00:00
codec-stomp [maven-release-plugin] prepare for next development iteration 2018-09-27 19:00:45 +00:00
codec-xml [maven-release-plugin] prepare for next development iteration 2018-09-27 19:00:45 +00:00
common Do the same extended checks as the JDK when a X509TrustManager is used with the OpenSSL provider. (#8307) 2018-09-28 09:19:58 +02:00
dev-tools [maven-release-plugin] prepare for next development iteration 2018-09-27 19:00:45 +00:00
docker Add docker-compose config to run with Java12 (#8327) 2018-09-27 12:47:17 +02:00
example [maven-release-plugin] prepare for next development iteration 2018-09-27 19:00:45 +00:00
handler Ensure X509KeyManager methods are called on the correct time when using server-side and support more methods of ExtendedSSLSession. (#8283) 2018-09-28 11:34:38 +02:00
handler-proxy [maven-release-plugin] prepare for next development iteration 2018-09-27 19:00:45 +00:00
license Add the NOTICE of the forked portion of Apache Harmony 2018-01-30 11:22:51 +01:00
microbench [maven-release-plugin] prepare for next development iteration 2018-09-27 19:00:45 +00:00
resolver [maven-release-plugin] prepare for next development iteration 2018-09-27 19:00:45 +00:00
resolver-dns [maven-release-plugin] prepare for next development iteration 2018-09-27 19:00:45 +00:00
tarball [maven-release-plugin] prepare for next development iteration 2018-09-27 19:00:45 +00:00
testsuite [maven-release-plugin] prepare for next development iteration 2018-09-27 19:00:45 +00:00
testsuite-autobahn [maven-release-plugin] prepare for next development iteration 2018-09-27 19:00:45 +00:00
testsuite-http2 [maven-release-plugin] prepare for next development iteration 2018-09-27 19:00:45 +00:00
testsuite-osgi [maven-release-plugin] prepare for next development iteration 2018-09-27 19:00:45 +00:00
testsuite-shading [maven-release-plugin] prepare for next development iteration 2018-09-27 19:00:45 +00:00
transport [maven-release-plugin] prepare for next development iteration 2018-09-27 19:00:45 +00:00
transport-native-epoll Avoid repeating the same field and hiding it (#8335) 2018-09-28 17:37:14 +02:00
transport-native-kqueue Avoid repeating the same field and hiding it (#8335) 2018-09-28 17:37:14 +02:00
transport-native-unix-common [maven-release-plugin] prepare for next development iteration 2018-09-27 19:00:45 +00:00
transport-native-unix-common-tests [maven-release-plugin] prepare for next development iteration 2018-09-27 19:00:45 +00:00
transport-rxtx [maven-release-plugin] prepare for next development iteration 2018-09-27 19:00:45 +00:00
transport-sctp [maven-release-plugin] prepare for next development iteration 2018-09-27 19:00:45 +00:00
transport-udt [maven-release-plugin] prepare for next development iteration 2018-09-27 19:00:45 +00:00
.fbprefs Updated Find Bugs configuration 2009-03-04 10:33:09 +00:00
.gitattributes Include mvn wrapper to make setup of development env easier 2018-01-26 08:13:17 +01:00
.gitignore Add docker-sync files to .gitignore 2018-05-15 10:39:14 +02:00
CONTRIBUTING.md Move the pull request guide to the developer guide 2014-03-12 13:13:58 +09:00
LICENSE.txt Relicensed to Apache License v2 2009-08-28 07:15:49 +00:00
mvnw Include mvn wrapper to make setup of development env easier 2018-01-26 08:13:17 +01:00
mvnw.cmd Include mvn wrapper to make setup of development env easier 2018-01-26 08:13:17 +01:00
NOTICE.txt Add the NOTICE of the forked portion of Apache Harmony 2018-01-30 11:22:51 +01:00
pom.xml Ensure X509KeyManager methods are called on the correct time when using server-side and support more methods of ExtendedSSLSession. (#8283) 2018-09-28 11:34:38 +02:00
README.md Provide an Automatic-Module-Name for the netty-all artifact fixes #7644 2018-01-27 20:31:16 +01:00
run-example.sh Add UptimeServer and adjust UptimeClient's code style. 2017-04-28 07:41:07 +02:00

Netty Project

Netty is an asynchronous event-driven network application framework for rapid development of maintainable high performance protocol servers & clients.

How to build

For the detailed information about building and developing Netty, please visit the developer guide. This page only gives very basic information.

You require the following to build Netty:

Note that this is build-time requirement. JDK 5 (for 3.x) or 6 (for 4.0+) is enough to run your Netty-based application.

Branches to look

Development of all versions takes place in each branch whose name is identical to <majorVersion>.<minorVersion>. For example, the development of 3.9 and 4.0 resides in the branch '3.9' and the branch '4.0' respectively.

Usage with JDK 9

Netty can be used in modular JDK9 applications as a collection of automatic modules. The module names follow the reverse-DNS style, and are derived from subproject names rather than root packages due to historical reasons. They are listed below:

  • io.netty.all
  • io.netty.buffer
  • io.netty.codec
  • io.netty.codec.dns
  • io.netty.codec.haproxy
  • io.netty.codec.http
  • io.netty.codec.http2
  • io.netty.codec.memcache
  • io.netty.codec.mqtt
  • io.netty.codec.redis
  • io.netty.codec.smtp
  • io.netty.codec.socks
  • io.netty.codec.stomp
  • io.netty.codec.xml
  • io.netty.common
  • io.netty.handler
  • io.netty.handler.proxy
  • io.netty.resolver
  • io.netty.resolver.dns
  • io.netty.transport
  • io.netty.transport.epoll (native omitted - reserved keyword in Java)
  • io.netty.transport.kqueue (native omitted - reserved keyword in Java)
  • io.netty.transport.unix.common (native omitted - reserved keyword in Java)
  • io.netty.transport.rxtx
  • io.netty.transport.sctp
  • io.netty.transport.udt

Automatic modules do not provide any means to declare dependencies, so you need to list each used module separately in your module-info file.