a99a8f2a1f
Motivation: If ByteBufUtil.getBytes() is called with copy=false, it does not correctly check that the underlying array can be shared in some cases. In particular: * It does not check that the arrayOffset() is zero. This causes it to incorrectly return the underlying array if the other conditions are met. The returned array will be longer than requested, with additional unwanted bytes at its start. * It assumes that the capacity() of the ByteBuf is equal to the backing array length. This is not true for some types of ByteBuf, such as PooledHeapByteBuf. This causes it to incorrectly return the underlying array if the other conditions are met. The returned array will be longer than requested, with additional unwanted bytes at its end. Modifications: This commit fixes the two bugs by: * Checking that the arrayOffset() is zero before returning the underlying array. * Comparing the requested length to the underlying array's length, rather than the ByteBuf's capacity, before returning the underlying array. This commit also adds a series of test cases for ByteBufUtil.getBytes(). Result: ByteBufUtil.getBytes() now correctly checks whether the underlying array can be shared or not. The test cases will ensure the bug is not reintroduced in the future.
Netty Project
Netty is an asynchronous event-driven network application framework for rapid development of maintainable high performance protocol servers & clients.
Links
How to build
For the detailed information about building and developing Netty, please visit the developer guide. This page only gives very basic information.
You require the following to build Netty:
- Latest stable Oracle JDK 7
- Latest stable Apache Maven
- If you are on Linux, you need additional development packages installed on your system, because you'll build the native transport.
Note that this is build-time requirement. JDK 5 (for 3.x) or 6 (for 4.0+) is enough to run your Netty-based application.
Branches to look
Development of all versions takes place in each branch whose name is identical to <majorVersion>.<minorVersion>. For example, the development of 3.9 and 4.0 resides in the branch '3.9' and the branch '4.0' respectively.
Usage with JDK 9
Netty can be used in modular JDK9 applications as a collection of automatic modules. The module names follow the reverse-DNS style, and are derived from subproject names rather than root packages due to historical reasons. They are listed below:
io.netty.allio.netty.bufferio.netty.codecio.netty.codec.dnsio.netty.codec.haproxyio.netty.codec.httpio.netty.codec.http2io.netty.codec.memcacheio.netty.codec.mqttio.netty.codec.redisio.netty.codec.smtpio.netty.codec.socksio.netty.codec.stompio.netty.codec.xmlio.netty.commonio.netty.handlerio.netty.handler.proxyio.netty.resolverio.netty.resolver.dnsio.netty.transportio.netty.transport.epoll(nativeomitted - reserved keyword in Java)io.netty.transport.kqueue(nativeomitted - reserved keyword in Java)io.netty.transport.unix.common(nativeomitted - reserved keyword in Java)io.netty.transport.rxtxio.netty.transport.sctpio.netty.transport.udt
Automatic modules do not provide any means to declare dependencies, so you need to list each used module separately
in your module-info file.