Scott Mitchell 413c7c2cd8 Set readPending to false when ever a read is done ... Motivation: readPending is currently only set to false if data is delivered to the application, however this may result in duplicate events being received from the selector in the event that the socket was closed. Modifications: - We should set readPending to false before each read attempt for all transports besides NIO. - Based upon the Javadocs it is possible that NIO may have spurious wakeups [1]. In this case we should be more cautious and only set readPending to false if data was actually read. [1] https://docs.oracle.com/javase/7/docs/api/java/nio/channels/SelectionKey.html That a selection key's ready set indicates that its channel is ready for some operation category is a hint, but not a guarantee, that an operation in such a category may be performed by a thread without causing the thread to block. Result: Notification from the selector (or simulated events from kqueue/epoll ET) in the event of socket closure. Fixes https://github.com/netty/netty/issues/7255		2017-10-25 08:25:54 -07:00
..
main/java/io/netty	Set readPending to false when ever a read is done	2017-10-25 08:25:54 -07:00
test/java/io/netty	Correctly update Channel writability when queueing data in SslHandler.	2017-10-24 09:13:15 +02:00