af4b71a00e
- Fixes #1229 - Primarily written by @normanmaurer and revised by @trustin This commit removes the notion of unfolding from the codec framework completely. Unfolding was introduced in Netty 3.x to work around the shortcoming of the codec framework where encode() and decode() did not allow generating multiple messages. Such a shortcoming can be fixed by changing the signature of encode() and decode() instead of introducing an obscure workaround like unfolding. Therefore, we changed the signature of them in 4.0. The change is simple, but backward-incompatible. encode() and decode() do not return anything. Instead, the codec framework will pass a MessageBuf<Object> so encode() and decode() can add the generated messages into the MessageBuf.
68 lines
2.5 KiB
Java
68 lines
2.5 KiB
Java
/*
|
|
* Copyright 2012 The Netty Project
|
|
*
|
|
* The Netty Project licenses this file to you under the Apache License,
|
|
* version 2.0 (the "License"); you may not use this file except in compliance
|
|
* with the License. You may obtain a copy of the License at:
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
* License for the specific language governing permissions and limitations
|
|
* under the License.
|
|
*/
|
|
package io.netty.handler.codec.spdy;
|
|
|
|
import io.netty.buffer.BufUtil;
|
|
import io.netty.buffer.MessageBuf;
|
|
import io.netty.channel.ChannelHandlerContext;
|
|
import io.netty.handler.codec.MessageToMessageCodec;
|
|
import io.netty.handler.codec.http.HttpMessage;
|
|
|
|
import java.util.LinkedList;
|
|
import java.util.Queue;
|
|
|
|
/**
|
|
* {@link MessageToMessageCodec} that takes care of adding the right {@link SpdyHttpHeaders.Names#STREAM_ID} to the
|
|
* {@link HttpMessage} if one is not present. This makes it possible to just re-use plan handlers current used
|
|
* for HTTP.
|
|
*/
|
|
public class SpdyHttpResponseStreamIdHandler extends
|
|
MessageToMessageCodec<Object, HttpMessage> {
|
|
private static final Integer NO_ID = -1;
|
|
private final Queue<Integer> ids = new LinkedList<Integer>();
|
|
|
|
@Override
|
|
public boolean acceptInboundMessage(Object msg) throws Exception {
|
|
return msg instanceof HttpMessage || msg instanceof SpdyRstStreamFrame;
|
|
}
|
|
|
|
@Override
|
|
protected void encode(ChannelHandlerContext ctx, HttpMessage msg, MessageBuf<Object> out) throws Exception {
|
|
Integer id = ids.poll();
|
|
if (id != null && id.intValue() != NO_ID && !msg.headers().contains(SpdyHttpHeaders.Names.STREAM_ID)) {
|
|
SpdyHttpHeaders.setStreamId(msg, id);
|
|
}
|
|
|
|
out.add(BufUtil.retain(msg));
|
|
}
|
|
|
|
@Override
|
|
protected void decode(ChannelHandlerContext ctx, Object msg, MessageBuf<Object> out) throws Exception {
|
|
if (msg instanceof HttpMessage) {
|
|
boolean contains = ((HttpMessage) msg).headers().contains(SpdyHttpHeaders.Names.STREAM_ID);
|
|
if (!contains) {
|
|
ids.add(NO_ID);
|
|
} else {
|
|
ids.add(SpdyHttpHeaders.getStreamId((HttpMessage) msg));
|
|
}
|
|
} else if (msg instanceof SpdyRstStreamFrame) {
|
|
ids.remove(((SpdyRstStreamFrame) msg).getStreamId());
|
|
}
|
|
|
|
out.add(BufUtil.retain(msg));
|
|
}
|
|
}
|