andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
6,738 Commits 27 Branches 234 Tags 84 MiB
Java 99.8%
Shell 0.1%
b80a1a077c
Go to file
Norman Maurer b80a1a077c We need to ensure we correct reset decoder in decodeLast() to not produce multiple LastHttpContent instances. 
Motivation:

We missed to reset the decoder when asked for it in HttpObjectDecoder and so sometimes could produce more then one LastHttpContent in a sequence during channelInactive.

This did show up as AssertionError:

22:22:35.499 [nioEventLoopGroup-3-1] WARN  i.n.channel.DefaultChannelPipeline - An exceptionCaught() event was fired, and it reached at the tail of the pipeline. It usually means the last handler in the pipeline did not handle the exception.
java.lang.AssertionError: null
	at io.netty.handler.codec.http.HttpObjectAggregator.decode(HttpObjectAggregator.java:205) ~[classes/:na]
	at io.netty.handler.codec.http.HttpObjectAggregator.decode(HttpObjectAggregator.java:57) ~[classes/:na]
	at io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:89) ~[classes/:na]
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:292) [classes/:na]
	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:278) [classes/:na]
	at io.netty.channel.CombinedChannelDuplexHandler$DelegatingChannelHandlerContext.fireChannelRead(CombinedChannelDuplexHandler.java:428) [classes/:na]
	at io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:277) [classes/:na]
	at io.netty.handler.codec.ByteToMessageDecoder.channelInputClosed(ByteToMessageDecoder.java:343) [classes/:na]
	at io.netty.handler.codec.ByteToMessageDecoder.channelInactive(ByteToMessageDecoder.java:309) [classes/:na]
	at io.netty.handler.codec.http.HttpClientCodec$Decoder.channelInactive(HttpClientCodec.java:228) [classes/:na]
	at io.netty.channel.CombinedChannelDuplexHandler.channelInactive(CombinedChannelDuplexHandler.java:213) [classes/:na]
        ...

Modifications:

Correctly reset decoder.

Result:

Correctly only produce one LastHttpContent per sequence.
2016-04-14 09:33:10 +02:00
all [maven-release-plugin] prepare for next development iteration 2016-04-04 16:53:40 +02:00
buffer Fix IndexOutOfBoundsException when FixedCompositeByteBuf is constructed with an empty array. 2016-04-14 08:08:07 +02:00
codec [#4635] Stop decoding if decoder was removed in ReplayingDecoder 2016-04-14 08:25:32 +02:00
codec-haproxy [maven-release-plugin] prepare for next development iteration 2016-04-04 16:53:40 +02:00
codec-http We need to ensure we correct reset decoder in decodeLast() to not produce multiple LastHttpContent instances. 2016-04-14 09:33:10 +02:00
codec-socks Remove ByteBuf.readBytes(int) calls when possible 2016-04-09 18:44:58 +02:00
common Make all InternalLoggerFactory implementations be singletons 2016-04-08 09:39:47 +02:00
example [maven-release-plugin] prepare for next development iteration 2016-04-04 16:53:40 +02:00
handler Support preloading of tcnative share lib 2016-04-12 20:21:19 +02:00
license Let PoolThreadCache work even if allocation and deallocation Thread are different 2015-05-27 14:35:22 +02:00
microbench [maven-release-plugin] prepare for next development iteration 2016-04-04 16:53:40 +02:00
tarball [maven-release-plugin] prepare for next development iteration 2016-04-04 16:53:40 +02:00
testsuite Ensure EpollSocketChannel.localAddress() returns correct address after connect(...) call. 2016-04-09 19:04:59 +02:00
testsuite-osgi [maven-release-plugin] prepare for next development iteration 2016-04-04 16:53:40 +02:00
transport Revert "[#5028] Fix re-entrance issue with channelWritabilityChanged(...) and write(...)" 2016-04-09 20:33:32 +02:00
transport-native-epoll Support preloading of native epoll lib 2016-04-12 20:20:12 +02:00
transport-rxtx [maven-release-plugin] prepare for next development iteration 2016-04-04 16:53:40 +02:00
transport-sctp [maven-release-plugin] prepare for next development iteration 2016-04-04 16:53:40 +02:00
transport-udt [maven-release-plugin] prepare for next development iteration 2016-04-04 16:53:40 +02:00
.fbprefs Updated Find Bugs configuration 2009-03-04 10:33:09 +00:00
.gitignore Add JVM crash logs to .gitignore 2014-05-18 21:37:12 +09:00
.travis.yml Travis CI branch whitelisting 2013-03-11 09:55:43 +09:00
CONTRIBUTING.md Move the pull request guide to the developer guide 2014-03-12 13:18:14 +09:00
LICENSE.txt Relicensed to Apache License v2 2009-08-28 07:15:49 +00:00
NOTICE.txt Let PoolThreadCache work even if allocation and deallocation Thread are different 2015-05-27 14:35:22 +02:00
pom.xml [#4836] Enforce 64bit JDK when build netty. 2016-04-14 09:30:46 +02:00
README.md Updating Branches to look section to match the current branching structure of the project 2016-03-10 22:09:30 +01:00
run-example.sh Add logLevel property to enable different log levels for the examples. 2014-11-21 10:48:13 +09:00

README.md

Netty Project

Netty is an asynchronous event-driven network application framework for rapid development of maintainable high performance protocol servers & clients.

Links

How to build

For the detailed information about building and developing Netty, please visit the developer guide. This page only gives very basic information.

You require the following to build Netty:

Note that this is build-time requirement. JDK 5 (for 3.x) or 6 (for 4.0+) is enough to run your Netty-based application.

Branches to look

Development of all versions takes place in each branch whose name is identical to <majorVersion>.<minorVersion>. For example, the development of 3.9 and 4.0 resides in the branch '3.9' and the branch '4.0' respectively.