andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
bbb6e126b1
netty5/resolver-dns/src/main/java/io/netty/resolver/dns
History
Norman Maurer bbb6e126b1
Correctly handle DNS redirects for NS servers that have no ADDITIONAL record (#8177) 
Motiviation:

We incorrectly did ignore NS servers during redirect which had no ADDITIONAL record. This could at worse have the affect that we failed the query completely as none of the NS servers had a ADDITIONAL record. Beside this using a DnsCache to cache authoritative nameservers does not work in practise as we we need different features and semantics when cache these servers (for example we also want to cache unresolved nameservers and resolve these on the fly when needed).

Modifications:

- Correctly take NS records into account that have no matching ADDITIONAL record
- Correctly handle multiple ADDITIONAL records for the same NS record
- Introduce AuthoritativeDnsServerCache as a replacement of the DnsCache when caching authoritative nameservers + adding default implementation
- Add an adapter layer to reduce API breakage as much as possible
- Replace DnsNameResolver.uncachedRedirectDnsServerStream(...) with newRedirectDnsServerStream(...)
- Add unit tests

Result:

Our DnsResolver now correctly handle redirects in all cases.
2018-08-22 17:49:22 +02:00
..
AuthoritativeDnsServerCache.java Correctly handle DNS redirects for NS servers that have no ADDITIONAL record (#8177) 2018-08-22 17:49:22 +02:00
AuthoritativeDnsServerCacheAdapter.java Correctly handle DNS redirects for NS servers that have no ADDITIONAL record (#8177) 2018-08-22 17:49:22 +02:00
BiDnsQueryLifecycleObserver.java Replace DnsNameResolverContext#trace special code with an implementation of DnsQueryLifecycleObserver 2017-06-23 09:04:59 -07:00
BiDnsQueryLifecycleObserverFactory.java Replace DnsNameResolverContext#trace special code with an implementation of DnsQueryLifecycleObserver 2017-06-23 09:04:59 -07:00
Cache.java Correctly handle DNS redirects for NS servers that have no ADDITIONAL record (#8177) 2018-08-22 17:49:22 +02:00
DefaultAuthoritativeDnsServerCache.java Correctly handle DNS redirects for NS servers that have no ADDITIONAL record (#8177) 2018-08-22 17:49:22 +02:00
DefaultDnsCache.java Correctly handle DNS redirects for NS servers that have no ADDITIONAL record (#8177) 2018-08-22 17:49:22 +02:00
DefaultDnsServerAddresses.java Correctly handle DNS redirects for NS servers that have no ADDITIONAL record (#8177) 2018-08-22 17:49:22 +02:00
DefaultDnsServerAddressStreamProvider.java Correctly handle DNS redirects for NS servers that have no ADDITIONAL record (#8177) 2018-08-22 17:49:22 +02:00
DnsAddressDecoder.java Add DnsNameResolver.resolveAll(DnsQuestion) (#7803) 2018-03-29 22:01:25 +02:00
DnsAddressResolveContext.java Correctly handle DNS redirects for NS servers that have no ADDITIONAL record (#8177) 2018-08-22 17:49:22 +02:00
DnsAddressResolverGroup.java DnsAddressResolverGroup to use pluggable DnsNameResolverBuilder (#7793) 2018-04-26 08:04:01 +02:00
DnsCache.java Allow to detect failed query caused by an Timeout / IO error and also not cache these. 2017-11-23 10:56:41 +01:00
DnsCacheEntry.java Decouple DnsCache and DnsCacheEntry 2017-08-21 11:15:27 -07:00
DnsNameResolver.java Correctly handle DNS redirects for NS servers that have no ADDITIONAL record (#8177) 2018-08-22 17:49:22 +02:00
DnsNameResolverBuilder.java Correctly handle DNS redirects for NS servers that have no ADDITIONAL record (#8177) 2018-08-22 17:49:22 +02:00
DnsNameResolverException.java Allow to detect failed query caused by an Timeout / IO error and also not cache these. 2017-11-23 10:56:41 +01:00
DnsNameResolverTimeoutException.java Allow to detect failed query caused by an Timeout / IO error and also not cache these. 2017-11-23 10:56:41 +01:00
DnsQueryContext.java Remove id from DnsQueryContextManager whenever the promise is fullfilled. 2018-06-27 10:20:59 +02:00
DnsQueryContextManager.java fix the typos 2017-04-20 04:56:09 +02:00
DnsQueryLifecycleObserver.java DNS Resolver visibility into individual queries 2017-04-27 15:17:20 -07:00
DnsQueryLifecycleObserverFactory.java DNS Resolver visibility into individual queries 2017-04-27 15:17:20 -07:00
DnsRecordResolveContext.java Always follow cnames even if a matching A or AAAA record was found. (#7919) 2018-05-09 13:48:20 +02:00
DnsResolveContext.java Correctly handle DNS redirects for NS servers that have no ADDITIONAL record (#8177) 2018-08-22 17:49:22 +02:00
DnsServerAddresses.java Correctly handle DNS redirects for NS servers that have no ADDITIONAL record (#8177) 2018-08-22 17:49:22 +02:00
DnsServerAddressStream.java DNS Resolver should be more consistent with JDK resolution 2017-07-05 09:10:59 -04:00
DnsServerAddressStreamProvider.java DNS Resolve ambiguity in which DNS servers are used during resolution 2017-03-31 15:29:49 -07:00
DnsServerAddressStreamProviders.java Don't try to use UnixResolverDnsServerAddressStreamProvider when on Windows. 2017-11-13 20:26:38 +01:00
InflightNameResolver.java Do not send duplicate DNS queries when the same query is in progress already 2016-05-17 15:07:36 +02:00
MultiDnsServerAddressStreamProvider.java DNS Resolve ambiguity in which DNS servers are used during resolution 2017-03-31 15:29:49 -07:00
NameServerComparator.java Correctly handle DNS redirects for NS servers that have no ADDITIONAL record (#8177) 2018-08-22 17:49:22 +02:00
NoopAuthoritativeDnsServerCache.java Correctly handle DNS redirects for NS servers that have no ADDITIONAL record (#8177) 2018-08-22 17:49:22 +02:00
NoopDnsCache.java Decouple DnsCache and DnsCacheEntry 2017-08-21 11:15:27 -07:00
NoopDnsQueryLifecycleObserver.java DNS Resolver visibility into individual queries 2017-04-27 15:17:20 -07:00
NoopDnsQueryLifecycleObserverFactory.java DNS Resolver visibility into individual queries 2017-04-27 15:17:20 -07:00
package-info.java [#5088] Add annotation which marks packages/interfaces/classes as unstable 2016-05-09 15:16:35 +02:00
RotationalDnsServerAddresses.java Correctly handle DNS redirects for NS servers that have no ADDITIONAL record (#8177) 2018-08-22 17:49:22 +02:00
RoundRobinDnsAddressResolverGroup.java DnsAddressResolverGroup to use pluggable DnsNameResolverBuilder (#7793) 2018-04-26 08:04:01 +02:00
SequentialDnsServerAddressStream.java Correctly handle DNS redirects for NS servers that have no ADDITIONAL record (#8177) 2018-08-22 17:49:22 +02:00
SequentialDnsServerAddressStreamProvider.java DNS Resolver should be more consistent with JDK resolution 2017-07-05 09:10:59 -04:00
ShuffledDnsServerAddressStream.java Correctly handle DNS redirects for NS servers that have no ADDITIONAL record (#8177) 2018-08-22 17:49:22 +02:00
SingletonDnsServerAddresses.java DNS Resolver should be more consistent with JDK resolution 2017-07-05 09:10:59 -04:00
SingletonDnsServerAddressStreamProvider.java DNS Resolver should be more consistent with JDK resolution 2017-07-05 09:10:59 -04:00
TraceDnsQueryLifecycleObserver.java Replace DnsNameResolverContext#trace special code with an implementation of DnsQueryLifecycleObserver 2017-06-23 09:04:59 -07:00
TraceDnsQueryLifeCycleObserverFactory.java Replace DnsNameResolverContext#trace special code with an implementation of DnsQueryLifecycleObserver 2017-06-23 09:04:59 -07:00
UniSequentialDnsServerAddressStreamProvider.java DNS Resolver should be more consistent with JDK resolution 2017-07-05 09:10:59 -04:00
UnixResolverDnsServerAddressStreamProvider.java UnixResolverDnsServerAddressStreamProvider should allow for empty /etc/resolver dir 2017-07-05 20:14:27 -04:00