35db3c6710
Motivation: Found performance issues via FindBugs and PMD. Modifications: - Removed unnecessary boxing/unboxing operations in DefaultTextHeaders.convertToInt(CharSequence) and DefaultTextHeaders.convertToLong(CharSequence). A boxed primitive is created from a string, just to extract the unboxed primitive value. - Added a static modifier for DefaultHttp2Connection.ParentChangedEvent class. This class is an inner class, but does not use its embedded reference to the object which created it. This reference makes the instances of the class larger, and may keep the reference to the creator object alive longer than necessary. - Added a static compiled Pattern to avoid compile it each time it is used when we need to replace some part of authority. - Improved using of StringBuilders. Result: Performance improvements.
57 lines
1.4 KiB
Java
57 lines
1.4 KiB
Java
/*
|
|
* Copyright 2013 The Netty Project
|
|
*
|
|
* The Netty Project licenses this file to you under the Apache License,
|
|
* version 2.0 (the "License"); you may not use this file except in compliance
|
|
* with the License. You may obtain a copy of the License at:
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
* License for the specific language governing permissions and limitations
|
|
* under the License.
|
|
*/
|
|
package io.netty.handler.codec.spdy;
|
|
|
|
import io.netty.util.internal.StringUtil;
|
|
|
|
/**
|
|
* The default {@link SpdyPingFrame} implementation.
|
|
*/
|
|
public class DefaultSpdyPingFrame implements SpdyPingFrame {
|
|
|
|
private int id;
|
|
|
|
/**
|
|
* Creates a new instance.
|
|
*
|
|
* @param id the unique ID of this frame
|
|
*/
|
|
public DefaultSpdyPingFrame(int id) {
|
|
setId(id);
|
|
}
|
|
|
|
@Override
|
|
public int id() {
|
|
return id;
|
|
}
|
|
|
|
@Override
|
|
public SpdyPingFrame setId(int id) {
|
|
this.id = id;
|
|
return this;
|
|
}
|
|
|
|
@Override
|
|
public String toString() {
|
|
return new StringBuilder()
|
|
.append(StringUtil.simpleClassName(this))
|
|
.append(StringUtil.NEWLINE)
|
|
.append("--> ID = ")
|
|
.append(id())
|
|
.toString();
|
|
}
|
|
}
|