Motivation: We should fail fast when DefaultChannelPromise is constructed with null as Channel as otherwise it will fail with a NPE once we call setSuccess / setFailure. Modifications: Add null check and test. Result: Fail fast.
39 lines
1.3 KiB
Java
39 lines
1.3 KiB
Java
/*
|
|
* Copyright 2017 The Netty Project
|
|
*
|
|
* The Netty Project licenses this file to you under the Apache License,
|
|
* version 2.0 (the "License"); you may not use this file except in compliance
|
|
* with the License. You may obtain a copy of the License at:
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
* License for the specific language governing permissions and limitations
|
|
* under the License.
|
|
*/
|
|
package io.netty.channel;
|
|
|
|
import io.netty.channel.embedded.EmbeddedChannel;
|
|
import io.netty.util.concurrent.ImmediateEventExecutor;
|
|
import org.junit.Test;
|
|
|
|
public class DefaultChannelPromiseTest {
|
|
|
|
@Test(expected = NullPointerException.class)
|
|
public void testNullChannel() {
|
|
new DefaultChannelPromise(null);
|
|
}
|
|
|
|
@Test(expected = NullPointerException.class)
|
|
public void testChannelWithNullExecutor() {
|
|
new DefaultChannelPromise(new EmbeddedChannel(), null);
|
|
}
|
|
|
|
@Test(expected = NullPointerException.class)
|
|
public void testNullChannelWithExecutor() {
|
|
new DefaultChannelPromise(null, ImmediateEventExecutor.INSTANCE);
|
|
}
|
|
}
|