81e43d5088
Motivation: `DefaultFileRegion.transferTo` will return 0 all the time when we request more data then the actual file size. This may result in a busy spin while processing the fileregion during writes. Modifications: - If we wrote 0 bytes check if the underlying file size is smaller then the requested count and if so throw an IOException - Add DefaultFileRegionTest - Add a test to the testsuite Result: Fixes https://github.com/netty/netty/issues/8868.
121 lines
3.9 KiB
Java
121 lines
3.9 KiB
Java
/*
|
|
* Copyright 2019 The Netty Project
|
|
*
|
|
* The Netty Project licenses this file to you under the Apache License,
|
|
* version 2.0 (the "License"); you may not use this file except in compliance
|
|
* with the License. You may obtain a copy of the License at:
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
* License for the specific language governing permissions and limitations
|
|
* under the License.
|
|
*/
|
|
package io.netty.channel;
|
|
|
|
import io.netty.util.internal.PlatformDependent;
|
|
import org.junit.Test;
|
|
|
|
import java.io.ByteArrayOutputStream;
|
|
import java.io.File;
|
|
import java.io.FileOutputStream;
|
|
import java.io.IOException;
|
|
import java.io.RandomAccessFile;
|
|
import java.nio.channels.Channels;
|
|
import java.nio.channels.WritableByteChannel;
|
|
|
|
import static org.junit.Assert.assertArrayEquals;
|
|
import static org.junit.Assert.assertEquals;
|
|
import static org.junit.Assert.fail;
|
|
|
|
public class DefaultFileRegionTest {
|
|
|
|
private static final byte[] data = new byte[1048576 * 10];
|
|
|
|
static {
|
|
PlatformDependent.threadLocalRandom().nextBytes(data);
|
|
}
|
|
|
|
private static File newFile() throws IOException {
|
|
File file = File.createTempFile("netty-", ".tmp");
|
|
file.deleteOnExit();
|
|
|
|
final FileOutputStream out = new FileOutputStream(file);
|
|
out.write(data);
|
|
out.close();
|
|
return file;
|
|
}
|
|
|
|
@Test
|
|
public void testCreateFromFile() throws IOException {
|
|
File file = newFile();
|
|
try {
|
|
testFileRegion(new DefaultFileRegion(file, 0, data.length));
|
|
} finally {
|
|
file.delete();
|
|
}
|
|
}
|
|
|
|
@Test
|
|
public void testCreateFromFileChannel() throws IOException {
|
|
File file = newFile();
|
|
RandomAccessFile randomAccessFile = new RandomAccessFile(file, "r");
|
|
try {
|
|
testFileRegion(new DefaultFileRegion(randomAccessFile.getChannel(), 0, data.length));
|
|
} finally {
|
|
randomAccessFile.close();
|
|
file.delete();
|
|
}
|
|
}
|
|
|
|
private static void testFileRegion(FileRegion region) throws IOException {
|
|
ByteArrayOutputStream outputStream = new ByteArrayOutputStream();
|
|
WritableByteChannel channel = Channels.newChannel(outputStream);
|
|
|
|
try {
|
|
assertEquals(data.length, region.count());
|
|
assertEquals(0, region.transferred());
|
|
assertEquals(data.length, region.transferTo(channel, 0));
|
|
assertEquals(data.length, region.count());
|
|
assertEquals(data.length, region.transferred());
|
|
assertArrayEquals(data, outputStream.toByteArray());
|
|
} finally {
|
|
channel.close();
|
|
}
|
|
}
|
|
|
|
@Test
|
|
public void testTruncated() throws IOException {
|
|
File file = newFile();
|
|
ByteArrayOutputStream outputStream = new ByteArrayOutputStream();
|
|
WritableByteChannel channel = Channels.newChannel(outputStream);
|
|
RandomAccessFile randomAccessFile = new RandomAccessFile(file, "rw");
|
|
|
|
try {
|
|
FileRegion region = new DefaultFileRegion(randomAccessFile.getChannel(), 0, data.length);
|
|
|
|
randomAccessFile.getChannel().truncate(data.length - 1024);
|
|
|
|
assertEquals(data.length, region.count());
|
|
assertEquals(0, region.transferred());
|
|
|
|
assertEquals(data.length - 1024, region.transferTo(channel, 0));
|
|
assertEquals(data.length, region.count());
|
|
assertEquals(data.length - 1024, region.transferred());
|
|
try {
|
|
region.transferTo(channel, data.length - 1024);
|
|
fail();
|
|
} catch (IOException expected) {
|
|
// expected
|
|
}
|
|
} finally {
|
|
channel.close();
|
|
|
|
randomAccessFile.close();
|
|
file.delete();
|
|
}
|
|
}
|
|
}
|