d580245afc
Motivation: The DefaultHttp2Conneciton.close method accounts for active streams being iterated and attempts to avoid reentrant modifications of the underlying stream map by using iterators to remove from the stream map. However there are a few issues: - While iterating over the stream map we don't prevent iterations over the active stream collection - Removing a single stream may actually remove > 1 streams due to closed non-leaf streams being preserved in the priority tree which may result in NPE Preserving closed non-leaf streams in the priority tree is no longer necessary with our current allocation algorithms, and so this feature (and related complexity) can be removed. Modifications: - DefaultHttp2Connection.close should prevent others from iterating over the active streams and reentrant modification scenarios which may result from this - DefaultHttp2Connection should not keep closed stream in the priority tree - Remove all associated code in DefaultHttp2RemoteFlowController which accounts for this case including the ReducedState object - This includes fixing writability changes which depended on ReducedState - Update unit tests Result: Fixes https://github.com/netty/netty/issues/5198
49 lines
1.4 KiB
Java
49 lines
1.4 KiB
Java
/*
|
|
* Copyright 2016 The Netty Project
|
|
*
|
|
* The Netty Project licenses this file to you under the Apache License,
|
|
* version 2.0 (the "License"); you may not use this file except in compliance
|
|
* with the License. You may obtain a copy of the License at:
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
* License for the specific language governing permissions and limitations
|
|
* under the License.
|
|
*/
|
|
package io.netty.util;
|
|
|
|
/**
|
|
* Represents a supplier of {@code boolean}-valued results.
|
|
*/
|
|
public interface BooleanSupplier {
|
|
/**
|
|
* Gets a boolean value.
|
|
* @return a boolean value.
|
|
* @throws Exception If an exception occurs.
|
|
*/
|
|
boolean get() throws Exception;
|
|
|
|
/**
|
|
* A supplier which always returns {@code false} and never throws.
|
|
*/
|
|
BooleanSupplier FALSE_SUPPLIER = new BooleanSupplier() {
|
|
@Override
|
|
public boolean get() {
|
|
return false;
|
|
}
|
|
};
|
|
|
|
/**
|
|
* A supplier which always returns {@code true} and never throws.
|
|
*/
|
|
BooleanSupplier TRUE_SUPPLIER = new BooleanSupplier() {
|
|
@Override
|
|
public boolean get() {
|
|
return true;
|
|
}
|
|
};
|
|
}
|