4a8d3a274c
Motivation: The usage of Invocation level for JMH fixture methods (setup/teardown) inccurs in a significant overhead in the benchmark time (see org.openjdk.jmh.annotations.Level documentation). In the case of CodecInputListBenchmark, benchmarks are far too small (less than 50ns) and the Invocation level setup offsets the measurement considerably. On such cases, the recommended fix patch is to include the setup/teardown code in the benchmark method. Modifications: Include the setup/teardown code in the relevant benchmark methods. Remove the setup/teardown methods from the benchmark class. Result: We run the entire benchmark 10 times with default parameters we observed: - ArrayList benchmark affected directly by JMH overhead is now from 15-80% faster. - CodecList benchmark is now 50% faster than original (even with the setup code being measured). - Recyclable ArrayList is ~30% slower. - All benchmarks have significant different means (ANOVA) and medians (Moore) Mode: Throughput (Higher the better) Method Full params Factor Modified (Median) Original (Median) recyclableArrayList (elements = 1) 0.615520967 21719082.75 35285691.2 recyclableArrayList (elements = 4) 0.699553431 17149442.76 24514843.31 arrayList (elements = 4) 1.152666631 27120407.18 23528404.88 codecOutList (elements = 1) 1.527275908 67251089.04 44033359.47 codecOutList (elements = 4) 1.596917095 59174088.78 37055204.03 arrayList (elements = 1) 1.878616889 62188238.24 33103204.06 Environment: Tests run on a Computational server with CPU: E5-1660-3.3GHZ (6 cores + HT), 64 GB RAM.
71 lines
2.2 KiB
Java
71 lines
2.2 KiB
Java
/*
|
|
* Copyright 2016 The Netty Project
|
|
*
|
|
* The Netty Project licenses this file to you under the Apache License,
|
|
* version 2.0 (the "License"); you may not use this file except in compliance
|
|
* with the License. You may obtain a copy of the License at:
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
* License for the specific language governing permissions and limitations
|
|
* under the License.
|
|
*/
|
|
package io.netty.handler.codec;
|
|
|
|
import io.netty.microbench.util.AbstractMicrobenchmark;
|
|
import io.netty.util.internal.RecyclableArrayList;
|
|
import org.openjdk.jmh.annotations.Benchmark;
|
|
import org.openjdk.jmh.annotations.Param;
|
|
import org.openjdk.jmh.annotations.Scope;
|
|
import org.openjdk.jmh.annotations.State;
|
|
import org.openjdk.jmh.annotations.TearDown;
|
|
|
|
import java.util.ArrayList;
|
|
import java.util.List;
|
|
|
|
@State(Scope.Benchmark)
|
|
public class CodecOutputListBenchmark extends AbstractMicrobenchmark {
|
|
|
|
private static final Object ELEMENT = new Object();
|
|
private CodecOutputList codecOutputList;
|
|
private RecyclableArrayList recycleableArrayList;
|
|
private List<Object> arrayList;
|
|
|
|
@Param({ "1", "4" })
|
|
public int elements;
|
|
|
|
@TearDown
|
|
public void destroy() {
|
|
codecOutputList.recycle();
|
|
recycleableArrayList.recycle();
|
|
}
|
|
|
|
@Benchmark
|
|
public void codecOutList() {
|
|
codecOutputList = CodecOutputList.newInstance();
|
|
benchmarkAddAndClear(codecOutputList, elements);
|
|
}
|
|
|
|
@Benchmark
|
|
public void recyclableArrayList() {
|
|
recycleableArrayList = RecyclableArrayList.newInstance(16);
|
|
benchmarkAddAndClear(recycleableArrayList, elements);
|
|
}
|
|
|
|
@Benchmark
|
|
public void arrayList() {
|
|
arrayList = new ArrayList<Object>(16);
|
|
benchmarkAddAndClear(arrayList, elements);
|
|
}
|
|
|
|
private static void benchmarkAddAndClear(List<Object> list, int elements) {
|
|
for (int i = 0; i < elements; i++) {
|
|
list.add(ELEMENT);
|
|
}
|
|
list.clear();
|
|
}
|
|
}
|