d9a6cf341c
Motivation: ByteBuf supports “marker indexes”. The intended use case for these is if a speculative operation (e.g. decode) is in process the user can “mark” and interface and refer to it later if the operation isn’t successful (e.g. not enough data). However this is rarely used in practice, requires extra memory to maintain, and introduces complexity in the state management for derived/pooled buffer initialization, resizing, and other operations which may modify reader/writer indexes. Modifications: Remove support for marking and adjust testcases / code. Result: Fixes https://github.com/netty/netty/issues/8535.
144 lines
5.3 KiB
Java
144 lines
5.3 KiB
Java
/*
|
|
* Copyright 2012 The Netty Project
|
|
*
|
|
* The Netty Project licenses this file to you under the Apache License,
|
|
* version 2.0 (the "License"); you may not use this file except in compliance
|
|
* with the License. You may obtain a copy of the License at:
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
* License for the specific language governing permissions and limitations
|
|
* under the License.
|
|
*/
|
|
package io.netty.handler.codec.socks;
|
|
|
|
import io.netty.buffer.ByteBuf;
|
|
import io.netty.buffer.Unpooled;
|
|
import io.netty.util.CharsetUtil;
|
|
import org.junit.Test;
|
|
|
|
import java.net.IDN;
|
|
import java.nio.CharBuffer;
|
|
|
|
import static org.junit.Assert.*;
|
|
|
|
public class SocksCmdRequestTest {
|
|
@Test
|
|
public void testConstructorParamsAreNotNull() {
|
|
try {
|
|
new SocksCmdRequest(null, SocksAddressType.UNKNOWN, "", 1);
|
|
} catch (Exception e) {
|
|
assertTrue(e instanceof NullPointerException);
|
|
}
|
|
|
|
try {
|
|
new SocksCmdRequest(SocksCmdType.UNKNOWN, null, "", 1);
|
|
} catch (Exception e) {
|
|
assertTrue(e instanceof NullPointerException);
|
|
}
|
|
|
|
try {
|
|
new SocksCmdRequest(SocksCmdType.UNKNOWN, SocksAddressType.UNKNOWN, null, 1);
|
|
} catch (Exception e) {
|
|
assertTrue(e instanceof NullPointerException);
|
|
}
|
|
}
|
|
|
|
@Test
|
|
public void testIPv4CorrectAddress() {
|
|
try {
|
|
new SocksCmdRequest(SocksCmdType.BIND, SocksAddressType.IPv4, "54.54.1111.253", 1);
|
|
} catch (Exception e) {
|
|
assertTrue(e instanceof IllegalArgumentException);
|
|
}
|
|
}
|
|
|
|
@Test
|
|
public void testIPv6CorrectAddress() {
|
|
try {
|
|
new SocksCmdRequest(SocksCmdType.BIND, SocksAddressType.IPv6, "xxx:xxx:xxx", 1);
|
|
} catch (Exception e) {
|
|
assertTrue(e instanceof IllegalArgumentException);
|
|
}
|
|
}
|
|
|
|
@Test
|
|
public void testIDNNotExceeds255CharsLimit() {
|
|
try {
|
|
new SocksCmdRequest(SocksCmdType.BIND, SocksAddressType.DOMAIN,
|
|
"παράδειγμα.δοκιμήπαράδειγμα.δοκιμήπαράδειγμα.δοκιμήπαράδειγμα.δοκιμή" +
|
|
"παράδειγμα.δοκιμήπαράδειγμα.δοκιμήπαράδειγμα.δοκιμήπαράδειγμα.δοκιμή" +
|
|
"παράδειγμα.δοκιμήπαράδειγμα.δοκιμήπαράδειγμα.δοκιμήπαράδειγμα.δοκιμή" +
|
|
"παράδειγμα.δοκιμήπαράδειγμα.δοκιμήπαράδειγμα.δοκιμήπαράδειγμα.δοκιμή", 1);
|
|
} catch (Exception e) {
|
|
assertTrue(e instanceof IllegalArgumentException);
|
|
}
|
|
}
|
|
|
|
@Test
|
|
public void testHostNotEncodedForUnknown() {
|
|
String asciiHost = "xn--e1aybc.xn--p1ai";
|
|
short port = 10000;
|
|
|
|
SocksCmdRequest rq = new SocksCmdRequest(SocksCmdType.BIND, SocksAddressType.UNKNOWN, asciiHost, port);
|
|
assertEquals(asciiHost, rq.host());
|
|
|
|
ByteBuf buffer = Unpooled.buffer(16);
|
|
rq.encodeAsByteBuf(buffer);
|
|
|
|
buffer.readerIndex(0);
|
|
assertEquals(SocksProtocolVersion.SOCKS5.byteValue(), buffer.readByte());
|
|
assertEquals(SocksCmdType.BIND.byteValue(), buffer.readByte());
|
|
assertEquals((byte) 0x00, buffer.readByte());
|
|
assertEquals(SocksAddressType.UNKNOWN.byteValue(), buffer.readByte());
|
|
assertFalse(buffer.isReadable());
|
|
|
|
buffer.release();
|
|
}
|
|
|
|
@Test
|
|
public void testIDNEncodeToAsciiForDomain() {
|
|
String host = "тест.рф";
|
|
CharBuffer asciiHost = CharBuffer.wrap(IDN.toASCII(host));
|
|
short port = 10000;
|
|
|
|
SocksCmdRequest rq = new SocksCmdRequest(SocksCmdType.BIND, SocksAddressType.DOMAIN, host, port);
|
|
assertEquals(host, rq.host());
|
|
|
|
ByteBuf buffer = Unpooled.buffer(24);
|
|
rq.encodeAsByteBuf(buffer);
|
|
|
|
buffer.readerIndex(0);
|
|
assertEquals(SocksProtocolVersion.SOCKS5.byteValue(), buffer.readByte());
|
|
assertEquals(SocksCmdType.BIND.byteValue(), buffer.readByte());
|
|
assertEquals((byte) 0x00, buffer.readByte());
|
|
assertEquals(SocksAddressType.DOMAIN.byteValue(), buffer.readByte());
|
|
assertEquals((byte) asciiHost.length(), buffer.readUnsignedByte());
|
|
assertEquals(asciiHost,
|
|
CharBuffer.wrap(buffer.readCharSequence(asciiHost.length(), CharsetUtil.US_ASCII)));
|
|
assertEquals(port, buffer.readUnsignedShort());
|
|
|
|
buffer.release();
|
|
}
|
|
|
|
@Test
|
|
public void testValidPortRange() {
|
|
try {
|
|
new SocksCmdRequest(SocksCmdType.BIND, SocksAddressType.DOMAIN,
|
|
"παράδειγμα.δοκιμήπαράδει", 0);
|
|
} catch (Exception e) {
|
|
assertTrue(e instanceof IllegalArgumentException);
|
|
}
|
|
|
|
try {
|
|
new SocksCmdRequest(SocksCmdType.BIND, SocksAddressType.DOMAIN,
|
|
"παράδειγμα.δοκιμήπαράδει", 65536);
|
|
} catch (Exception e) {
|
|
assertTrue(e instanceof IllegalArgumentException);
|
|
}
|
|
}
|
|
}
|