d9a6cf341c
Motivation: ByteBuf supports “marker indexes”. The intended use case for these is if a speculative operation (e.g. decode) is in process the user can “mark” and interface and refer to it later if the operation isn’t successful (e.g. not enough data). However this is rarely used in practice, requires extra memory to maintain, and introduces complexity in the state management for derived/pooled buffer initialization, resizing, and other operations which may modify reader/writer indexes. Modifications: Remove support for marking and adjust testcases / code. Result: Fixes https://github.com/netty/netty/issues/8535.
191 lines
6.7 KiB
Java
191 lines
6.7 KiB
Java
/*
|
|
* Copyright 2012 The Netty Project
|
|
*
|
|
* The Netty Project licenses this file to you under the Apache License,
|
|
* version 2.0 (the "License"); you may not use this file except in compliance
|
|
* with the License. You may obtain a copy of the License at:
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
* License for the specific language governing permissions and limitations
|
|
* under the License.
|
|
*/
|
|
package io.netty.handler.codec.socks;
|
|
|
|
import io.netty.buffer.ByteBuf;
|
|
import io.netty.buffer.Unpooled;
|
|
import io.netty.util.CharsetUtil;
|
|
import org.junit.Test;
|
|
|
|
import java.net.IDN;
|
|
import java.nio.CharBuffer;
|
|
|
|
import static org.junit.Assert.*;
|
|
|
|
public class SocksCmdResponseTest {
|
|
@Test
|
|
public void testConstructorParamsAreNotNull() {
|
|
try {
|
|
new SocksCmdResponse(null, SocksAddressType.UNKNOWN);
|
|
} catch (Exception e) {
|
|
assertTrue(e instanceof NullPointerException);
|
|
}
|
|
try {
|
|
new SocksCmdResponse(SocksCmdStatus.UNASSIGNED, null);
|
|
} catch (Exception e) {
|
|
assertTrue(e instanceof NullPointerException);
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Verifies content of the response when domain is not specified.
|
|
*/
|
|
@Test
|
|
public void testEmptyDomain() {
|
|
SocksCmdResponse socksCmdResponse = new SocksCmdResponse(SocksCmdStatus.SUCCESS, SocksAddressType.DOMAIN);
|
|
assertNull(socksCmdResponse.host());
|
|
assertEquals(0, socksCmdResponse.port());
|
|
ByteBuf buffer = Unpooled.buffer(20);
|
|
socksCmdResponse.encodeAsByteBuf(buffer);
|
|
byte[] expected = {
|
|
0x05, // version
|
|
0x00, // success reply
|
|
0x00, // reserved
|
|
0x03, // address type domain
|
|
0x01, // length of domain
|
|
0x00, // domain value
|
|
0x00, // port value
|
|
0x00
|
|
};
|
|
assertByteBufEquals(expected, buffer);
|
|
}
|
|
|
|
/**
|
|
* Verifies content of the response when IPv4 address is specified.
|
|
*/
|
|
@Test
|
|
public void testIPv4Host() {
|
|
SocksCmdResponse socksCmdResponse = new SocksCmdResponse(SocksCmdStatus.SUCCESS, SocksAddressType.IPv4,
|
|
"127.0.0.1", 80);
|
|
assertEquals("127.0.0.1", socksCmdResponse.host());
|
|
assertEquals(80, socksCmdResponse.port());
|
|
ByteBuf buffer = Unpooled.buffer(20);
|
|
socksCmdResponse.encodeAsByteBuf(buffer);
|
|
byte[] expected = {
|
|
0x05, // version
|
|
0x00, // success reply
|
|
0x00, // reserved
|
|
0x01, // address type IPv4
|
|
0x7F, // address 127.0.0.1
|
|
0x00,
|
|
0x00,
|
|
0x01,
|
|
0x00, // port
|
|
0x50
|
|
};
|
|
assertByteBufEquals(expected, buffer);
|
|
}
|
|
|
|
/**
|
|
* Verifies that empty domain is allowed Response.
|
|
*/
|
|
@Test
|
|
public void testEmptyBoundAddress() {
|
|
SocksCmdResponse socksCmdResponse = new SocksCmdResponse(SocksCmdStatus.SUCCESS, SocksAddressType.DOMAIN,
|
|
"", 80);
|
|
assertEquals("", socksCmdResponse.host());
|
|
assertEquals(80, socksCmdResponse.port());
|
|
ByteBuf buffer = Unpooled.buffer(20);
|
|
socksCmdResponse.encodeAsByteBuf(buffer);
|
|
byte[] expected = {
|
|
0x05, // version
|
|
0x00, // success reply
|
|
0x00, // reserved
|
|
0x03, // address type domain
|
|
0x00, // domain length
|
|
0x00, // port
|
|
0x50
|
|
};
|
|
assertByteBufEquals(expected, buffer);
|
|
}
|
|
|
|
@Test
|
|
public void testHostNotEncodedForUnknown() {
|
|
String asciiHost = "xn--e1aybc.xn--p1ai";
|
|
short port = 10000;
|
|
|
|
SocksCmdResponse rs = new SocksCmdResponse(SocksCmdStatus.SUCCESS, SocksAddressType.UNKNOWN, asciiHost, port);
|
|
assertEquals(asciiHost, rs.host());
|
|
|
|
ByteBuf buffer = Unpooled.buffer(16);
|
|
rs.encodeAsByteBuf(buffer);
|
|
|
|
buffer.readerIndex(0);
|
|
assertEquals(SocksProtocolVersion.SOCKS5.byteValue(), buffer.readByte());
|
|
assertEquals(SocksCmdStatus.SUCCESS.byteValue(), buffer.readByte());
|
|
assertEquals((byte) 0x00, buffer.readByte());
|
|
assertEquals(SocksAddressType.UNKNOWN.byteValue(), buffer.readByte());
|
|
assertFalse(buffer.isReadable());
|
|
|
|
buffer.release();
|
|
}
|
|
|
|
@Test
|
|
public void testIDNEncodeToAsciiForDomain() {
|
|
String host = "тест.рф";
|
|
CharBuffer asciiHost = CharBuffer.wrap(IDN.toASCII(host));
|
|
short port = 10000;
|
|
|
|
SocksCmdResponse rs = new SocksCmdResponse(SocksCmdStatus.SUCCESS, SocksAddressType.DOMAIN, host, port);
|
|
assertEquals(host, rs.host());
|
|
|
|
ByteBuf buffer = Unpooled.buffer(24);
|
|
rs.encodeAsByteBuf(buffer);
|
|
|
|
buffer.readerIndex(0);
|
|
assertEquals(SocksProtocolVersion.SOCKS5.byteValue(), buffer.readByte());
|
|
assertEquals(SocksCmdStatus.SUCCESS.byteValue(), buffer.readByte());
|
|
assertEquals((byte) 0x00, buffer.readByte());
|
|
assertEquals(SocksAddressType.DOMAIN.byteValue(), buffer.readByte());
|
|
assertEquals((byte) asciiHost.length(), buffer.readUnsignedByte());
|
|
assertEquals(asciiHost,
|
|
CharBuffer.wrap(buffer.readCharSequence(asciiHost.length(), CharsetUtil.US_ASCII)));
|
|
assertEquals(port, buffer.readUnsignedShort());
|
|
|
|
buffer.release();
|
|
}
|
|
|
|
/**
|
|
* Verifies that Response cannot be constructed with invalid IP.
|
|
*/
|
|
@Test(expected = IllegalArgumentException.class)
|
|
public void testInvalidBoundAddress() {
|
|
new SocksCmdResponse(SocksCmdStatus.SUCCESS, SocksAddressType.IPv4, "127.0.0", 1000);
|
|
}
|
|
|
|
private static void assertByteBufEquals(byte[] expected, ByteBuf actual) {
|
|
byte[] actualBytes = new byte[actual.readableBytes()];
|
|
actual.readBytes(actualBytes);
|
|
assertEquals("Generated response has incorrect length", expected.length, actualBytes.length);
|
|
assertArrayEquals("Generated response differs from expected", expected, actualBytes);
|
|
}
|
|
|
|
@Test
|
|
public void testValidPortRange() {
|
|
try {
|
|
new SocksCmdResponse(SocksCmdStatus.SUCCESS, SocksAddressType.IPv4, "127.0.0", 0);
|
|
} catch (Exception e) {
|
|
assertTrue(e instanceof IllegalArgumentException);
|
|
}
|
|
|
|
try {
|
|
new SocksCmdResponse(SocksCmdStatus.SUCCESS, SocksAddressType.IPv4, "127.0.0", 65536);
|
|
} catch (Exception e) {
|
|
assertTrue(e instanceof IllegalArgumentException);
|
|
}
|
|
}
|
|
}
|