48506f5b05
Motivation: We need to handle the trailing dot in the correct manner when creating DNS questions and responses. Modifications: - Add a trailing dot if not given to the hostname when construct a AbstractDnsRecord (this is the same as dig does). Result: Correctly handle trailing dots.
63 lines
2.3 KiB
Java
63 lines
2.3 KiB
Java
/*
|
|
* Copyright 2016 The Netty Project
|
|
*
|
|
* The Netty Project licenses this file to you under the Apache License,
|
|
* version 2.0 (the "License"); you may not use this file except in compliance
|
|
* with the License. You may obtain a copy of the License at:
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
* License for the specific language governing permissions and limitations
|
|
* under the License.
|
|
*/
|
|
package io.netty.handler.codec.dns;
|
|
|
|
import org.junit.Assert;
|
|
import org.junit.Test;
|
|
|
|
public class AbstractDnsRecordTest {
|
|
|
|
@Test
|
|
public void testValidDomainName() {
|
|
String name = "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa";
|
|
AbstractDnsRecord record = new AbstractDnsRecord(name, DnsRecordType.A, 0) { };
|
|
Assert.assertEquals(name + '.', record.name());
|
|
}
|
|
|
|
@Test
|
|
public void testValidDomainNameUmlaut() {
|
|
String name = "ä";
|
|
AbstractDnsRecord record = new AbstractDnsRecord(name, DnsRecordType.A, 0) { };
|
|
Assert.assertEquals("xn--4ca.", record.name());
|
|
}
|
|
|
|
@Test
|
|
public void testValidDomainNameTrailingDot() {
|
|
String name = "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa.";
|
|
AbstractDnsRecord record = new AbstractDnsRecord(name, DnsRecordType.A, 0) { };
|
|
Assert.assertEquals(name, record.name());
|
|
}
|
|
|
|
@Test
|
|
public void testValidDomainNameUmlautTrailingDot() {
|
|
String name = "ä.";
|
|
AbstractDnsRecord record = new AbstractDnsRecord(name, DnsRecordType.A, 0) { };
|
|
Assert.assertEquals("xn--4ca.", record.name());
|
|
}
|
|
|
|
@Test(expected = IllegalArgumentException.class)
|
|
public void testValidDomainNameLength() {
|
|
String name = "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa";
|
|
new AbstractDnsRecord(name, DnsRecordType.A, 0) { };
|
|
}
|
|
|
|
@Test(expected = IllegalArgumentException.class)
|
|
public void testValidDomainNameUmlautLength() {
|
|
String name = "äaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa";
|
|
new AbstractDnsRecord(name, DnsRecordType.A, 0) { };
|
|
}
|
|
}
|