andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
de690daccc
netty5/codec-smtp/src/main/java/io/netty/handler/codec/smtp
History
Norman Maurer 0e4c073bcf
Remove the intermediate List from ByteToMessageDecoder (and sub-class… (#8626) 
Motivation:

ByteToMessageDecoder requires using an intermediate List to put results into. This intermediate list adds overhead (memory/CPU) which grows as the number of objects increases. This overhead can be avoided by directly propagating events through the ChannelPipeline via ctx.fireChannelRead(...). This also makes the semantics more clear and allows us to keep track if we need to call ctx.read() in all cases.

Modifications:

- Remove List from the method signature of ByteToMessageDecoder.decode(...) and decodeLast(...)
- Adjust all sub-classes
- Adjust unit tests
- Fix javadocs.

Result:

Adjust ByteToMessageDecoder as noted in https://github.com/netty/netty/issues/8525.
2019-12-16 21:00:32 +01:00
..
DefaultLastSmtpContent.java Make retained derived buffers recyclable 2016-05-17 11:16:13 +02:00
DefaultSmtpContent.java Make retained derived buffers recyclable 2016-05-17 11:16:13 +02:00
DefaultSmtpRequest.java migrate java8: use requireNonNull (#8840) 2019-02-04 10:32:25 +01:00
DefaultSmtpResponse.java [#5088] Add annotation which marks packages/interfaces/classes as unstable 2016-05-09 15:16:35 +02:00
LastSmtpContent.java Make retained derived buffers recyclable 2016-05-17 11:16:13 +02:00
package-info.java [#5088] Add annotation which marks packages/interfaces/classes as unstable 2016-05-09 15:16:35 +02:00
SmtpCommand.java migrate java8: use requireNonNull (#8840) 2019-02-04 10:32:25 +01:00
SmtpContent.java Make retained derived buffers recyclable 2016-05-17 11:16:13 +02:00
SmtpRequest.java [#5088] Add annotation which marks packages/interfaces/classes as unstable 2016-05-09 15:16:35 +02:00
SmtpRequestEncoder.java Use ByteBuf#writeShort/writeMedium instead of writeBytes 2017-07-10 14:37:41 +02:00
SmtpRequests.java migrate java8: use requireNonNull (#8840) 2019-02-04 10:32:25 +01:00
SmtpResponse.java [#5088] Add annotation which marks packages/interfaces/classes as unstable 2016-05-09 15:16:35 +02:00
SmtpResponseDecoder.java Remove the intermediate List from ByteToMessageDecoder (and sub-class… (#8626) 2019-12-16 21:00:32 +01:00
SmtpUtils.java Add smtp codec (client side only). 2016-04-07 18:42:17 +02:00