Motivation: In the Internet Protocol, the valid port number range is from 1 to 65535 (inclusive on the both side.) However, SocksCmdRequest and SocksCmdResponse refuses to construct itself when the port number 65535 is specified. Beside this it excepts 0 as port number which should not allowed. Modification: * Not raise an exception when the specified port number is 65535. * Raise an exception when the specified port number is 0 Result: Fixes #2428
32 lines
1005 B
Java
32 lines
1005 B
Java
/*
|
|
* Copyright 2012 The Netty Project
|
|
*
|
|
* The Netty Project licenses this file to you under the Apache License,
|
|
* version 2.0 (the "License"); you may not use this file except in compliance
|
|
* with the License. You may obtain a copy of the License at:
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
* License for the specific language governing permissions and limitations
|
|
* under the License.
|
|
*/
|
|
package io.netty.handler.codec.socks;
|
|
|
|
import org.junit.Test;
|
|
import static org.junit.Assert.assertTrue;
|
|
|
|
public class SocksAuthResponseTest {
|
|
@Test
|
|
public void testConstructorParamsAreNotNull() {
|
|
try {
|
|
new SocksAuthResponse(null);
|
|
} catch (Exception e) {
|
|
assertTrue(e instanceof NullPointerException);
|
|
}
|
|
}
|
|
|
|
}
|