netty5/resolver-dns/src/main/java/io/netty/resolver/dns/NoopDnsCache.java
Scott Mitchell 566566db3a Decouple DnsCache and DnsCacheEntry
Motivation:
DnsCache (an interface) is coupled to DnsCacheEntry (a final class). This means that DnsCache implementations can't implement their own DnsCacheEntry objects if the default behavior isn't appropriate.

Modifications:
- DnsCacheEntry should be moved to DefaultDnsCache as it is an implementation detail
- DnsCache#cache(..) should return a new DnsCacheEntry
- The methods which from DnsCacheEntry that were used outside the scope of DefaultDnsCache should be moved into an interface

Result:
DnsCache is more extensible and not tightly coupled to a default implementation of DnsCacheEntry.
2017-08-21 11:15:27 -07:00

93 lines
2.4 KiB
Java

/*
* Copyright 2016 The Netty Project
*
* The Netty Project licenses this file to you under the Apache License,
* version 2.0 (the "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at:
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
* License for the specific language governing permissions and limitations
* under the License.
*/
package io.netty.resolver.dns;
import io.netty.channel.EventLoop;
import io.netty.handler.codec.dns.DnsRecord;
import io.netty.util.internal.UnstableApi;
import java.net.InetAddress;
import java.util.Collections;
import java.util.List;
/**
* A noop DNS cache that actually never caches anything.
*/
@UnstableApi
public final class NoopDnsCache implements DnsCache {
public static final NoopDnsCache INSTANCE = new NoopDnsCache();
/**
* Private singleton constructor.
*/
private NoopDnsCache() {
}
@Override
public void clear() {
}
@Override
public boolean clear(String hostname) {
return false;
}
@Override
public List<? extends DnsCacheEntry> get(String hostname, DnsRecord[] additionals) {
return Collections.emptyList();
}
@Override
public DnsCacheEntry cache(String hostname, DnsRecord[] additional,
InetAddress address, long originalTtl, EventLoop loop) {
return new NoopDnsCacheEntry(address);
}
@Override
public DnsCacheEntry cache(String hostname, DnsRecord[] additional, Throwable cause, EventLoop loop) {
return null;
}
@Override
public String toString() {
return NoopDnsCache.class.getSimpleName();
}
private static final class NoopDnsCacheEntry implements DnsCacheEntry {
private final InetAddress address;
NoopDnsCacheEntry(InetAddress address) {
this.address = address;
}
@Override
public InetAddress address() {
return address;
}
@Override
public Throwable cause() {
return null;
}
@Override
public String toString() {
return address.toString();
}
}
}