35db3c6710
Motivation: Found performance issues via FindBugs and PMD. Modifications: - Removed unnecessary boxing/unboxing operations in DefaultTextHeaders.convertToInt(CharSequence) and DefaultTextHeaders.convertToLong(CharSequence). A boxed primitive is created from a string, just to extract the unboxed primitive value. - Added a static modifier for DefaultHttp2Connection.ParentChangedEvent class. This class is an inner class, but does not use its embedded reference to the object which created it. This reference makes the instances of the class larger, and may keep the reference to the creator object alive longer than necessary. - Added a static compiled Pattern to avoid compile it each time it is used when we need to replace some part of authority. - Improved using of StringBuilders. Result: Performance improvements.
79 lines
2.7 KiB
Java
79 lines
2.7 KiB
Java
/*
|
|
* Copyright 2012 The Netty Project
|
|
*
|
|
* The Netty Project licenses this file to you under the Apache License,
|
|
* version 2.0 (the "License"); you may not use this file except in compliance
|
|
* with the License. You may obtain a copy of the License at:
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
* License for the specific language governing permissions and limitations
|
|
* under the License.
|
|
*/
|
|
package io.netty.handler.codec.http;
|
|
|
|
import io.netty.buffer.ByteBuf;
|
|
import io.netty.util.CharsetUtil;
|
|
|
|
import static io.netty.handler.codec.http.HttpConstants.*;
|
|
|
|
/**
|
|
* Encodes an {@link HttpRequest} or an {@link HttpContent} into
|
|
* a {@link ByteBuf}.
|
|
*/
|
|
public class HttpRequestEncoder extends HttpObjectEncoder<HttpRequest> {
|
|
private static final char SLASH = '/';
|
|
private static final char QUESTION_MARK = '?';
|
|
private static final byte[] CRLF = { CR, LF };
|
|
|
|
@Override
|
|
public boolean acceptOutboundMessage(Object msg) throws Exception {
|
|
return super.acceptOutboundMessage(msg) && !(msg instanceof HttpResponse);
|
|
}
|
|
|
|
@Override
|
|
protected void encodeInitialLine(ByteBuf buf, HttpRequest request) throws Exception {
|
|
request.method().encode(buf);
|
|
buf.writeByte(SP);
|
|
|
|
// Add / as absolute path if no is present.
|
|
// See http://tools.ietf.org/html/rfc2616#section-5.1.2
|
|
String uri = request.uri();
|
|
|
|
if (uri.length() == 0) {
|
|
uri += SLASH;
|
|
} else {
|
|
int start = uri.indexOf("://");
|
|
if (start != -1 && uri.charAt(0) != SLASH) {
|
|
int startIndex = start + 3;
|
|
// Correctly handle query params.
|
|
// See https://github.com/netty/netty/issues/2732
|
|
int index = uri.indexOf(QUESTION_MARK, startIndex);
|
|
if (index == -1) {
|
|
if (uri.lastIndexOf(SLASH) <= startIndex) {
|
|
uri += SLASH;
|
|
}
|
|
} else {
|
|
if (uri.lastIndexOf(SLASH, index) <= startIndex) {
|
|
int len = uri.length();
|
|
StringBuilder sb = new StringBuilder(len + 1);
|
|
sb.append(uri, 0, index)
|
|
.append(SLASH)
|
|
.append(uri, index, len);
|
|
uri = sb.toString();
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
buf.writeBytes(uri.getBytes(CharsetUtil.UTF_8));
|
|
|
|
buf.writeByte(SP);
|
|
request.protocolVersion().encode(buf);
|
|
buf.writeBytes(CRLF);
|
|
}
|
|
}
|