andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
ee206b6ba8
netty5/microbench/src/main/java/io/netty/handler/codec
History
Anuraag Agrawal ee206b6ba8 Separate out query string encoding for non-encoded strings. (#9887) 
Motivation:

Currently, characters are appended to the encoded string char-by-char even when no encoding is needed. We can instead separate out codepath that appends the entire string in one go for better `StringBuilder` allocation performance.

Modification:

Only go into char-by-char loop when finding a character that requires encoding.

Result:

The results aren't so clear with noise on my hot laptop - the biggest impact is on long strings, both to reduce resizes of the buffer and also to reduce complexity of the loop. I don't think there's a significant downside though for the cases that hit the slow path.

After
```
Benchmark                                     Mode  Cnt   Score   Error   Units
QueryStringEncoderBenchmark.longAscii        thrpt    6   1.406 ± 0.069  ops/us
QueryStringEncoderBenchmark.longAsciiFirst   thrpt    6   0.046 ± 0.001  ops/us
QueryStringEncoderBenchmark.longUtf8         thrpt    6   0.046 ± 0.001  ops/us
QueryStringEncoderBenchmark.shortAscii       thrpt    6  15.781 ± 0.949  ops/us
QueryStringEncoderBenchmark.shortAsciiFirst  thrpt    6   3.171 ± 0.232  ops/us
QueryStringEncoderBenchmark.shortUtf8        thrpt    6   3.900 ± 0.667  ops/us
```

Before
```
Benchmark                                     Mode  Cnt   Score    Error   Units
QueryStringEncoderBenchmark.longAscii        thrpt    6   0.444 ±  0.072  ops/us
QueryStringEncoderBenchmark.longAsciiFirst   thrpt    6   0.043 ±  0.002  ops/us
QueryStringEncoderBenchmark.longUtf8         thrpt    6   0.047 ±  0.001  ops/us
QueryStringEncoderBenchmark.shortAscii       thrpt    6  16.503 ±  1.015  ops/us
QueryStringEncoderBenchmark.shortAsciiFirst  thrpt    6   3.316 ±  0.154  ops/us
QueryStringEncoderBenchmark.shortUtf8        thrpt    6   3.776 ±  0.956  ops/us
```
2019-12-20 08:51:26 +01:00
..
http Separate out query string encoding for non-encoded strings. (#9887) 2019-12-20 08:51:26 +01:00
http2 Increase maxHeaderListSize for HpackDecoderBenchmark to be able to be… (#9321) 2019-07-04 11:24:37 +02:00
AdvancedCodecOutputListBenchmark.java Use FastThreadLocal for CodecOutputList 2018-01-23 11:34:28 +01:00
CodecOutputListBenchmark.java Java 8 migration: Use diamond operator (#8749) 2019-01-22 16:07:26 +01:00
DateFormatter2Benchmark.java Improve DateFormatter parsing performance (#8821) 2019-02-04 10:04:35 +01:00
package-info.java Introduce CodecOutputList to reduce overhead of encoder/decoder 2016-05-20 09:12:07 +02:00