andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
5,727 Commits 27 Branches 234 Tags 84 MiB
Java 99.8%
Shell 0.1%
ef53227836
Go to file
Frederic Bregier ef53227836 [#2305] Fix issue related to decoding post request raized an exception due to a split of information by chunk not correctly taken into account by the decoder 
Motivation:

If the last item analyzed in a previous received HttpChunk/HttpContent was a part of an attribute's name, the read index was not set to the new right place and therefore raizing an exception in some case (since the "new" name analyzed is empty, which is not allowed so the exception).

What appears there is that the read index should be reset to the last valid position encountered whatever the case. Currently it was set when only when there is an attribute not already finished (name is ok, but content is possibly not).

Therefore the issue is that elements could be rescanned multiple times (including completed elements) and moreover some bad decoding can occur such as when in a middle of an attribute's name.

Modifications:

To fix this issue, since "firstpos" contains the last "valid" read index of the decoding (when finding a '&', '=', 'CR/LF'), we should add the setting of the read index for the following cases:

'lastchunk' encountered, therefore finishing the current buffer
any other cases than current attribute is not finished (name not found yet in particular)
So adding for this 2 cases:

undecodedChunk.readerIndex(firstpos);

Result:

Now the decoding is done once, content is added from chunk/content to chunk/content, name is decoded correctly even if in the middle of 2 chunks/contents.
A Junit test code was added: testChunkCorrect that should not raized any exception.
2014-03-14 09:46:58 +01:00
all Ensure native transport is included in all and tarball 2014-02-17 22:46:33 +01:00
buffer Fix limit computation of NIO ByteBuffers obtained via ReadOnlyByteBufferBuf.nioBuffer 2014-03-14 08:10:29 +01:00
codec Remove condition in ChannelHandlerAdapter.isSharable() by caching the result of the annotation lookup. 2014-03-12 13:43:39 +01:00
codec-http [#2305] Fix issue related to decoding post request raized an exception due to a split of information by chunk not correctly taken into account by the decoder 2014-03-14 09:46:58 +01:00
codec-memcache [codec-memcache] Simplify object hierachy and remove Headers. 2014-03-04 13:04:44 +01:00
codec-socks Fix an inspector warning 2014-02-06 15:03:03 -08:00
common [#2307] Remove synchronized bottleneck in SingleThreadEventExecutor.execute(...) 2014-03-13 10:28:43 +01:00
example Ensure the HttpResponseEncoder is always placed before the HttpObjectAggregator. Part of [#2219] 2014-03-05 06:58:54 +01:00
handler Do not use finally to propagate events in AbstractRemoteAddressFilter 2014-03-12 16:18:10 +09:00
license [#1259] Add optimized queue for SCMP pattern and use it in NIO and native transport 2014-02-27 13:56:15 +01:00
microbench Upgrade JMH to 0.4.1 and make use of @Params. 2014-02-23 16:39:15 +01:00
tarball [maven-release-plugin] prepare for next development iteration 2013-12-22 22:06:15 +09:00
testsuite Ensure the HttpResponseEncoder is always placed before the HttpObjectAggregator. Part of [#2219] 2014-03-05 06:58:54 +01:00
transport [#2308] Use SelectorProvider.open*() to open NIO channels and so remove condition when create new NIO channels. 2014-03-13 07:03:20 +01:00
transport-native-epoll [#2297] Correctly close all registered Channels on EpollEventLoop.closeAll() 2014-03-10 20:37:27 +01:00
transport-rxtx Apply receive timeout to commPort when using RxtxChannel. Part of [#1390] 2014-02-23 16:35:35 +01:00
transport-sctp Directly use memory addresses for gathering writes to reduce gc pressure. Part of [#2239] 2014-02-21 14:16:37 +01:00
transport-udt Enable a user specify an arbitrary information with ReferenceCounted.touch() 2014-01-29 11:44:59 +09:00
.fbfilter.xml Update license headers 2012-06-04 13:31:44 -07:00
.fbprefs Updated Find Bugs configuration 2009-03-04 10:33:09 +00:00
.gitignore Format and partially describe Gitignore 2013-12-10 07:03:43 +01:00
.travis.yml Travis CI branch whitelisting 2013-03-11 09:55:43 +09:00
CONTRIBUTING.md Move the pull request guide to the developer guide 2014-03-12 13:17:58 +09:00
LICENSE.txt Relicensed to Apache License v2 2009-08-28 07:15:49 +00:00
NOTICE.txt [#1259] Add optimized queue for SCMP pattern and use it in NIO and native transport 2014-02-27 13:56:15 +01:00
pom.xml Remove sniffer whitelist entries for NIO.2 2014-03-13 07:03:29 +01:00
README.md Fix the 'branches to look' section 2014-01-16 14:37:54 +09:00

README.md

Netty Project

Netty is an asynchronous event-driven network application framework for rapid development of maintainable high performance protocol servers & clients.

Links

How to build

For the detailed information about building and developing Netty, please visit the developer guide. This page only gives very basic information.

You require the following to build Netty:

Note that this is build-time requirement. JDK 5 (for 3.x) or 6 (for 4.0+) is enough to run your Netty-based application.

Branches to look

The 'master' branch is where the development of the latest major version lives on. The development of all other versions takes place in each branch whose name is identical to <majorVersion>.<minorVersion>. For example, the development of 3.9 and 4.0 resides in the branch '3.9' and the branch '4.0' respectively.