netty5/common/src
Norman Maurer f6f7564602 Don't update state of PromiseCombiner when finish(null) is called (#8843)
Motivation:

When we fail a call to PromiseCombiner.finish(...) because of a null argument we must not update the internal state before throwing.

Modifications:

- First do the null check and only after we validated that the argument is not null update the internal state
- Add test case.

Modifications:

Do not mess up internal state of PromiseCombiner when finish(...) is called with a null argument.

Result:

After your change, what will change.
2019-02-04 19:15:57 +01:00
..
main Don't update state of PromiseCombiner when finish(null) is called (#8843) 2019-02-04 19:15:57 +01:00
test Don't update state of PromiseCombiner when finish(null) is called (#8843) 2019-02-04 19:15:57 +01:00