Go to file
Julien Viet f85583047e KQueueEventLoop | EpollEventLoop may incorrectly update registration when FD is reused.
Motivation:

The current KQueueEventLoop implementation does not process concurrent domain socket channel registration/unregistration in the order they actual
happen since unregistration are delated by an event loop task scheduling. When a domain socket is closed, it's file descriptor might be reused
quickly and therefore trigger a new channel registration using the same descriptor.

Consequently the KQueueEventLoop#add(AbstractKQueueChannel) method will overwrite the current inactive channels having the same descriptor
and the delayed KQueueEventLoop#remove(AbstractKQueueChannel) will remove the active channel that replaced the inactive one.

As active channels are registered, events for this file descriptor won't be processed anymore and the channels will never be closed.

The same problem can also happen in EpollEventLoop. Beside this we also may never remove the AbstractEpollChannel from the internal map
when it is unregistered which will prevent it from be GC'ed

Modifications:

- Change logic of native KQueue and Epoll implementations to ensure we correctly handle the case of FD reuse
- Only try to update kevent / epoll if the Channel is still open (as otherwise it will be handled by kqueue / epoll itself)
- Correctly remove AbstractEpollChannel from internal map in all cases
- Make implementation of closeAll() consistent for Epoll and KQueueEventLoop

Result:

KQueue and Epoll native transports correctly handle FD reuse

Co-authored-by: Norman Maurer <norman_maurer@apple.com>
2019-05-22 10:11:42 +02:00
.github Use GitHub Issue/PR Template Feature 2016-12-07 11:40:26 -08:00
.mvn support publishing snapshots from docker based ci (#8634) 2018-12-07 06:16:39 +01:00
all Always include classes from all native transports no matter on which platfrom netty-all is build (#9111) 2019-04-30 23:24:14 +02:00
bom Remove OIO transport (and transports that depend on it). (#8580) 2018-11-21 15:23:18 +01:00
buffer Prefer direct io buffers if direct buffers pooled (#9167) 2019-05-22 07:33:06 +02:00
codec Only use static Exception instances when we can ensure addSuppressed … (#9152) 2019-05-17 22:42:53 +02:00
codec-dns Add support for TCP fallback when we receive a truncated DnsResponse (#9139) 2019-05-17 14:47:10 +02:00
codec-haproxy migrate java8: use requireNonNull (#8840) 2019-02-04 10:32:25 +01:00
codec-http Format code to align unaligned code. (#9062) 2019-05-20 12:07:45 +02:00
codec-http2 Only use static Exception instances when we can ensure addSuppressed … (#9152) 2019-05-17 22:42:53 +02:00
codec-memcache use checkPositive/checkPositiveOrZero (#8835) 2019-02-04 15:55:07 +01:00
codec-mqtt migrate java8: use requireNonNull (#8840) 2019-02-04 10:32:25 +01:00
codec-redis migrate java8: use requireNonNull (#8840) 2019-02-04 10:32:25 +01:00
codec-smtp SmtpRequestEncoderTest ByteBuf leak (#9075) 2019-04-19 08:47:28 +02:00
codec-socks migrate java8: use requireNonNull (#8840) 2019-02-04 10:32:25 +01:00
codec-stomp use checkPositive/checkPositiveOrZero (#8835) 2019-02-04 15:55:07 +01:00
codec-xml Update to new checkstyle plugin (#8777) 2019-01-24 16:24:19 +01:00
common Only use static Exception instances when we can ensure addSuppressed … (#9152) 2019-05-17 22:42:53 +02:00
dev-tools Update version number to start working on Netty 5 2018-11-20 15:49:57 +01:00
docker Update to latest JDK13 EA release (#9166) 2019-05-21 20:10:34 +02:00
example Allow to specify KeyStore type in SslContext (#9003) 2019-05-10 07:51:20 +02:00
handler Remove usage of io.netty.handler.ssl.openssl.useKeyManagerFactory system property 2019-05-22 09:09:32 +02:00
handler-proxy Remove code that accounts for changing EventExecutors in DefaultPromise (#8996) 2019-04-03 10:36:55 +02:00
license Add the NOTICE of the forked portion of Apache Harmony 2018-01-30 11:22:51 +01:00
microbench The benchmark is not taking into account nanoTime granularity (#9033) 2019-04-15 15:15:08 +02:00
resolver migrate java8: use requireNonNull (#8840) 2019-02-04 10:32:25 +01:00
resolver-dns Only try to use reflection to access default nameservers when using Java8 and lower (#9157) 2019-05-18 08:21:59 +02:00
tarball Update version number to start working on Netty 5 2018-11-20 15:49:57 +01:00
testsuite KQueueEventLoop | EpollEventLoop may incorrectly update registration when FD is reused. 2019-05-22 10:11:42 +02:00
testsuite-autobahn Deprecate ChannelInboundHandlerAdapter and ChannelOutboundHandlerAdapter (#8929) 2019-03-13 09:46:10 +01:00
testsuite-http2 Deprecate ChannelInboundHandlerAdapter and ChannelOutboundHandlerAdapter (#8929) 2019-03-13 09:46:10 +01:00
testsuite-native-image Add SVM metadata and minimal substitutions to build graalvm native image applications. (#8963) 2019-04-29 09:12:09 +02:00
testsuite-osgi Adjust testsuite-osgi to resolve bundles from local build (#8944) 2019-03-18 09:56:08 +01:00
testsuite-shading Use maven plugin to prevent API/ABI breakage as part of build process (#8904) 2019-03-01 19:48:29 +01:00
transport Only use static Exception instances when we can ensure addSuppressed … (#9152) 2019-05-17 22:42:53 +02:00
transport-native-epoll KQueueEventLoop | EpollEventLoop may incorrectly update registration when FD is reused. 2019-05-22 10:11:42 +02:00
transport-native-kqueue KQueueEventLoop | EpollEventLoop may incorrectly update registration when FD is reused. 2019-05-22 10:11:42 +02:00
transport-native-unix-common Only use static Exception instances when we can ensure addSuppressed … (#9152) 2019-05-17 22:42:53 +02:00
transport-native-unix-common-tests Merge ChannelInboundHandler and ChannelOutboundHandler into ChannelHa… (#8957) 2019-03-28 09:28:27 +00:00
transport-sctp Deprecate ChannelInboundHandlerAdapter and ChannelOutboundHandlerAdapter (#8929) 2019-03-13 09:46:10 +01:00
.fbprefs Updated Find Bugs configuration 2009-03-04 10:33:09 +00:00
.gitattributes Include mvn wrapper to make setup of development env easier 2018-01-26 08:13:17 +01:00
.gitignore Add .gitignore for docker-sync stuff 2019-03-19 14:04:21 +01:00
CONTRIBUTING.md Move the pull request guide to the developer guide 2014-03-12 13:13:58 +09:00
LICENSE.txt Relicensed to Apache License v2 2009-08-28 07:15:49 +00:00
mvnw Include mvn wrapper to make setup of development env easier 2018-01-26 08:13:17 +01:00
mvnw.cmd Include mvn wrapper to make setup of development env easier 2018-01-26 08:13:17 +01:00
NOTICE.txt Add the NOTICE of the forked portion of Apache Harmony 2018-01-30 11:22:51 +01:00
pom.xml Adjust pom.xml to be able to build with graalvm (#9107) 2019-04-29 18:40:47 +02:00
README.md Provide an Automatic-Module-Name for the netty-all artifact fixes #7644 2018-01-27 20:31:16 +01:00
run-example.sh Drop SPDY support (#8845) 2019-02-07 09:25:31 +01:00

Netty Project

Netty is an asynchronous event-driven network application framework for rapid development of maintainable high performance protocol servers & clients.

How to build

For the detailed information about building and developing Netty, please visit the developer guide. This page only gives very basic information.

You require the following to build Netty:

Note that this is build-time requirement. JDK 5 (for 3.x) or 6 (for 4.0+) is enough to run your Netty-based application.

Branches to look

Development of all versions takes place in each branch whose name is identical to <majorVersion>.<minorVersion>. For example, the development of 3.9 and 4.0 resides in the branch '3.9' and the branch '4.0' respectively.

Usage with JDK 9

Netty can be used in modular JDK9 applications as a collection of automatic modules. The module names follow the reverse-DNS style, and are derived from subproject names rather than root packages due to historical reasons. They are listed below:

  • io.netty.all
  • io.netty.buffer
  • io.netty.codec
  • io.netty.codec.dns
  • io.netty.codec.haproxy
  • io.netty.codec.http
  • io.netty.codec.http2
  • io.netty.codec.memcache
  • io.netty.codec.mqtt
  • io.netty.codec.redis
  • io.netty.codec.smtp
  • io.netty.codec.socks
  • io.netty.codec.stomp
  • io.netty.codec.xml
  • io.netty.common
  • io.netty.handler
  • io.netty.handler.proxy
  • io.netty.resolver
  • io.netty.resolver.dns
  • io.netty.transport
  • io.netty.transport.epoll (native omitted - reserved keyword in Java)
  • io.netty.transport.kqueue (native omitted - reserved keyword in Java)
  • io.netty.transport.unix.common (native omitted - reserved keyword in Java)
  • io.netty.transport.rxtx
  • io.netty.transport.sctp
  • io.netty.transport.udt

Automatic modules do not provide any means to declare dependencies, so you need to list each used module separately in your module-info file.