netty5

History

Kareem Ali 121daab927 Motivation: (#10326 ) The current FLowControlHandler keeps a flag to track whether a read() call is pending. This could lead to a scenario where you call read multiple times when the queue is empty, and when the FlowControlHandler Queue starts getting messages, channelRead will be fired only once, when we should've fired x many times, once for each time the handlers downstream called read(). Modifications: Minor change to replace the boolean flag with a counter and adding a unit test for this scenario. Result: I used TDD, so I wrote the test, made sure it's failing, then updated the code and re-ran the test to make sure it's successful after the changes. Co-authored-by: Kareem Ali <kali@localhost.localdomain>	2020-06-04 19:18:23 +02:00
..
src	Motivation: (#10326 )	2020-06-04 19:18:23 +02:00
pom.xml	Add ResolveAddressHandler which can be used to resolve addresses on the fly (#9947 )	2020-01-20 19:34:09 +01:00

Kareem Ali 121daab927 Motivation: (#10326 )

The current FLowControlHandler keeps a flag to track whether a read() call is pending.
This could lead to a scenario where you call read multiple times when the queue is empty,
and when the FlowControlHandler Queue starts getting messages, channelRead will be fired only once,
when we should've fired x many times, once for each time the handlers downstream called read().

Modifications:

Minor change to replace the boolean flag with a counter and adding a unit test for this scenario.

Result:

I used TDD, so I wrote the test, made sure it's failing, then updated the code and re-ran the test
to make sure it's successful after the changes.

Co-authored-by: Kareem Ali <kali@localhost.localdomain>

2020-06-04 19:18:23 +02:00

src

Motivation: (#10326 )

2020-06-04 19:18:23 +02:00

pom.xml

Add ResolveAddressHandler which can be used to resolve addresses on the fly (#9947 )

2020-01-20 19:34:09 +01:00