2016-03-03 20:20:25 +01:00
|
|
|
// Copyright (c) 2011-present, Facebook, Inc. All rights reserved.
|
2017-07-16 01:03:42 +02:00
|
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
|
|
// (found in the LICENSE.Apache file in the root directory).
|
2016-03-03 20:20:25 +01:00
|
|
|
#ifndef ROCKSDB_LITE
|
|
|
|
|
|
|
|
#ifndef __STDC_FORMAT_MACROS
|
|
|
|
#define __STDC_FORMAT_MACROS
|
|
|
|
#endif
|
|
|
|
|
|
|
|
#include "util/transaction_test_util.h"
|
|
|
|
|
|
|
|
#include <inttypes.h>
|
2017-12-06 18:32:09 +01:00
|
|
|
#include <algorithm>
|
|
|
|
#include <numeric>
|
2016-03-03 20:20:25 +01:00
|
|
|
#include <string>
|
2017-06-24 23:06:43 +02:00
|
|
|
#include <thread>
|
2016-03-03 20:20:25 +01:00
|
|
|
|
|
|
|
#include "rocksdb/db.h"
|
|
|
|
#include "rocksdb/utilities/optimistic_transaction_db.h"
|
|
|
|
#include "rocksdb/utilities/transaction.h"
|
|
|
|
#include "rocksdb/utilities/transaction_db.h"
|
|
|
|
#include "util/random.h"
|
|
|
|
#include "util/string_util.h"
|
|
|
|
|
|
|
|
namespace rocksdb {
|
|
|
|
|
|
|
|
RandomTransactionInserter::RandomTransactionInserter(
|
|
|
|
Random64* rand, const WriteOptions& write_options,
|
|
|
|
const ReadOptions& read_options, uint64_t num_keys, uint16_t num_sets)
|
|
|
|
: rand_(rand),
|
|
|
|
write_options_(write_options),
|
|
|
|
read_options_(read_options),
|
|
|
|
num_keys_(num_keys),
|
2017-07-08 03:18:45 +02:00
|
|
|
num_sets_(num_sets),
|
|
|
|
txn_id_(0) {}
|
2016-03-03 20:20:25 +01:00
|
|
|
|
|
|
|
RandomTransactionInserter::~RandomTransactionInserter() {
|
|
|
|
if (txn_ != nullptr) {
|
|
|
|
delete txn_;
|
|
|
|
}
|
|
|
|
if (optimistic_txn_ != nullptr) {
|
|
|
|
delete optimistic_txn_;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
bool RandomTransactionInserter::TransactionDBInsert(
|
|
|
|
TransactionDB* db, const TransactionOptions& txn_options) {
|
|
|
|
txn_ = db->BeginTransaction(write_options_, txn_options, txn_);
|
2018-07-24 09:09:18 +02:00
|
|
|
|
|
|
|
std::hash<std::thread::id> hasher;
|
|
|
|
char name[64];
|
|
|
|
snprintf(name, 64, "txn%" ROCKSDB_PRIszt "-%d",
|
|
|
|
hasher(std::this_thread::get_id()), txn_id_++);
|
|
|
|
assert(strlen(name) < 64 - 1);
|
|
|
|
txn_->SetName(name);
|
|
|
|
|
2017-12-06 18:32:09 +01:00
|
|
|
bool take_snapshot = rand_->OneIn(2);
|
|
|
|
if (take_snapshot) {
|
|
|
|
txn_->SetSnapshot();
|
|
|
|
read_options_.snapshot = txn_->GetSnapshot();
|
|
|
|
}
|
|
|
|
auto res = DoInsert(nullptr, txn_, false);
|
|
|
|
if (take_snapshot) {
|
|
|
|
read_options_.snapshot = nullptr;
|
|
|
|
}
|
|
|
|
return res;
|
2016-03-03 20:20:25 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
bool RandomTransactionInserter::OptimisticTransactionDBInsert(
|
|
|
|
OptimisticTransactionDB* db,
|
|
|
|
const OptimisticTransactionOptions& txn_options) {
|
|
|
|
optimistic_txn_ =
|
|
|
|
db->BeginTransaction(write_options_, txn_options, optimistic_txn_);
|
|
|
|
|
|
|
|
return DoInsert(nullptr, optimistic_txn_, true);
|
|
|
|
}
|
|
|
|
|
|
|
|
bool RandomTransactionInserter::DBInsert(DB* db) {
|
|
|
|
return DoInsert(db, nullptr, false);
|
|
|
|
}
|
|
|
|
|
2017-12-06 18:32:09 +01:00
|
|
|
Status RandomTransactionInserter::DBGet(
|
|
|
|
DB* db, Transaction* txn, ReadOptions& read_options, uint16_t set_i,
|
|
|
|
uint64_t ikey, bool get_for_update, uint64_t* int_value,
|
|
|
|
std::string* full_key, bool* unexpected_error) {
|
|
|
|
Status s;
|
FIXED: string buffers potentially too small to fit formatted write
Summary:
This fixes the following warnings when compiled with GCC7:
util/transaction_test_util.cc: In static member function ‘static rocksdb::Status rocksdb::RandomTransactionInserter::DBGet(rocksdb::DB*, rocksdb::Transaction*, rocksdb::ReadOptions&, uint16_t, uint64_t, bool, uint64_t*, std::__cxx11::string*, bool*)’:
util/transaction_test_util.cc:75:8: error: ‘snprintf’ output may be truncated before the last format character [-Werror=format-truncation=]
Status RandomTransactionInserter::DBGet(
^~~~~~~~~~~~~~~~~~~~~~~~~
util/transaction_test_util.cc:84:11: note: ‘snprintf’ output between 5 and 6 bytes into a destination of size 5
snprintf(prefix_buf, sizeof(prefix_buf), "%.4u", set_i + 1);
~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
util/transaction_test_util.cc: In static member function ‘static rocksdb::Status rocksdb::RandomTransactionInserter::Verify(rocksdb::DB*, uint16_t, uint64_t, bool, rocksdb::Random64*)’:
util/transaction_test_util.cc:245:8: error: ‘snprintf’ output may be truncated before the last format character [-Werror=format-truncation=]
Status RandomTransactionInserter::Verify(DB* db, uint16_t num_sets,
^~~~~~~~~~~~~~~~~~~~~~~~~
util/transaction_test_util.cc:268:13: note: ‘snprintf’ output between 5 and 6 bytes into a destination of size 5
snprintf(prefix_buf, sizeof(prefix_buf), "%.4u", set_i + 1);
~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Closes https://github.com/facebook/rocksdb/pull/3295
Differential Revision: D6609411
Pulled By: maysamyabandeh
fbshipit-source-id: 33f0add471056eb59db2f8bd4366e6dfbb1a187d
2017-12-20 17:02:53 +01:00
|
|
|
// Five digits (since the largest uint16_t is 65535) plus the NUL
|
|
|
|
// end char.
|
|
|
|
char prefix_buf[6];
|
2017-12-06 18:32:09 +01:00
|
|
|
// Pad prefix appropriately so we can iterate over each set
|
2017-12-12 21:07:35 +01:00
|
|
|
assert(set_i + 1 <= 9999);
|
2017-12-06 18:32:09 +01:00
|
|
|
snprintf(prefix_buf, sizeof(prefix_buf), "%.4u", set_i + 1);
|
|
|
|
// key format: [SET#][random#]
|
|
|
|
std::string skey = ToString(ikey);
|
|
|
|
Slice base_key(skey);
|
|
|
|
*full_key = std::string(prefix_buf) + base_key.ToString();
|
|
|
|
Slice key(*full_key);
|
|
|
|
|
|
|
|
std::string value;
|
|
|
|
if (txn != nullptr) {
|
|
|
|
if (get_for_update) {
|
|
|
|
s = txn->GetForUpdate(read_options, key, &value);
|
|
|
|
} else {
|
|
|
|
s = txn->Get(read_options, key, &value);
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
s = db->Get(read_options, key, &value);
|
|
|
|
}
|
|
|
|
|
|
|
|
if (s.ok()) {
|
|
|
|
// Found key, parse its value
|
|
|
|
*int_value = std::stoull(value);
|
|
|
|
if (*int_value == 0 || *int_value == ULONG_MAX) {
|
|
|
|
*unexpected_error = true;
|
|
|
|
fprintf(stderr, "Get returned unexpected value: %s\n", value.c_str());
|
|
|
|
s = Status::Corruption();
|
|
|
|
}
|
|
|
|
} else if (s.IsNotFound()) {
|
|
|
|
// Have not yet written to this key, so assume its value is 0
|
|
|
|
*int_value = 0;
|
|
|
|
s = Status::OK();
|
|
|
|
}
|
|
|
|
return s;
|
|
|
|
}
|
|
|
|
|
2016-03-03 20:20:25 +01:00
|
|
|
bool RandomTransactionInserter::DoInsert(DB* db, Transaction* txn,
|
|
|
|
bool is_optimistic) {
|
|
|
|
Status s;
|
|
|
|
WriteBatch batch;
|
|
|
|
|
|
|
|
// pick a random number to use to increment a key in each set
|
|
|
|
uint64_t incr = (rand_->Next() % 100) + 1;
|
|
|
|
bool unexpected_error = false;
|
|
|
|
|
2017-12-06 18:32:09 +01:00
|
|
|
std::vector<uint16_t> set_vec(num_sets_);
|
2017-12-14 20:57:11 +01:00
|
|
|
std::iota(set_vec.begin(), set_vec.end(), static_cast<uint16_t>(0));
|
2017-12-06 18:32:09 +01:00
|
|
|
std::random_shuffle(set_vec.begin(), set_vec.end(),
|
|
|
|
[&](uint64_t r) { return rand_->Uniform(r); });
|
2016-03-03 20:20:25 +01:00
|
|
|
// For each set, pick a key at random and increment it
|
2017-12-06 18:32:09 +01:00
|
|
|
for (uint16_t set_i : set_vec) {
|
2016-03-03 20:20:25 +01:00
|
|
|
uint64_t int_value = 0;
|
2017-12-06 18:32:09 +01:00
|
|
|
std::string full_key;
|
|
|
|
uint64_t rand_key = rand_->Next() % num_keys_;
|
|
|
|
const bool get_for_update = txn ? rand_->OneIn(2) : false;
|
|
|
|
s = DBGet(db, txn, read_options_, set_i, rand_key, get_for_update,
|
|
|
|
&int_value, &full_key, &unexpected_error);
|
2016-03-03 20:20:25 +01:00
|
|
|
Slice key(full_key);
|
2017-12-06 18:32:09 +01:00
|
|
|
if (!s.ok()) {
|
2016-03-03 20:20:25 +01:00
|
|
|
// Optimistic transactions should never return non-ok status here.
|
|
|
|
// Non-optimistic transactions may return write-coflict/timeout errors.
|
|
|
|
if (is_optimistic || !(s.IsBusy() || s.IsTimedOut() || s.IsTryAgain())) {
|
|
|
|
fprintf(stderr, "Get returned an unexpected error: %s\n",
|
|
|
|
s.ToString().c_str());
|
|
|
|
unexpected_error = true;
|
|
|
|
}
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (s.ok()) {
|
|
|
|
// Increment key
|
|
|
|
std::string sum = ToString(int_value + incr);
|
|
|
|
if (txn != nullptr) {
|
|
|
|
s = txn->Put(key, sum);
|
2017-12-06 18:32:09 +01:00
|
|
|
if (!get_for_update && (s.IsBusy() || s.IsTimedOut())) {
|
|
|
|
// If the initial get was not for update, then the key is not locked
|
|
|
|
// before put and put could fail due to concurrent writes.
|
|
|
|
break;
|
|
|
|
} else if (!s.ok()) {
|
2016-03-03 20:20:25 +01:00
|
|
|
// Since we did a GetForUpdate, Put should not fail.
|
|
|
|
fprintf(stderr, "Put returned an unexpected error: %s\n",
|
|
|
|
s.ToString().c_str());
|
|
|
|
unexpected_error = true;
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
batch.Put(key, sum);
|
|
|
|
}
|
2017-10-17 03:29:50 +02:00
|
|
|
bytes_inserted_ += key.size() + sum.size();
|
2016-03-03 20:20:25 +01:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if (s.ok()) {
|
|
|
|
if (txn != nullptr) {
|
2017-12-06 18:32:09 +01:00
|
|
|
if (!is_optimistic && !rand_->OneIn(10)) {
|
|
|
|
// also try commit without prpare
|
|
|
|
s = txn->Prepare();
|
|
|
|
assert(s.ok());
|
|
|
|
}
|
2018-05-03 03:09:55 +02:00
|
|
|
if (!rand_->OneIn(20)) {
|
2017-12-06 18:32:09 +01:00
|
|
|
s = txn->Commit();
|
|
|
|
} else {
|
|
|
|
// Also try 5% rollback
|
|
|
|
s = txn->Rollback();
|
|
|
|
assert(s.ok());
|
|
|
|
}
|
|
|
|
assert(is_optimistic || s.ok());
|
2016-03-03 20:20:25 +01:00
|
|
|
|
|
|
|
if (!s.ok()) {
|
|
|
|
if (is_optimistic) {
|
|
|
|
// Optimistic transactions can have write-conflict errors on commit.
|
|
|
|
// Any other error is unexpected.
|
|
|
|
if (!(s.IsBusy() || s.IsTimedOut() || s.IsTryAgain())) {
|
|
|
|
unexpected_error = true;
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
// Non-optimistic transactions should only fail due to expiration
|
|
|
|
// or write failures. For testing purproses, we do not expect any
|
|
|
|
// write failures.
|
|
|
|
if (!s.IsExpired()) {
|
|
|
|
unexpected_error = true;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if (unexpected_error) {
|
|
|
|
fprintf(stderr, "Commit returned an unexpected error: %s\n",
|
|
|
|
s.ToString().c_str());
|
|
|
|
}
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
s = db->Write(write_options_, &batch);
|
|
|
|
if (!s.ok()) {
|
|
|
|
unexpected_error = true;
|
|
|
|
fprintf(stderr, "Write returned an unexpected error: %s\n",
|
|
|
|
s.ToString().c_str());
|
|
|
|
}
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
if (txn != nullptr) {
|
2017-12-06 18:32:09 +01:00
|
|
|
assert(txn->Rollback().ok());
|
2016-03-03 20:20:25 +01:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if (s.ok()) {
|
|
|
|
success_count_++;
|
|
|
|
} else {
|
|
|
|
failure_count_++;
|
|
|
|
}
|
|
|
|
|
|
|
|
last_status_ = s;
|
|
|
|
|
|
|
|
// return success if we didn't get any unexpected errors
|
|
|
|
return !unexpected_error;
|
|
|
|
}
|
|
|
|
|
2017-12-06 18:32:09 +01:00
|
|
|
// Verify that the sum of the keys in each set are equal
|
|
|
|
Status RandomTransactionInserter::Verify(DB* db, uint16_t num_sets,
|
|
|
|
uint64_t num_keys_per_set,
|
|
|
|
bool take_snapshot, Random64* rand) {
|
2016-03-03 20:20:25 +01:00
|
|
|
uint64_t prev_total = 0;
|
2017-12-06 18:32:09 +01:00
|
|
|
uint32_t prev_i = 0;
|
|
|
|
bool prev_assigned = false;
|
|
|
|
|
|
|
|
ReadOptions roptions;
|
|
|
|
if (take_snapshot) {
|
|
|
|
roptions.snapshot = db->GetSnapshot();
|
|
|
|
}
|
2016-03-03 20:20:25 +01:00
|
|
|
|
2017-12-06 18:32:09 +01:00
|
|
|
std::vector<uint16_t> set_vec(num_sets);
|
2017-12-14 20:57:11 +01:00
|
|
|
std::iota(set_vec.begin(), set_vec.end(), static_cast<uint16_t>(0));
|
2017-12-06 18:32:09 +01:00
|
|
|
if (rand) {
|
|
|
|
std::random_shuffle(set_vec.begin(), set_vec.end(),
|
|
|
|
[&](uint64_t r) { return rand->Uniform(r); });
|
|
|
|
}
|
2016-03-03 20:20:25 +01:00
|
|
|
// For each set of keys with the same prefix, sum all the values
|
2017-12-06 18:32:09 +01:00
|
|
|
for (uint16_t set_i : set_vec) {
|
FIXED: string buffers potentially too small to fit formatted write
Summary:
This fixes the following warnings when compiled with GCC7:
util/transaction_test_util.cc: In static member function ‘static rocksdb::Status rocksdb::RandomTransactionInserter::DBGet(rocksdb::DB*, rocksdb::Transaction*, rocksdb::ReadOptions&, uint16_t, uint64_t, bool, uint64_t*, std::__cxx11::string*, bool*)’:
util/transaction_test_util.cc:75:8: error: ‘snprintf’ output may be truncated before the last format character [-Werror=format-truncation=]
Status RandomTransactionInserter::DBGet(
^~~~~~~~~~~~~~~~~~~~~~~~~
util/transaction_test_util.cc:84:11: note: ‘snprintf’ output between 5 and 6 bytes into a destination of size 5
snprintf(prefix_buf, sizeof(prefix_buf), "%.4u", set_i + 1);
~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
util/transaction_test_util.cc: In static member function ‘static rocksdb::Status rocksdb::RandomTransactionInserter::Verify(rocksdb::DB*, uint16_t, uint64_t, bool, rocksdb::Random64*)’:
util/transaction_test_util.cc:245:8: error: ‘snprintf’ output may be truncated before the last format character [-Werror=format-truncation=]
Status RandomTransactionInserter::Verify(DB* db, uint16_t num_sets,
^~~~~~~~~~~~~~~~~~~~~~~~~
util/transaction_test_util.cc:268:13: note: ‘snprintf’ output between 5 and 6 bytes into a destination of size 5
snprintf(prefix_buf, sizeof(prefix_buf), "%.4u", set_i + 1);
~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Closes https://github.com/facebook/rocksdb/pull/3295
Differential Revision: D6609411
Pulled By: maysamyabandeh
fbshipit-source-id: 33f0add471056eb59db2f8bd4366e6dfbb1a187d
2017-12-20 17:02:53 +01:00
|
|
|
// Five digits (since the largest uint16_t is 65535) plus the NUL
|
|
|
|
// end char.
|
|
|
|
char prefix_buf[6];
|
2017-12-12 21:07:35 +01:00
|
|
|
assert(set_i + 1 <= 9999);
|
2017-12-06 18:32:09 +01:00
|
|
|
snprintf(prefix_buf, sizeof(prefix_buf), "%.4u", set_i + 1);
|
2016-03-03 20:20:25 +01:00
|
|
|
uint64_t total = 0;
|
|
|
|
|
2017-12-06 18:32:09 +01:00
|
|
|
// Use either point lookup or iterator. Point lookups are slower so we use
|
|
|
|
// it less often.
|
|
|
|
if (num_keys_per_set != 0 && rand && rand->OneIn(10)) { // use point lookup
|
|
|
|
ReadOptions read_options;
|
|
|
|
for (uint64_t k = 0; k < num_keys_per_set; k++) {
|
|
|
|
std::string dont_care;
|
|
|
|
uint64_t int_value = 0;
|
|
|
|
bool unexpected_error = false;
|
|
|
|
const bool FOR_UPDATE = false;
|
|
|
|
Status s = DBGet(db, nullptr, roptions, set_i, k, FOR_UPDATE,
|
|
|
|
&int_value, &dont_care, &unexpected_error);
|
|
|
|
assert(s.ok());
|
|
|
|
assert(!unexpected_error);
|
|
|
|
total += int_value;
|
2016-03-03 20:20:25 +01:00
|
|
|
}
|
2017-12-06 18:32:09 +01:00
|
|
|
} else { // user iterators
|
|
|
|
Iterator* iter = db->NewIterator(roptions);
|
|
|
|
for (iter->Seek(Slice(prefix_buf, 4)); iter->Valid(); iter->Next()) {
|
|
|
|
Slice key = iter->key();
|
|
|
|
// stop when we reach a different prefix
|
|
|
|
if (key.ToString().compare(0, 4, prefix_buf) != 0) {
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
Slice value = iter->value();
|
|
|
|
uint64_t int_value = std::stoull(value.ToString());
|
|
|
|
if (int_value == 0 || int_value == ULONG_MAX) {
|
|
|
|
fprintf(stderr, "Iter returned unexpected value: %s\n",
|
|
|
|
value.ToString().c_str());
|
|
|
|
return Status::Corruption();
|
|
|
|
}
|
|
|
|
total += int_value;
|
2016-03-03 20:20:25 +01:00
|
|
|
}
|
2017-12-06 18:32:09 +01:00
|
|
|
delete iter;
|
2016-03-03 20:20:25 +01:00
|
|
|
}
|
2017-12-06 18:32:09 +01:00
|
|
|
|
|
|
|
if (prev_assigned && total != prev_total) {
|
|
|
|
fprintf(stdout,
|
|
|
|
"RandomTransactionVerify found inconsistent totals. "
|
|
|
|
"Set[%" PRIu32 "]: %" PRIu64 ", Set[%" PRIu32 "]: %" PRIu64 " \n",
|
|
|
|
prev_i, prev_total, set_i, total);
|
|
|
|
return Status::Corruption();
|
2016-03-03 20:20:25 +01:00
|
|
|
}
|
|
|
|
prev_total = total;
|
2017-12-06 18:32:09 +01:00
|
|
|
prev_i = set_i;
|
|
|
|
prev_assigned = true;
|
|
|
|
}
|
|
|
|
if (take_snapshot) {
|
|
|
|
db->ReleaseSnapshot(roptions.snapshot);
|
2016-03-03 20:20:25 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
return Status::OK();
|
|
|
|
}
|
|
|
|
|
|
|
|
} // namespace rocksdb
|
|
|
|
|
|
|
|
#endif // ROCKSDB_LITE
|