2016-02-10 00:12:00 +01:00
|
|
|
// Copyright (c) 2011-present, Facebook, Inc. All rights reserved.
|
2017-07-16 01:03:42 +02:00
|
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
|
|
// (found in the LICENSE.Apache file in the root directory).
|
generic rate limiter
Summary:
A generic rate limiter that can be shared by threads and rocksdb
instances. Will use this to smooth out write traffic generated by
compaction and flush. This will help us get better p99 behavior on flash
storage.
Test Plan:
unit test output
==== Test RateLimiterTest.Rate
request size [1 - 1023], limit 10 KB/sec, actual rate: 10.374969 KB/sec, elapsed 2002265
request size [1 - 2047], limit 20 KB/sec, actual rate: 20.771242 KB/sec, elapsed 2002139
request size [1 - 4095], limit 40 KB/sec, actual rate: 41.285299 KB/sec, elapsed 2202424
request size [1 - 8191], limit 80 KB/sec, actual rate: 81.371605 KB/sec, elapsed 2402558
request size [1 - 16383], limit 160 KB/sec, actual rate: 162.541268 KB/sec, elapsed 3303500
Reviewers: yhchiang, igor, sdong
Reviewed By: sdong
Subscribers: leveldb
Differential Revision: https://reviews.facebook.net/D19359
2014-07-08 20:41:57 +02:00
|
|
|
//
|
|
|
|
// Copyright (c) 2011 The LevelDB Authors. All rights reserved.
|
|
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
|
|
// found in the LICENSE file. See the AUTHORS file for names of contributors.
|
|
|
|
|
|
|
|
#include "util/rate_limiter.h"
|
2021-01-26 07:07:26 +01:00
|
|
|
|
2017-04-06 04:02:00 +02:00
|
|
|
#include "monitoring/statistics.h"
|
2016-05-28 01:14:24 +02:00
|
|
|
#include "port/port.h"
|
2021-01-26 07:07:26 +01:00
|
|
|
#include "rocksdb/system_clock.h"
|
2019-05-30 20:21:38 +02:00
|
|
|
#include "test_util/sync_point.h"
|
2019-05-31 02:39:43 +02:00
|
|
|
#include "util/aligned_buffer.h"
|
generic rate limiter
Summary:
A generic rate limiter that can be shared by threads and rocksdb
instances. Will use this to smooth out write traffic generated by
compaction and flush. This will help us get better p99 behavior on flash
storage.
Test Plan:
unit test output
==== Test RateLimiterTest.Rate
request size [1 - 1023], limit 10 KB/sec, actual rate: 10.374969 KB/sec, elapsed 2002265
request size [1 - 2047], limit 20 KB/sec, actual rate: 20.771242 KB/sec, elapsed 2002139
request size [1 - 4095], limit 40 KB/sec, actual rate: 41.285299 KB/sec, elapsed 2202424
request size [1 - 8191], limit 80 KB/sec, actual rate: 81.371605 KB/sec, elapsed 2402558
request size [1 - 16383], limit 160 KB/sec, actual rate: 162.541268 KB/sec, elapsed 3303500
Reviewers: yhchiang, igor, sdong
Reviewed By: sdong
Subscribers: leveldb
Differential Revision: https://reviews.facebook.net/D19359
2014-07-08 20:41:57 +02:00
|
|
|
|
2020-02-20 21:07:53 +01:00
|
|
|
namespace ROCKSDB_NAMESPACE {
|
generic rate limiter
Summary:
A generic rate limiter that can be shared by threads and rocksdb
instances. Will use this to smooth out write traffic generated by
compaction and flush. This will help us get better p99 behavior on flash
storage.
Test Plan:
unit test output
==== Test RateLimiterTest.Rate
request size [1 - 1023], limit 10 KB/sec, actual rate: 10.374969 KB/sec, elapsed 2002265
request size [1 - 2047], limit 20 KB/sec, actual rate: 20.771242 KB/sec, elapsed 2002139
request size [1 - 4095], limit 40 KB/sec, actual rate: 41.285299 KB/sec, elapsed 2202424
request size [1 - 8191], limit 80 KB/sec, actual rate: 81.371605 KB/sec, elapsed 2402558
request size [1 - 16383], limit 160 KB/sec, actual rate: 162.541268 KB/sec, elapsed 3303500
Reviewers: yhchiang, igor, sdong
Reviewed By: sdong
Subscribers: leveldb
Differential Revision: https://reviews.facebook.net/D19359
2014-07-08 20:41:57 +02:00
|
|
|
|
2017-06-13 23:51:22 +02:00
|
|
|
size_t RateLimiter::RequestToken(size_t bytes, size_t alignment,
|
|
|
|
Env::IOPriority io_priority, Statistics* stats,
|
|
|
|
RateLimiter::OpType op_type) {
|
|
|
|
if (io_priority < Env::IO_TOTAL && IsRateLimited(op_type)) {
|
|
|
|
bytes = std::min(bytes, static_cast<size_t>(GetSingleBurstBytes()));
|
|
|
|
|
|
|
|
if (alignment > 0) {
|
|
|
|
// Here we may actually require more than burst and block
|
|
|
|
// but we can not write less than one page at a time on direct I/O
|
|
|
|
// thus we may want not to use ratelimiter
|
|
|
|
bytes = std::max(alignment, TruncateToPageBoundary(alignment, bytes));
|
|
|
|
}
|
|
|
|
Request(bytes, io_priority, stats, op_type);
|
|
|
|
}
|
|
|
|
return bytes;
|
|
|
|
}
|
generic rate limiter
Summary:
A generic rate limiter that can be shared by threads and rocksdb
instances. Will use this to smooth out write traffic generated by
compaction and flush. This will help us get better p99 behavior on flash
storage.
Test Plan:
unit test output
==== Test RateLimiterTest.Rate
request size [1 - 1023], limit 10 KB/sec, actual rate: 10.374969 KB/sec, elapsed 2002265
request size [1 - 2047], limit 20 KB/sec, actual rate: 20.771242 KB/sec, elapsed 2002139
request size [1 - 4095], limit 40 KB/sec, actual rate: 41.285299 KB/sec, elapsed 2202424
request size [1 - 8191], limit 80 KB/sec, actual rate: 81.371605 KB/sec, elapsed 2402558
request size [1 - 16383], limit 160 KB/sec, actual rate: 162.541268 KB/sec, elapsed 3303500
Reviewers: yhchiang, igor, sdong
Reviewed By: sdong
Subscribers: leveldb
Differential Revision: https://reviews.facebook.net/D19359
2014-07-08 20:41:57 +02:00
|
|
|
|
|
|
|
// Pending request
|
2014-07-26 00:17:06 +02:00
|
|
|
struct GenericRateLimiter::Req {
|
2014-10-31 19:59:54 +01:00
|
|
|
explicit Req(int64_t _bytes, port::Mutex* _mu)
|
fix rate limiter to avoid starvation
Summary:
The current implementation of rate limiter has the possibility to introduce resource starvation when change its limit.
This diff aims to fix this problem by consuming request bytes partially.
Test Plan:
```
./rate_limiter_test
[==========] Running 4 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 4 tests from RateLimiterTest
[ RUN ] RateLimiterTest.OverflowRate
[ OK ] RateLimiterTest.OverflowRate (0 ms)
[ RUN ] RateLimiterTest.StartStop
[ OK ] RateLimiterTest.StartStop (0 ms)
[ RUN ] RateLimiterTest.Rate
request size [1 - 1023], limit 10 KB/sec, actual rate: 10.355712 KB/sec, elapsed 2.00 seconds
request size [1 - 1023], limit 20 KB/sec, actual rate: 19.136564 KB/sec, elapsed 2.00 seconds
request size [1 - 2047], limit 20 KB/sec, actual rate: 20.783976 KB/sec, elapsed 2.10 seconds
request size [1 - 2047], limit 40 KB/sec, actual rate: 39.308144 KB/sec, elapsed 2.10 seconds
request size [1 - 4095], limit 40 KB/sec, actual rate: 40.318349 KB/sec, elapsed 2.20 seconds
request size [1 - 4095], limit 80 KB/sec, actual rate: 79.667396 KB/sec, elapsed 2.20 seconds
request size [1 - 8191], limit 80 KB/sec, actual rate: 81.807158 KB/sec, elapsed 2.30 seconds
request size [1 - 8191], limit 160 KB/sec, actual rate: 160.659761 KB/sec, elapsed 2.20 seconds
request size [1 - 16383], limit 160 KB/sec, actual rate: 160.700990 KB/sec, elapsed 3.00 seconds
request size [1 - 16383], limit 320 KB/sec, actual rate: 317.639481 KB/sec, elapsed 2.50 seconds
[ OK ] RateLimiterTest.Rate (22618 ms)
[ RUN ] RateLimiterTest.LimitChangeTest
[COMPLETE] request size 10 KB, new limit 20KB/sec, refill period 1000 ms
[COMPLETE] request size 10 KB, new limit 5KB/sec, refill period 1000 ms
[COMPLETE] request size 20 KB, new limit 40KB/sec, refill period 1000 ms
[COMPLETE] request size 20 KB, new limit 10KB/sec, refill period 1000 ms
[COMPLETE] request size 40 KB, new limit 80KB/sec, refill period 1000 ms
[COMPLETE] request size 40 KB, new limit 20KB/sec, refill period 1000 ms
[COMPLETE] request size 80 KB, new limit 160KB/sec, refill period 1000 ms
[COMPLETE] request size 80 KB, new limit 40KB/sec, refill period 1000 ms
[COMPLETE] request size 160 KB, new limit 320KB/sec, refill period 1000 ms
[COMPLETE] request size 160 KB, new limit 80KB/sec, refill period 1000 ms
[ OK ] RateLimiterTest.LimitChangeTest (5002 ms)
[----------] 4 tests from RateLimiterTest (27620 ms total)
[----------] Global test environment tear-down
[==========] 4 tests from 1 test case ran. (27621 ms total)
[ PASSED ] 4 tests.
```
Reviewers: sdong, IslamAbdelRahman, yiwu, andrewkr
Reviewed By: andrewkr
Subscribers: andrewkr, dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D60207
2016-07-01 09:16:29 +02:00
|
|
|
: request_bytes(_bytes), bytes(_bytes), cv(_mu), granted(false) {}
|
|
|
|
int64_t request_bytes;
|
generic rate limiter
Summary:
A generic rate limiter that can be shared by threads and rocksdb
instances. Will use this to smooth out write traffic generated by
compaction and flush. This will help us get better p99 behavior on flash
storage.
Test Plan:
unit test output
==== Test RateLimiterTest.Rate
request size [1 - 1023], limit 10 KB/sec, actual rate: 10.374969 KB/sec, elapsed 2002265
request size [1 - 2047], limit 20 KB/sec, actual rate: 20.771242 KB/sec, elapsed 2002139
request size [1 - 4095], limit 40 KB/sec, actual rate: 41.285299 KB/sec, elapsed 2202424
request size [1 - 8191], limit 80 KB/sec, actual rate: 81.371605 KB/sec, elapsed 2402558
request size [1 - 16383], limit 160 KB/sec, actual rate: 162.541268 KB/sec, elapsed 3303500
Reviewers: yhchiang, igor, sdong
Reviewed By: sdong
Subscribers: leveldb
Differential Revision: https://reviews.facebook.net/D19359
2014-07-08 20:41:57 +02:00
|
|
|
int64_t bytes;
|
|
|
|
port::CondVar cv;
|
|
|
|
bool granted;
|
|
|
|
};
|
|
|
|
|
2021-01-26 07:07:26 +01:00
|
|
|
GenericRateLimiter::GenericRateLimiter(
|
|
|
|
int64_t rate_bytes_per_sec, int64_t refill_period_us, int32_t fairness,
|
|
|
|
RateLimiter::Mode mode, const std::shared_ptr<SystemClock>& clock,
|
|
|
|
bool auto_tuned)
|
2017-06-13 23:51:22 +02:00
|
|
|
: RateLimiter(mode),
|
|
|
|
refill_period_us_(refill_period_us),
|
2017-10-05 04:02:22 +02:00
|
|
|
rate_bytes_per_sec_(auto_tuned ? rate_bytes_per_sec / 2
|
|
|
|
: rate_bytes_per_sec),
|
2015-03-18 23:35:55 +01:00
|
|
|
refill_bytes_per_period_(
|
2017-10-05 04:02:22 +02:00
|
|
|
CalculateRefillBytesPerPeriod(rate_bytes_per_sec_)),
|
2021-01-26 07:07:26 +01:00
|
|
|
clock_(clock),
|
2015-03-18 23:35:55 +01:00
|
|
|
stop_(false),
|
|
|
|
exit_cv_(&request_mutex_),
|
|
|
|
requests_to_wait_(0),
|
|
|
|
available_bytes_(0),
|
2021-03-15 12:32:24 +01:00
|
|
|
next_refill_us_(NowMicrosMonotonic()),
|
2015-03-18 23:35:55 +01:00
|
|
|
fairness_(fairness > 100 ? 100 : fairness),
|
|
|
|
rnd_((uint32_t)time(nullptr)),
|
2017-10-05 04:02:22 +02:00
|
|
|
leader_(nullptr),
|
|
|
|
auto_tuned_(auto_tuned),
|
|
|
|
num_drains_(0),
|
|
|
|
prev_num_drains_(0),
|
|
|
|
max_bytes_per_sec_(rate_bytes_per_sec),
|
2021-03-15 12:32:24 +01:00
|
|
|
tuned_time_(NowMicrosMonotonic()) {
|
2015-07-02 01:13:49 +02:00
|
|
|
total_requests_[0] = 0;
|
|
|
|
total_requests_[1] = 0;
|
generic rate limiter
Summary:
A generic rate limiter that can be shared by threads and rocksdb
instances. Will use this to smooth out write traffic generated by
compaction and flush. This will help us get better p99 behavior on flash
storage.
Test Plan:
unit test output
==== Test RateLimiterTest.Rate
request size [1 - 1023], limit 10 KB/sec, actual rate: 10.374969 KB/sec, elapsed 2002265
request size [1 - 2047], limit 20 KB/sec, actual rate: 20.771242 KB/sec, elapsed 2002139
request size [1 - 4095], limit 40 KB/sec, actual rate: 41.285299 KB/sec, elapsed 2202424
request size [1 - 8191], limit 80 KB/sec, actual rate: 81.371605 KB/sec, elapsed 2402558
request size [1 - 16383], limit 160 KB/sec, actual rate: 162.541268 KB/sec, elapsed 3303500
Reviewers: yhchiang, igor, sdong
Reviewed By: sdong
Subscribers: leveldb
Differential Revision: https://reviews.facebook.net/D19359
2014-07-08 20:41:57 +02:00
|
|
|
total_bytes_through_[0] = 0;
|
|
|
|
total_bytes_through_[1] = 0;
|
|
|
|
}
|
|
|
|
|
2014-07-26 00:17:06 +02:00
|
|
|
GenericRateLimiter::~GenericRateLimiter() {
|
generic rate limiter
Summary:
A generic rate limiter that can be shared by threads and rocksdb
instances. Will use this to smooth out write traffic generated by
compaction and flush. This will help us get better p99 behavior on flash
storage.
Test Plan:
unit test output
==== Test RateLimiterTest.Rate
request size [1 - 1023], limit 10 KB/sec, actual rate: 10.374969 KB/sec, elapsed 2002265
request size [1 - 2047], limit 20 KB/sec, actual rate: 20.771242 KB/sec, elapsed 2002139
request size [1 - 4095], limit 40 KB/sec, actual rate: 41.285299 KB/sec, elapsed 2202424
request size [1 - 8191], limit 80 KB/sec, actual rate: 81.371605 KB/sec, elapsed 2402558
request size [1 - 16383], limit 160 KB/sec, actual rate: 162.541268 KB/sec, elapsed 3303500
Reviewers: yhchiang, igor, sdong
Reviewed By: sdong
Subscribers: leveldb
Differential Revision: https://reviews.facebook.net/D19359
2014-07-08 20:41:57 +02:00
|
|
|
MutexLock g(&request_mutex_);
|
|
|
|
stop_ = true;
|
2014-11-11 22:47:22 +01:00
|
|
|
requests_to_wait_ = static_cast<int32_t>(queue_[Env::IO_LOW].size() +
|
|
|
|
queue_[Env::IO_HIGH].size());
|
generic rate limiter
Summary:
A generic rate limiter that can be shared by threads and rocksdb
instances. Will use this to smooth out write traffic generated by
compaction and flush. This will help us get better p99 behavior on flash
storage.
Test Plan:
unit test output
==== Test RateLimiterTest.Rate
request size [1 - 1023], limit 10 KB/sec, actual rate: 10.374969 KB/sec, elapsed 2002265
request size [1 - 2047], limit 20 KB/sec, actual rate: 20.771242 KB/sec, elapsed 2002139
request size [1 - 4095], limit 40 KB/sec, actual rate: 41.285299 KB/sec, elapsed 2202424
request size [1 - 8191], limit 80 KB/sec, actual rate: 81.371605 KB/sec, elapsed 2402558
request size [1 - 16383], limit 160 KB/sec, actual rate: 162.541268 KB/sec, elapsed 3303500
Reviewers: yhchiang, igor, sdong
Reviewed By: sdong
Subscribers: leveldb
Differential Revision: https://reviews.facebook.net/D19359
2014-07-08 20:41:57 +02:00
|
|
|
for (auto& r : queue_[Env::IO_HIGH]) {
|
|
|
|
r->cv.Signal();
|
|
|
|
}
|
|
|
|
for (auto& r : queue_[Env::IO_LOW]) {
|
|
|
|
r->cv.Signal();
|
|
|
|
}
|
|
|
|
while (requests_to_wait_ > 0) {
|
|
|
|
exit_cv_.Wait();
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2015-03-18 23:35:55 +01:00
|
|
|
// This API allows user to dynamically change rate limiter's bytes per second.
|
|
|
|
void GenericRateLimiter::SetBytesPerSecond(int64_t bytes_per_second) {
|
|
|
|
assert(bytes_per_second > 0);
|
2017-05-24 18:52:08 +02:00
|
|
|
rate_bytes_per_sec_ = bytes_per_second;
|
2015-03-18 23:35:55 +01:00
|
|
|
refill_bytes_per_period_.store(
|
|
|
|
CalculateRefillBytesPerPeriod(bytes_per_second),
|
|
|
|
std::memory_order_relaxed);
|
|
|
|
}
|
|
|
|
|
2017-03-03 02:40:24 +01:00
|
|
|
void GenericRateLimiter::Request(int64_t bytes, const Env::IOPriority pri,
|
|
|
|
Statistics* stats) {
|
2015-03-18 23:35:55 +01:00
|
|
|
assert(bytes <= refill_bytes_per_period_.load(std::memory_order_relaxed));
|
fix rate limiter to avoid starvation
Summary:
The current implementation of rate limiter has the possibility to introduce resource starvation when change its limit.
This diff aims to fix this problem by consuming request bytes partially.
Test Plan:
```
./rate_limiter_test
[==========] Running 4 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 4 tests from RateLimiterTest
[ RUN ] RateLimiterTest.OverflowRate
[ OK ] RateLimiterTest.OverflowRate (0 ms)
[ RUN ] RateLimiterTest.StartStop
[ OK ] RateLimiterTest.StartStop (0 ms)
[ RUN ] RateLimiterTest.Rate
request size [1 - 1023], limit 10 KB/sec, actual rate: 10.355712 KB/sec, elapsed 2.00 seconds
request size [1 - 1023], limit 20 KB/sec, actual rate: 19.136564 KB/sec, elapsed 2.00 seconds
request size [1 - 2047], limit 20 KB/sec, actual rate: 20.783976 KB/sec, elapsed 2.10 seconds
request size [1 - 2047], limit 40 KB/sec, actual rate: 39.308144 KB/sec, elapsed 2.10 seconds
request size [1 - 4095], limit 40 KB/sec, actual rate: 40.318349 KB/sec, elapsed 2.20 seconds
request size [1 - 4095], limit 80 KB/sec, actual rate: 79.667396 KB/sec, elapsed 2.20 seconds
request size [1 - 8191], limit 80 KB/sec, actual rate: 81.807158 KB/sec, elapsed 2.30 seconds
request size [1 - 8191], limit 160 KB/sec, actual rate: 160.659761 KB/sec, elapsed 2.20 seconds
request size [1 - 16383], limit 160 KB/sec, actual rate: 160.700990 KB/sec, elapsed 3.00 seconds
request size [1 - 16383], limit 320 KB/sec, actual rate: 317.639481 KB/sec, elapsed 2.50 seconds
[ OK ] RateLimiterTest.Rate (22618 ms)
[ RUN ] RateLimiterTest.LimitChangeTest
[COMPLETE] request size 10 KB, new limit 20KB/sec, refill period 1000 ms
[COMPLETE] request size 10 KB, new limit 5KB/sec, refill period 1000 ms
[COMPLETE] request size 20 KB, new limit 40KB/sec, refill period 1000 ms
[COMPLETE] request size 20 KB, new limit 10KB/sec, refill period 1000 ms
[COMPLETE] request size 40 KB, new limit 80KB/sec, refill period 1000 ms
[COMPLETE] request size 40 KB, new limit 20KB/sec, refill period 1000 ms
[COMPLETE] request size 80 KB, new limit 160KB/sec, refill period 1000 ms
[COMPLETE] request size 80 KB, new limit 40KB/sec, refill period 1000 ms
[COMPLETE] request size 160 KB, new limit 320KB/sec, refill period 1000 ms
[COMPLETE] request size 160 KB, new limit 80KB/sec, refill period 1000 ms
[ OK ] RateLimiterTest.LimitChangeTest (5002 ms)
[----------] 4 tests from RateLimiterTest (27620 ms total)
[----------] Global test environment tear-down
[==========] 4 tests from 1 test case ran. (27621 ms total)
[ PASSED ] 4 tests.
```
Reviewers: sdong, IslamAbdelRahman, yiwu, andrewkr
Reviewed By: andrewkr
Subscribers: andrewkr, dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D60207
2016-07-01 09:16:29 +02:00
|
|
|
TEST_SYNC_POINT("GenericRateLimiter::Request");
|
2017-06-05 23:42:34 +02:00
|
|
|
TEST_SYNC_POINT_CALLBACK("GenericRateLimiter::Request:1",
|
|
|
|
&rate_bytes_per_sec_);
|
generic rate limiter
Summary:
A generic rate limiter that can be shared by threads and rocksdb
instances. Will use this to smooth out write traffic generated by
compaction and flush. This will help us get better p99 behavior on flash
storage.
Test Plan:
unit test output
==== Test RateLimiterTest.Rate
request size [1 - 1023], limit 10 KB/sec, actual rate: 10.374969 KB/sec, elapsed 2002265
request size [1 - 2047], limit 20 KB/sec, actual rate: 20.771242 KB/sec, elapsed 2002139
request size [1 - 4095], limit 40 KB/sec, actual rate: 41.285299 KB/sec, elapsed 2202424
request size [1 - 8191], limit 80 KB/sec, actual rate: 81.371605 KB/sec, elapsed 2402558
request size [1 - 16383], limit 160 KB/sec, actual rate: 162.541268 KB/sec, elapsed 3303500
Reviewers: yhchiang, igor, sdong
Reviewed By: sdong
Subscribers: leveldb
Differential Revision: https://reviews.facebook.net/D19359
2014-07-08 20:41:57 +02:00
|
|
|
MutexLock g(&request_mutex_);
|
2017-10-05 04:02:22 +02:00
|
|
|
|
|
|
|
if (auto_tuned_) {
|
|
|
|
static const int kRefillsPerTune = 100;
|
2021-03-15 12:32:24 +01:00
|
|
|
std::chrono::microseconds now(NowMicrosMonotonic());
|
2017-10-05 04:02:22 +02:00
|
|
|
if (now - tuned_time_ >=
|
|
|
|
kRefillsPerTune * std::chrono::microseconds(refill_period_us_)) {
|
2020-12-23 08:44:44 +01:00
|
|
|
Status s = Tune();
|
|
|
|
s.PermitUncheckedError(); //**TODO: What to do on error?
|
2017-10-05 04:02:22 +02:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
generic rate limiter
Summary:
A generic rate limiter that can be shared by threads and rocksdb
instances. Will use this to smooth out write traffic generated by
compaction and flush. This will help us get better p99 behavior on flash
storage.
Test Plan:
unit test output
==== Test RateLimiterTest.Rate
request size [1 - 1023], limit 10 KB/sec, actual rate: 10.374969 KB/sec, elapsed 2002265
request size [1 - 2047], limit 20 KB/sec, actual rate: 20.771242 KB/sec, elapsed 2002139
request size [1 - 4095], limit 40 KB/sec, actual rate: 41.285299 KB/sec, elapsed 2202424
request size [1 - 8191], limit 80 KB/sec, actual rate: 81.371605 KB/sec, elapsed 2402558
request size [1 - 16383], limit 160 KB/sec, actual rate: 162.541268 KB/sec, elapsed 3303500
Reviewers: yhchiang, igor, sdong
Reviewed By: sdong
Subscribers: leveldb
Differential Revision: https://reviews.facebook.net/D19359
2014-07-08 20:41:57 +02:00
|
|
|
if (stop_) {
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
++total_requests_[pri];
|
|
|
|
|
|
|
|
if (available_bytes_ >= bytes) {
|
|
|
|
// Refill thread assigns quota and notifies requests waiting on
|
|
|
|
// the queue under mutex. So if we get here, that means nobody
|
|
|
|
// is waiting?
|
|
|
|
available_bytes_ -= bytes;
|
|
|
|
total_bytes_through_[pri] += bytes;
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
// Request cannot be satisfied at this moment, enqueue
|
|
|
|
Req r(bytes, &request_mutex_);
|
|
|
|
queue_[pri].push_back(&r);
|
|
|
|
|
|
|
|
do {
|
|
|
|
bool timedout = false;
|
|
|
|
// Leader election, candidates can be:
|
|
|
|
// (1) a new incoming request,
|
|
|
|
// (2) a previous leader, whose quota has not been not assigned yet due
|
|
|
|
// to lower priority
|
|
|
|
// (3) a previous waiter at the front of queue, who got notified by
|
|
|
|
// previous leader
|
|
|
|
if (leader_ == nullptr &&
|
|
|
|
((!queue_[Env::IO_HIGH].empty() &&
|
|
|
|
&r == queue_[Env::IO_HIGH].front()) ||
|
|
|
|
(!queue_[Env::IO_LOW].empty() &&
|
|
|
|
&r == queue_[Env::IO_LOW].front()))) {
|
|
|
|
leader_ = &r;
|
2021-03-15 12:32:24 +01:00
|
|
|
int64_t delta = next_refill_us_ - NowMicrosMonotonic();
|
2017-02-15 03:15:05 +01:00
|
|
|
delta = delta > 0 ? delta : 0;
|
|
|
|
if (delta == 0) {
|
|
|
|
timedout = true;
|
|
|
|
} else {
|
2021-01-26 07:07:26 +01:00
|
|
|
int64_t wait_until = clock_->NowMicros() + delta;
|
2017-03-03 02:40:24 +01:00
|
|
|
RecordTick(stats, NUMBER_RATE_LIMITER_DRAINS);
|
2017-10-05 04:02:22 +02:00
|
|
|
++num_drains_;
|
2017-02-15 03:15:05 +01:00
|
|
|
timedout = r.cv.TimedWait(wait_until);
|
|
|
|
}
|
generic rate limiter
Summary:
A generic rate limiter that can be shared by threads and rocksdb
instances. Will use this to smooth out write traffic generated by
compaction and flush. This will help us get better p99 behavior on flash
storage.
Test Plan:
unit test output
==== Test RateLimiterTest.Rate
request size [1 - 1023], limit 10 KB/sec, actual rate: 10.374969 KB/sec, elapsed 2002265
request size [1 - 2047], limit 20 KB/sec, actual rate: 20.771242 KB/sec, elapsed 2002139
request size [1 - 4095], limit 40 KB/sec, actual rate: 41.285299 KB/sec, elapsed 2202424
request size [1 - 8191], limit 80 KB/sec, actual rate: 81.371605 KB/sec, elapsed 2402558
request size [1 - 16383], limit 160 KB/sec, actual rate: 162.541268 KB/sec, elapsed 3303500
Reviewers: yhchiang, igor, sdong
Reviewed By: sdong
Subscribers: leveldb
Differential Revision: https://reviews.facebook.net/D19359
2014-07-08 20:41:57 +02:00
|
|
|
} else {
|
|
|
|
// Not at the front of queue or an leader has already been elected
|
|
|
|
r.cv.Wait();
|
|
|
|
}
|
|
|
|
|
|
|
|
// request_mutex_ is held from now on
|
|
|
|
if (stop_) {
|
|
|
|
--requests_to_wait_;
|
|
|
|
exit_cv_.Signal();
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
// Make sure the waken up request is always the header of its queue
|
|
|
|
assert(r.granted ||
|
|
|
|
(!queue_[Env::IO_HIGH].empty() &&
|
|
|
|
&r == queue_[Env::IO_HIGH].front()) ||
|
|
|
|
(!queue_[Env::IO_LOW].empty() &&
|
|
|
|
&r == queue_[Env::IO_LOW].front()));
|
|
|
|
assert(leader_ == nullptr ||
|
|
|
|
(!queue_[Env::IO_HIGH].empty() &&
|
|
|
|
leader_ == queue_[Env::IO_HIGH].front()) ||
|
|
|
|
(!queue_[Env::IO_LOW].empty() &&
|
|
|
|
leader_ == queue_[Env::IO_LOW].front()));
|
|
|
|
|
|
|
|
if (leader_ == &r) {
|
|
|
|
// Waken up from TimedWait()
|
|
|
|
if (timedout) {
|
|
|
|
// Time to do refill!
|
|
|
|
Refill();
|
|
|
|
|
|
|
|
// Re-elect a new leader regardless. This is to simplify the
|
|
|
|
// election handling.
|
|
|
|
leader_ = nullptr;
|
|
|
|
|
|
|
|
// Notify the header of queue if current leader is going away
|
|
|
|
if (r.granted) {
|
|
|
|
// Current leader already got granted with quota. Notify header
|
|
|
|
// of waiting queue to participate next round of election.
|
|
|
|
assert((queue_[Env::IO_HIGH].empty() ||
|
|
|
|
&r != queue_[Env::IO_HIGH].front()) &&
|
|
|
|
(queue_[Env::IO_LOW].empty() ||
|
|
|
|
&r != queue_[Env::IO_LOW].front()));
|
|
|
|
if (!queue_[Env::IO_HIGH].empty()) {
|
|
|
|
queue_[Env::IO_HIGH].front()->cv.Signal();
|
|
|
|
} else if (!queue_[Env::IO_LOW].empty()) {
|
|
|
|
queue_[Env::IO_LOW].front()->cv.Signal();
|
|
|
|
}
|
|
|
|
// Done
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
// Spontaneous wake up, need to continue to wait
|
|
|
|
assert(!r.granted);
|
|
|
|
leader_ = nullptr;
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
// Waken up by previous leader:
|
|
|
|
// (1) if requested quota is granted, it is done.
|
|
|
|
// (2) if requested quota is not granted, this means current thread
|
|
|
|
// was picked as a new leader candidate (previous leader got quota).
|
|
|
|
// It needs to participate leader election because a new request may
|
|
|
|
// come in before this thread gets waken up. So it may actually need
|
|
|
|
// to do Wait() again.
|
|
|
|
assert(!timedout);
|
|
|
|
}
|
|
|
|
} while (!r.granted);
|
|
|
|
}
|
|
|
|
|
2014-07-26 00:17:06 +02:00
|
|
|
void GenericRateLimiter::Refill() {
|
fix rate limiter to avoid starvation
Summary:
The current implementation of rate limiter has the possibility to introduce resource starvation when change its limit.
This diff aims to fix this problem by consuming request bytes partially.
Test Plan:
```
./rate_limiter_test
[==========] Running 4 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 4 tests from RateLimiterTest
[ RUN ] RateLimiterTest.OverflowRate
[ OK ] RateLimiterTest.OverflowRate (0 ms)
[ RUN ] RateLimiterTest.StartStop
[ OK ] RateLimiterTest.StartStop (0 ms)
[ RUN ] RateLimiterTest.Rate
request size [1 - 1023], limit 10 KB/sec, actual rate: 10.355712 KB/sec, elapsed 2.00 seconds
request size [1 - 1023], limit 20 KB/sec, actual rate: 19.136564 KB/sec, elapsed 2.00 seconds
request size [1 - 2047], limit 20 KB/sec, actual rate: 20.783976 KB/sec, elapsed 2.10 seconds
request size [1 - 2047], limit 40 KB/sec, actual rate: 39.308144 KB/sec, elapsed 2.10 seconds
request size [1 - 4095], limit 40 KB/sec, actual rate: 40.318349 KB/sec, elapsed 2.20 seconds
request size [1 - 4095], limit 80 KB/sec, actual rate: 79.667396 KB/sec, elapsed 2.20 seconds
request size [1 - 8191], limit 80 KB/sec, actual rate: 81.807158 KB/sec, elapsed 2.30 seconds
request size [1 - 8191], limit 160 KB/sec, actual rate: 160.659761 KB/sec, elapsed 2.20 seconds
request size [1 - 16383], limit 160 KB/sec, actual rate: 160.700990 KB/sec, elapsed 3.00 seconds
request size [1 - 16383], limit 320 KB/sec, actual rate: 317.639481 KB/sec, elapsed 2.50 seconds
[ OK ] RateLimiterTest.Rate (22618 ms)
[ RUN ] RateLimiterTest.LimitChangeTest
[COMPLETE] request size 10 KB, new limit 20KB/sec, refill period 1000 ms
[COMPLETE] request size 10 KB, new limit 5KB/sec, refill period 1000 ms
[COMPLETE] request size 20 KB, new limit 40KB/sec, refill period 1000 ms
[COMPLETE] request size 20 KB, new limit 10KB/sec, refill period 1000 ms
[COMPLETE] request size 40 KB, new limit 80KB/sec, refill period 1000 ms
[COMPLETE] request size 40 KB, new limit 20KB/sec, refill period 1000 ms
[COMPLETE] request size 80 KB, new limit 160KB/sec, refill period 1000 ms
[COMPLETE] request size 80 KB, new limit 40KB/sec, refill period 1000 ms
[COMPLETE] request size 160 KB, new limit 320KB/sec, refill period 1000 ms
[COMPLETE] request size 160 KB, new limit 80KB/sec, refill period 1000 ms
[ OK ] RateLimiterTest.LimitChangeTest (5002 ms)
[----------] 4 tests from RateLimiterTest (27620 ms total)
[----------] Global test environment tear-down
[==========] 4 tests from 1 test case ran. (27621 ms total)
[ PASSED ] 4 tests.
```
Reviewers: sdong, IslamAbdelRahman, yiwu, andrewkr
Reviewed By: andrewkr
Subscribers: andrewkr, dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D60207
2016-07-01 09:16:29 +02:00
|
|
|
TEST_SYNC_POINT("GenericRateLimiter::Refill");
|
2021-03-15 12:32:24 +01:00
|
|
|
next_refill_us_ = NowMicrosMonotonic() + refill_period_us_;
|
generic rate limiter
Summary:
A generic rate limiter that can be shared by threads and rocksdb
instances. Will use this to smooth out write traffic generated by
compaction and flush. This will help us get better p99 behavior on flash
storage.
Test Plan:
unit test output
==== Test RateLimiterTest.Rate
request size [1 - 1023], limit 10 KB/sec, actual rate: 10.374969 KB/sec, elapsed 2002265
request size [1 - 2047], limit 20 KB/sec, actual rate: 20.771242 KB/sec, elapsed 2002139
request size [1 - 4095], limit 40 KB/sec, actual rate: 41.285299 KB/sec, elapsed 2202424
request size [1 - 8191], limit 80 KB/sec, actual rate: 81.371605 KB/sec, elapsed 2402558
request size [1 - 16383], limit 160 KB/sec, actual rate: 162.541268 KB/sec, elapsed 3303500
Reviewers: yhchiang, igor, sdong
Reviewed By: sdong
Subscribers: leveldb
Differential Revision: https://reviews.facebook.net/D19359
2014-07-08 20:41:57 +02:00
|
|
|
// Carry over the left over quota from the last period
|
2015-03-18 23:35:55 +01:00
|
|
|
auto refill_bytes_per_period =
|
|
|
|
refill_bytes_per_period_.load(std::memory_order_relaxed);
|
|
|
|
if (available_bytes_ < refill_bytes_per_period) {
|
|
|
|
available_bytes_ += refill_bytes_per_period;
|
generic rate limiter
Summary:
A generic rate limiter that can be shared by threads and rocksdb
instances. Will use this to smooth out write traffic generated by
compaction and flush. This will help us get better p99 behavior on flash
storage.
Test Plan:
unit test output
==== Test RateLimiterTest.Rate
request size [1 - 1023], limit 10 KB/sec, actual rate: 10.374969 KB/sec, elapsed 2002265
request size [1 - 2047], limit 20 KB/sec, actual rate: 20.771242 KB/sec, elapsed 2002139
request size [1 - 4095], limit 40 KB/sec, actual rate: 41.285299 KB/sec, elapsed 2202424
request size [1 - 8191], limit 80 KB/sec, actual rate: 81.371605 KB/sec, elapsed 2402558
request size [1 - 16383], limit 160 KB/sec, actual rate: 162.541268 KB/sec, elapsed 3303500
Reviewers: yhchiang, igor, sdong
Reviewed By: sdong
Subscribers: leveldb
Differential Revision: https://reviews.facebook.net/D19359
2014-07-08 20:41:57 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
int use_low_pri_first = rnd_.OneIn(fairness_) ? 0 : 1;
|
|
|
|
for (int q = 0; q < 2; ++q) {
|
|
|
|
auto use_pri = (use_low_pri_first == q) ? Env::IO_LOW : Env::IO_HIGH;
|
|
|
|
auto* queue = &queue_[use_pri];
|
|
|
|
while (!queue->empty()) {
|
|
|
|
auto* next_req = queue->front();
|
fix rate limiter to avoid starvation
Summary:
The current implementation of rate limiter has the possibility to introduce resource starvation when change its limit.
This diff aims to fix this problem by consuming request bytes partially.
Test Plan:
```
./rate_limiter_test
[==========] Running 4 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 4 tests from RateLimiterTest
[ RUN ] RateLimiterTest.OverflowRate
[ OK ] RateLimiterTest.OverflowRate (0 ms)
[ RUN ] RateLimiterTest.StartStop
[ OK ] RateLimiterTest.StartStop (0 ms)
[ RUN ] RateLimiterTest.Rate
request size [1 - 1023], limit 10 KB/sec, actual rate: 10.355712 KB/sec, elapsed 2.00 seconds
request size [1 - 1023], limit 20 KB/sec, actual rate: 19.136564 KB/sec, elapsed 2.00 seconds
request size [1 - 2047], limit 20 KB/sec, actual rate: 20.783976 KB/sec, elapsed 2.10 seconds
request size [1 - 2047], limit 40 KB/sec, actual rate: 39.308144 KB/sec, elapsed 2.10 seconds
request size [1 - 4095], limit 40 KB/sec, actual rate: 40.318349 KB/sec, elapsed 2.20 seconds
request size [1 - 4095], limit 80 KB/sec, actual rate: 79.667396 KB/sec, elapsed 2.20 seconds
request size [1 - 8191], limit 80 KB/sec, actual rate: 81.807158 KB/sec, elapsed 2.30 seconds
request size [1 - 8191], limit 160 KB/sec, actual rate: 160.659761 KB/sec, elapsed 2.20 seconds
request size [1 - 16383], limit 160 KB/sec, actual rate: 160.700990 KB/sec, elapsed 3.00 seconds
request size [1 - 16383], limit 320 KB/sec, actual rate: 317.639481 KB/sec, elapsed 2.50 seconds
[ OK ] RateLimiterTest.Rate (22618 ms)
[ RUN ] RateLimiterTest.LimitChangeTest
[COMPLETE] request size 10 KB, new limit 20KB/sec, refill period 1000 ms
[COMPLETE] request size 10 KB, new limit 5KB/sec, refill period 1000 ms
[COMPLETE] request size 20 KB, new limit 40KB/sec, refill period 1000 ms
[COMPLETE] request size 20 KB, new limit 10KB/sec, refill period 1000 ms
[COMPLETE] request size 40 KB, new limit 80KB/sec, refill period 1000 ms
[COMPLETE] request size 40 KB, new limit 20KB/sec, refill period 1000 ms
[COMPLETE] request size 80 KB, new limit 160KB/sec, refill period 1000 ms
[COMPLETE] request size 80 KB, new limit 40KB/sec, refill period 1000 ms
[COMPLETE] request size 160 KB, new limit 320KB/sec, refill period 1000 ms
[COMPLETE] request size 160 KB, new limit 80KB/sec, refill period 1000 ms
[ OK ] RateLimiterTest.LimitChangeTest (5002 ms)
[----------] 4 tests from RateLimiterTest (27620 ms total)
[----------] Global test environment tear-down
[==========] 4 tests from 1 test case ran. (27621 ms total)
[ PASSED ] 4 tests.
```
Reviewers: sdong, IslamAbdelRahman, yiwu, andrewkr
Reviewed By: andrewkr
Subscribers: andrewkr, dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D60207
2016-07-01 09:16:29 +02:00
|
|
|
if (available_bytes_ < next_req->request_bytes) {
|
|
|
|
// avoid starvation
|
|
|
|
next_req->request_bytes -= available_bytes_;
|
|
|
|
available_bytes_ = 0;
|
generic rate limiter
Summary:
A generic rate limiter that can be shared by threads and rocksdb
instances. Will use this to smooth out write traffic generated by
compaction and flush. This will help us get better p99 behavior on flash
storage.
Test Plan:
unit test output
==== Test RateLimiterTest.Rate
request size [1 - 1023], limit 10 KB/sec, actual rate: 10.374969 KB/sec, elapsed 2002265
request size [1 - 2047], limit 20 KB/sec, actual rate: 20.771242 KB/sec, elapsed 2002139
request size [1 - 4095], limit 40 KB/sec, actual rate: 41.285299 KB/sec, elapsed 2202424
request size [1 - 8191], limit 80 KB/sec, actual rate: 81.371605 KB/sec, elapsed 2402558
request size [1 - 16383], limit 160 KB/sec, actual rate: 162.541268 KB/sec, elapsed 3303500
Reviewers: yhchiang, igor, sdong
Reviewed By: sdong
Subscribers: leveldb
Differential Revision: https://reviews.facebook.net/D19359
2014-07-08 20:41:57 +02:00
|
|
|
break;
|
|
|
|
}
|
fix rate limiter to avoid starvation
Summary:
The current implementation of rate limiter has the possibility to introduce resource starvation when change its limit.
This diff aims to fix this problem by consuming request bytes partially.
Test Plan:
```
./rate_limiter_test
[==========] Running 4 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 4 tests from RateLimiterTest
[ RUN ] RateLimiterTest.OverflowRate
[ OK ] RateLimiterTest.OverflowRate (0 ms)
[ RUN ] RateLimiterTest.StartStop
[ OK ] RateLimiterTest.StartStop (0 ms)
[ RUN ] RateLimiterTest.Rate
request size [1 - 1023], limit 10 KB/sec, actual rate: 10.355712 KB/sec, elapsed 2.00 seconds
request size [1 - 1023], limit 20 KB/sec, actual rate: 19.136564 KB/sec, elapsed 2.00 seconds
request size [1 - 2047], limit 20 KB/sec, actual rate: 20.783976 KB/sec, elapsed 2.10 seconds
request size [1 - 2047], limit 40 KB/sec, actual rate: 39.308144 KB/sec, elapsed 2.10 seconds
request size [1 - 4095], limit 40 KB/sec, actual rate: 40.318349 KB/sec, elapsed 2.20 seconds
request size [1 - 4095], limit 80 KB/sec, actual rate: 79.667396 KB/sec, elapsed 2.20 seconds
request size [1 - 8191], limit 80 KB/sec, actual rate: 81.807158 KB/sec, elapsed 2.30 seconds
request size [1 - 8191], limit 160 KB/sec, actual rate: 160.659761 KB/sec, elapsed 2.20 seconds
request size [1 - 16383], limit 160 KB/sec, actual rate: 160.700990 KB/sec, elapsed 3.00 seconds
request size [1 - 16383], limit 320 KB/sec, actual rate: 317.639481 KB/sec, elapsed 2.50 seconds
[ OK ] RateLimiterTest.Rate (22618 ms)
[ RUN ] RateLimiterTest.LimitChangeTest
[COMPLETE] request size 10 KB, new limit 20KB/sec, refill period 1000 ms
[COMPLETE] request size 10 KB, new limit 5KB/sec, refill period 1000 ms
[COMPLETE] request size 20 KB, new limit 40KB/sec, refill period 1000 ms
[COMPLETE] request size 20 KB, new limit 10KB/sec, refill period 1000 ms
[COMPLETE] request size 40 KB, new limit 80KB/sec, refill period 1000 ms
[COMPLETE] request size 40 KB, new limit 20KB/sec, refill period 1000 ms
[COMPLETE] request size 80 KB, new limit 160KB/sec, refill period 1000 ms
[COMPLETE] request size 80 KB, new limit 40KB/sec, refill period 1000 ms
[COMPLETE] request size 160 KB, new limit 320KB/sec, refill period 1000 ms
[COMPLETE] request size 160 KB, new limit 80KB/sec, refill period 1000 ms
[ OK ] RateLimiterTest.LimitChangeTest (5002 ms)
[----------] 4 tests from RateLimiterTest (27620 ms total)
[----------] Global test environment tear-down
[==========] 4 tests from 1 test case ran. (27621 ms total)
[ PASSED ] 4 tests.
```
Reviewers: sdong, IslamAbdelRahman, yiwu, andrewkr
Reviewed By: andrewkr
Subscribers: andrewkr, dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D60207
2016-07-01 09:16:29 +02:00
|
|
|
available_bytes_ -= next_req->request_bytes;
|
|
|
|
next_req->request_bytes = 0;
|
generic rate limiter
Summary:
A generic rate limiter that can be shared by threads and rocksdb
instances. Will use this to smooth out write traffic generated by
compaction and flush. This will help us get better p99 behavior on flash
storage.
Test Plan:
unit test output
==== Test RateLimiterTest.Rate
request size [1 - 1023], limit 10 KB/sec, actual rate: 10.374969 KB/sec, elapsed 2002265
request size [1 - 2047], limit 20 KB/sec, actual rate: 20.771242 KB/sec, elapsed 2002139
request size [1 - 4095], limit 40 KB/sec, actual rate: 41.285299 KB/sec, elapsed 2202424
request size [1 - 8191], limit 80 KB/sec, actual rate: 81.371605 KB/sec, elapsed 2402558
request size [1 - 16383], limit 160 KB/sec, actual rate: 162.541268 KB/sec, elapsed 3303500
Reviewers: yhchiang, igor, sdong
Reviewed By: sdong
Subscribers: leveldb
Differential Revision: https://reviews.facebook.net/D19359
2014-07-08 20:41:57 +02:00
|
|
|
total_bytes_through_[use_pri] += next_req->bytes;
|
|
|
|
queue->pop_front();
|
|
|
|
|
|
|
|
next_req->granted = true;
|
|
|
|
if (next_req != leader_) {
|
|
|
|
// Quota granted, signal the thread
|
|
|
|
next_req->cv.Signal();
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2016-05-28 01:14:24 +02:00
|
|
|
int64_t GenericRateLimiter::CalculateRefillBytesPerPeriod(
|
|
|
|
int64_t rate_bytes_per_sec) {
|
|
|
|
if (port::kMaxInt64 / rate_bytes_per_sec < refill_period_us_) {
|
|
|
|
// Avoid unexpected result in the overflow case. The result now is still
|
|
|
|
// inaccurate but is a number that is large enough.
|
|
|
|
return port::kMaxInt64 / 1000000;
|
|
|
|
} else {
|
|
|
|
return std::max(kMinRefillBytesPerPeriod,
|
|
|
|
rate_bytes_per_sec * refill_period_us_ / 1000000);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2017-10-05 04:02:22 +02:00
|
|
|
Status GenericRateLimiter::Tune() {
|
|
|
|
const int kLowWatermarkPct = 50;
|
|
|
|
const int kHighWatermarkPct = 90;
|
|
|
|
const int kAdjustFactorPct = 5;
|
|
|
|
// computed rate limit will be in
|
|
|
|
// `[max_bytes_per_sec_ / kAllowedRangeFactor, max_bytes_per_sec_]`.
|
|
|
|
const int kAllowedRangeFactor = 20;
|
|
|
|
|
|
|
|
std::chrono::microseconds prev_tuned_time = tuned_time_;
|
2021-03-15 12:32:24 +01:00
|
|
|
tuned_time_ = std::chrono::microseconds(NowMicrosMonotonic());
|
2017-10-05 04:02:22 +02:00
|
|
|
|
|
|
|
int64_t elapsed_intervals = (tuned_time_ - prev_tuned_time +
|
|
|
|
std::chrono::microseconds(refill_period_us_) -
|
|
|
|
std::chrono::microseconds(1)) /
|
|
|
|
std::chrono::microseconds(refill_period_us_);
|
|
|
|
// We tune every kRefillsPerTune intervals, so the overflow and division-by-
|
|
|
|
// zero conditions should never happen.
|
|
|
|
assert(num_drains_ - prev_num_drains_ <= port::kMaxInt64 / 100);
|
|
|
|
assert(elapsed_intervals > 0);
|
|
|
|
int64_t drained_pct =
|
|
|
|
(num_drains_ - prev_num_drains_) * 100 / elapsed_intervals;
|
|
|
|
|
|
|
|
int64_t prev_bytes_per_sec = GetBytesPerSecond();
|
|
|
|
int64_t new_bytes_per_sec;
|
|
|
|
if (drained_pct == 0) {
|
|
|
|
new_bytes_per_sec = max_bytes_per_sec_ / kAllowedRangeFactor;
|
|
|
|
} else if (drained_pct < kLowWatermarkPct) {
|
|
|
|
// sanitize to prevent overflow
|
|
|
|
int64_t sanitized_prev_bytes_per_sec =
|
|
|
|
std::min(prev_bytes_per_sec, port::kMaxInt64 / 100);
|
|
|
|
new_bytes_per_sec =
|
|
|
|
std::max(max_bytes_per_sec_ / kAllowedRangeFactor,
|
|
|
|
sanitized_prev_bytes_per_sec * 100 / (100 + kAdjustFactorPct));
|
|
|
|
} else if (drained_pct > kHighWatermarkPct) {
|
|
|
|
// sanitize to prevent overflow
|
|
|
|
int64_t sanitized_prev_bytes_per_sec = std::min(
|
|
|
|
prev_bytes_per_sec, port::kMaxInt64 / (100 + kAdjustFactorPct));
|
|
|
|
new_bytes_per_sec =
|
|
|
|
std::min(max_bytes_per_sec_,
|
|
|
|
sanitized_prev_bytes_per_sec * (100 + kAdjustFactorPct) / 100);
|
|
|
|
} else {
|
|
|
|
new_bytes_per_sec = prev_bytes_per_sec;
|
|
|
|
}
|
|
|
|
if (new_bytes_per_sec != prev_bytes_per_sec) {
|
|
|
|
SetBytesPerSecond(new_bytes_per_sec);
|
|
|
|
}
|
|
|
|
num_drains_ = prev_num_drains_;
|
|
|
|
return Status::OK();
|
|
|
|
}
|
|
|
|
|
2014-07-26 00:17:06 +02:00
|
|
|
RateLimiter* NewGenericRateLimiter(
|
2017-06-13 23:51:22 +02:00
|
|
|
int64_t rate_bytes_per_sec, int64_t refill_period_us /* = 100 * 1000 */,
|
|
|
|
int32_t fairness /* = 10 */,
|
2017-10-05 04:02:22 +02:00
|
|
|
RateLimiter::Mode mode /* = RateLimiter::Mode::kWritesOnly */,
|
|
|
|
bool auto_tuned /* = false */) {
|
2015-03-18 23:35:55 +01:00
|
|
|
assert(rate_bytes_per_sec > 0);
|
|
|
|
assert(refill_period_us > 0);
|
|
|
|
assert(fairness > 0);
|
2017-06-13 23:51:22 +02:00
|
|
|
return new GenericRateLimiter(rate_bytes_per_sec, refill_period_us, fairness,
|
2021-01-26 07:07:26 +01:00
|
|
|
mode, SystemClock::Default(), auto_tuned);
|
generic rate limiter
Summary:
A generic rate limiter that can be shared by threads and rocksdb
instances. Will use this to smooth out write traffic generated by
compaction and flush. This will help us get better p99 behavior on flash
storage.
Test Plan:
unit test output
==== Test RateLimiterTest.Rate
request size [1 - 1023], limit 10 KB/sec, actual rate: 10.374969 KB/sec, elapsed 2002265
request size [1 - 2047], limit 20 KB/sec, actual rate: 20.771242 KB/sec, elapsed 2002139
request size [1 - 4095], limit 40 KB/sec, actual rate: 41.285299 KB/sec, elapsed 2202424
request size [1 - 8191], limit 80 KB/sec, actual rate: 81.371605 KB/sec, elapsed 2402558
request size [1 - 16383], limit 160 KB/sec, actual rate: 162.541268 KB/sec, elapsed 3303500
Reviewers: yhchiang, igor, sdong
Reviewed By: sdong
Subscribers: leveldb
Differential Revision: https://reviews.facebook.net/D19359
2014-07-08 20:41:57 +02:00
|
|
|
}
|
|
|
|
|
2020-02-20 21:07:53 +01:00
|
|
|
} // namespace ROCKSDB_NAMESPACE
|