2016-02-10 00:12:00 +01:00
|
|
|
// Copyright (c) 2011-present, Facebook, Inc. All rights reserved.
|
2013-10-16 23:59:46 +02:00
|
|
|
// This source code is licensed under the BSD-style license found in the
|
|
|
|
// LICENSE file in the root directory of this source tree. An additional grant
|
|
|
|
// of patent rights can be found in the PATENTS file in the same directory.
|
2017-04-28 02:50:56 +02:00
|
|
|
// This source code is also licensed under the GPLv2 license found in the
|
|
|
|
// COPYING file in the root directory of this source tree.
|
2013-10-16 23:59:46 +02:00
|
|
|
//
|
2011-03-18 23:37:00 +01:00
|
|
|
// Copyright (c) 2011 The LevelDB Authors. All rights reserved.
|
|
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
|
|
// found in the LICENSE file. See the AUTHORS file for names of contributors.
|
|
|
|
|
|
|
|
#include "table/two_level_iterator.h"
|
2016-04-26 21:41:07 +02:00
|
|
|
#include "db/pinned_iterators_manager.h"
|
2013-10-29 01:54:09 +01:00
|
|
|
#include "rocksdb/options.h"
|
|
|
|
#include "rocksdb/table.h"
|
2011-03-18 23:37:00 +01:00
|
|
|
#include "table/block.h"
|
|
|
|
#include "table/format.h"
|
In DB::NewIterator(), try to allocate the whole iterator tree in an arena
Summary:
In this patch, try to allocate the whole iterator tree starting from DBIter from an arena
1. ArenaWrappedDBIter is created when serves as the entry point of an iterator tree, with an arena in it.
2. Add an option to create iterator from arena for following iterators: DBIter, MergingIterator, MemtableIterator, all mem table's iterators, all table reader's iterators and two level iterator.
3. MergeIteratorBuilder is created to incrementally build the tree of internal iterators. It is passed to mem table list and version set and add iterators to it.
Limitations:
(1) Only DB::NewIterator() without tailing uses the arena. Other cases, including readonly DB and compactions are still from malloc
(2) Two level iterator itself is allocated in arena, but not iterators inside it.
Test Plan: make all check
Reviewers: ljin, haobo
Reviewed By: haobo
Subscribers: leveldb, dhruba, yhchiang, igor
Differential Revision: https://reviews.facebook.net/D18513
2014-06-03 01:38:00 +02:00
|
|
|
#include "util/arena.h"
|
2011-03-18 23:37:00 +01:00
|
|
|
|
2013-10-04 06:49:15 +02:00
|
|
|
namespace rocksdb {
|
2011-03-18 23:37:00 +01:00
|
|
|
|
|
|
|
namespace {
|
|
|
|
|
2015-10-13 00:06:38 +02:00
|
|
|
class TwoLevelIterator : public InternalIterator {
|
2011-03-18 23:37:00 +01:00
|
|
|
public:
|
2014-04-25 21:22:23 +02:00
|
|
|
explicit TwoLevelIterator(TwoLevelIteratorState* state,
|
2015-10-13 00:06:38 +02:00
|
|
|
InternalIterator* first_level_iter,
|
2015-06-30 23:15:24 +02:00
|
|
|
bool need_free_iter_and_state);
|
2011-03-18 23:37:00 +01:00
|
|
|
|
In DB::NewIterator(), try to allocate the whole iterator tree in an arena
Summary:
In this patch, try to allocate the whole iterator tree starting from DBIter from an arena
1. ArenaWrappedDBIter is created when serves as the entry point of an iterator tree, with an arena in it.
2. Add an option to create iterator from arena for following iterators: DBIter, MergingIterator, MemtableIterator, all mem table's iterators, all table reader's iterators and two level iterator.
3. MergeIteratorBuilder is created to incrementally build the tree of internal iterators. It is passed to mem table list and version set and add iterators to it.
Limitations:
(1) Only DB::NewIterator() without tailing uses the arena. Other cases, including readonly DB and compactions are still from malloc
(2) Two level iterator itself is allocated in arena, but not iterators inside it.
Test Plan: make all check
Reviewers: ljin, haobo
Reviewed By: haobo
Subscribers: leveldb, dhruba, yhchiang, igor
Differential Revision: https://reviews.facebook.net/D18513
2014-06-03 01:38:00 +02:00
|
|
|
virtual ~TwoLevelIterator() {
|
2016-04-26 21:41:07 +02:00
|
|
|
// Assert that the TwoLevelIterator is never deleted while Pinning is
|
|
|
|
// Enabled.
|
|
|
|
assert(!pinned_iters_mgr_ ||
|
|
|
|
(pinned_iters_mgr_ && !pinned_iters_mgr_->PinningEnabled()));
|
2015-06-30 23:15:24 +02:00
|
|
|
first_level_iter_.DeleteIter(!need_free_iter_and_state_);
|
In DB::NewIterator(), try to allocate the whole iterator tree in an arena
Summary:
In this patch, try to allocate the whole iterator tree starting from DBIter from an arena
1. ArenaWrappedDBIter is created when serves as the entry point of an iterator tree, with an arena in it.
2. Add an option to create iterator from arena for following iterators: DBIter, MergingIterator, MemtableIterator, all mem table's iterators, all table reader's iterators and two level iterator.
3. MergeIteratorBuilder is created to incrementally build the tree of internal iterators. It is passed to mem table list and version set and add iterators to it.
Limitations:
(1) Only DB::NewIterator() without tailing uses the arena. Other cases, including readonly DB and compactions are still from malloc
(2) Two level iterator itself is allocated in arena, but not iterators inside it.
Test Plan: make all check
Reviewers: ljin, haobo
Reviewed By: haobo
Subscribers: leveldb, dhruba, yhchiang, igor
Differential Revision: https://reviews.facebook.net/D18513
2014-06-03 01:38:00 +02:00
|
|
|
second_level_iter_.DeleteIter(false);
|
2015-06-30 23:15:24 +02:00
|
|
|
if (need_free_iter_and_state_) {
|
|
|
|
delete state_;
|
|
|
|
} else {
|
|
|
|
state_->~TwoLevelIteratorState();
|
|
|
|
}
|
In DB::NewIterator(), try to allocate the whole iterator tree in an arena
Summary:
In this patch, try to allocate the whole iterator tree starting from DBIter from an arena
1. ArenaWrappedDBIter is created when serves as the entry point of an iterator tree, with an arena in it.
2. Add an option to create iterator from arena for following iterators: DBIter, MergingIterator, MemtableIterator, all mem table's iterators, all table reader's iterators and two level iterator.
3. MergeIteratorBuilder is created to incrementally build the tree of internal iterators. It is passed to mem table list and version set and add iterators to it.
Limitations:
(1) Only DB::NewIterator() without tailing uses the arena. Other cases, including readonly DB and compactions are still from malloc
(2) Two level iterator itself is allocated in arena, but not iterators inside it.
Test Plan: make all check
Reviewers: ljin, haobo
Reviewed By: haobo
Subscribers: leveldb, dhruba, yhchiang, igor
Differential Revision: https://reviews.facebook.net/D18513
2014-06-03 01:38:00 +02:00
|
|
|
}
|
2011-03-18 23:37:00 +01:00
|
|
|
|
2015-02-26 20:28:41 +01:00
|
|
|
virtual void Seek(const Slice& target) override;
|
2016-09-28 03:20:57 +02:00
|
|
|
virtual void SeekForPrev(const Slice& target) override;
|
2015-02-26 20:28:41 +01:00
|
|
|
virtual void SeekToFirst() override;
|
|
|
|
virtual void SeekToLast() override;
|
|
|
|
virtual void Next() override;
|
|
|
|
virtual void Prev() override;
|
|
|
|
|
|
|
|
virtual bool Valid() const override { return second_level_iter_.Valid(); }
|
|
|
|
virtual Slice key() const override {
|
2011-03-18 23:37:00 +01:00
|
|
|
assert(Valid());
|
2014-04-25 21:22:23 +02:00
|
|
|
return second_level_iter_.key();
|
2011-03-18 23:37:00 +01:00
|
|
|
}
|
2015-02-26 20:28:41 +01:00
|
|
|
virtual Slice value() const override {
|
2011-03-18 23:37:00 +01:00
|
|
|
assert(Valid());
|
2014-04-25 21:22:23 +02:00
|
|
|
return second_level_iter_.value();
|
2011-03-18 23:37:00 +01:00
|
|
|
}
|
2015-02-26 20:28:41 +01:00
|
|
|
virtual Status status() const override {
|
2011-03-18 23:37:00 +01:00
|
|
|
// It'd be nice if status() returned a const Status& instead of a Status
|
2014-04-25 21:22:23 +02:00
|
|
|
if (!first_level_iter_.status().ok()) {
|
|
|
|
return first_level_iter_.status();
|
|
|
|
} else if (second_level_iter_.iter() != nullptr &&
|
|
|
|
!second_level_iter_.status().ok()) {
|
|
|
|
return second_level_iter_.status();
|
2011-03-18 23:37:00 +01:00
|
|
|
} else {
|
|
|
|
return status_;
|
|
|
|
}
|
|
|
|
}
|
2016-04-26 21:41:07 +02:00
|
|
|
virtual void SetPinnedItersMgr(
|
|
|
|
PinnedIteratorsManager* pinned_iters_mgr) override {
|
|
|
|
pinned_iters_mgr_ = pinned_iters_mgr;
|
|
|
|
first_level_iter_.SetPinnedItersMgr(pinned_iters_mgr);
|
|
|
|
if (second_level_iter_.iter()) {
|
|
|
|
second_level_iter_.SetPinnedItersMgr(pinned_iters_mgr);
|
|
|
|
}
|
2015-12-16 21:08:30 +01:00
|
|
|
}
|
|
|
|
virtual bool IsKeyPinned() const override {
|
2016-04-26 21:41:07 +02:00
|
|
|
return pinned_iters_mgr_ && pinned_iters_mgr_->PinningEnabled() &&
|
|
|
|
second_level_iter_.iter() && second_level_iter_.IsKeyPinned();
|
2015-12-16 21:08:30 +01:00
|
|
|
}
|
Introduce FullMergeV2 (eliminate memcpy from merge operators)
Summary:
This diff update the code to pin the merge operator operands while the merge operation is done, so that we can eliminate the memcpy cost, to do that we need a new public API for FullMerge that replace the std::deque<std::string> with std::vector<Slice>
This diff is stacked on top of D56493 and D56511
In this diff we
- Update FullMergeV2 arguments to be encapsulated in MergeOperationInput and MergeOperationOutput which will make it easier to add new arguments in the future
- Replace std::deque<std::string> with std::vector<Slice> to pass operands
- Replace MergeContext std::deque with std::vector (based on a simple benchmark I ran https://gist.github.com/IslamAbdelRahman/78fc86c9ab9f52b1df791e58943fb187)
- Allow FullMergeV2 output to be an existing operand
```
[Everything in Memtable | 10K operands | 10 KB each | 1 operand per key]
DEBUG_LEVEL=0 make db_bench -j64 && ./db_bench --benchmarks="mergerandom,readseq,readseq,readseq,readseq,readseq" --merge_operator="max" --merge_keys=10000 --num=10000 --disable_auto_compactions --value_size=10240 --write_buffer_size=1000000000
[FullMergeV2]
readseq : 0.607 micros/op 1648235 ops/sec; 16121.2 MB/s
readseq : 0.478 micros/op 2091546 ops/sec; 20457.2 MB/s
readseq : 0.252 micros/op 3972081 ops/sec; 38850.5 MB/s
readseq : 0.237 micros/op 4218328 ops/sec; 41259.0 MB/s
readseq : 0.247 micros/op 4043927 ops/sec; 39553.2 MB/s
[master]
readseq : 3.935 micros/op 254140 ops/sec; 2485.7 MB/s
readseq : 3.722 micros/op 268657 ops/sec; 2627.7 MB/s
readseq : 3.149 micros/op 317605 ops/sec; 3106.5 MB/s
readseq : 3.125 micros/op 320024 ops/sec; 3130.1 MB/s
readseq : 4.075 micros/op 245374 ops/sec; 2400.0 MB/s
```
```
[Everything in Memtable | 10K operands | 10 KB each | 10 operand per key]
DEBUG_LEVEL=0 make db_bench -j64 && ./db_bench --benchmarks="mergerandom,readseq,readseq,readseq,readseq,readseq" --merge_operator="max" --merge_keys=1000 --num=10000 --disable_auto_compactions --value_size=10240 --write_buffer_size=1000000000
[FullMergeV2]
readseq : 3.472 micros/op 288018 ops/sec; 2817.1 MB/s
readseq : 2.304 micros/op 434027 ops/sec; 4245.2 MB/s
readseq : 1.163 micros/op 859845 ops/sec; 8410.0 MB/s
readseq : 1.192 micros/op 838926 ops/sec; 8205.4 MB/s
readseq : 1.250 micros/op 800000 ops/sec; 7824.7 MB/s
[master]
readseq : 24.025 micros/op 41623 ops/sec; 407.1 MB/s
readseq : 18.489 micros/op 54086 ops/sec; 529.0 MB/s
readseq : 18.693 micros/op 53495 ops/sec; 523.2 MB/s
readseq : 23.621 micros/op 42335 ops/sec; 414.1 MB/s
readseq : 18.775 micros/op 53262 ops/sec; 521.0 MB/s
```
```
[Everything in Block cache | 10K operands | 10 KB each | 1 operand per key]
[FullMergeV2]
$ DEBUG_LEVEL=0 make db_bench -j64 && ./db_bench --benchmarks="readseq,readseq,readseq,readseq,readseq" --merge_operator="max" --num=100000 --db="/dev/shm/merge-random-10K-10KB" --cache_size=1000000000 --use_existing_db --disable_auto_compactions
readseq : 14.741 micros/op 67837 ops/sec; 663.5 MB/s
readseq : 1.029 micros/op 971446 ops/sec; 9501.6 MB/s
readseq : 0.974 micros/op 1026229 ops/sec; 10037.4 MB/s
readseq : 0.965 micros/op 1036080 ops/sec; 10133.8 MB/s
readseq : 0.943 micros/op 1060657 ops/sec; 10374.2 MB/s
[master]
readseq : 16.735 micros/op 59755 ops/sec; 584.5 MB/s
readseq : 3.029 micros/op 330151 ops/sec; 3229.2 MB/s
readseq : 3.136 micros/op 318883 ops/sec; 3119.0 MB/s
readseq : 3.065 micros/op 326245 ops/sec; 3191.0 MB/s
readseq : 3.014 micros/op 331813 ops/sec; 3245.4 MB/s
```
```
[Everything in Block cache | 10K operands | 10 KB each | 10 operand per key]
DEBUG_LEVEL=0 make db_bench -j64 && ./db_bench --benchmarks="readseq,readseq,readseq,readseq,readseq" --merge_operator="max" --num=100000 --db="/dev/shm/merge-random-10-operands-10K-10KB" --cache_size=1000000000 --use_existing_db --disable_auto_compactions
[FullMergeV2]
readseq : 24.325 micros/op 41109 ops/sec; 402.1 MB/s
readseq : 1.470 micros/op 680272 ops/sec; 6653.7 MB/s
readseq : 1.231 micros/op 812347 ops/sec; 7945.5 MB/s
readseq : 1.091 micros/op 916590 ops/sec; 8965.1 MB/s
readseq : 1.109 micros/op 901713 ops/sec; 8819.6 MB/s
[master]
readseq : 27.257 micros/op 36687 ops/sec; 358.8 MB/s
readseq : 4.443 micros/op 225073 ops/sec; 2201.4 MB/s
readseq : 5.830 micros/op 171526 ops/sec; 1677.7 MB/s
readseq : 4.173 micros/op 239635 ops/sec; 2343.8 MB/s
readseq : 4.150 micros/op 240963 ops/sec; 2356.8 MB/s
```
Test Plan: COMPILE_WITH_ASAN=1 make check -j64
Reviewers: yhchiang, andrewkr, sdong
Reviewed By: sdong
Subscribers: lovro, andrewkr, dhruba
Differential Revision: https://reviews.facebook.net/D57075
2016-07-20 18:49:03 +02:00
|
|
|
virtual bool IsValuePinned() const override {
|
|
|
|
return pinned_iters_mgr_ && pinned_iters_mgr_->PinningEnabled() &&
|
|
|
|
second_level_iter_.iter() && second_level_iter_.IsValuePinned();
|
|
|
|
}
|
2011-03-18 23:37:00 +01:00
|
|
|
|
|
|
|
private:
|
|
|
|
void SaveError(const Status& s) {
|
|
|
|
if (status_.ok() && !s.ok()) status_ = s;
|
|
|
|
}
|
|
|
|
void SkipEmptyDataBlocksForward();
|
|
|
|
void SkipEmptyDataBlocksBackward();
|
2015-10-13 00:06:38 +02:00
|
|
|
void SetSecondLevelIterator(InternalIterator* iter);
|
2011-03-18 23:37:00 +01:00
|
|
|
void InitDataBlock();
|
|
|
|
|
2015-06-30 23:15:24 +02:00
|
|
|
TwoLevelIteratorState* state_;
|
2014-04-25 21:22:23 +02:00
|
|
|
IteratorWrapper first_level_iter_;
|
|
|
|
IteratorWrapper second_level_iter_; // May be nullptr
|
2015-06-30 23:15:24 +02:00
|
|
|
bool need_free_iter_and_state_;
|
2016-04-26 21:41:07 +02:00
|
|
|
PinnedIteratorsManager* pinned_iters_mgr_;
|
2011-03-18 23:37:00 +01:00
|
|
|
Status status_;
|
2014-04-25 21:22:23 +02:00
|
|
|
// If second_level_iter is non-nullptr, then "data_block_handle_" holds the
|
|
|
|
// "index_value" passed to block_function_ to create the second_level_iter.
|
2011-03-18 23:37:00 +01:00
|
|
|
std::string data_block_handle_;
|
|
|
|
};
|
|
|
|
|
2014-04-25 21:22:23 +02:00
|
|
|
TwoLevelIterator::TwoLevelIterator(TwoLevelIteratorState* state,
|
2015-10-13 00:06:38 +02:00
|
|
|
InternalIterator* first_level_iter,
|
2015-06-30 23:15:24 +02:00
|
|
|
bool need_free_iter_and_state)
|
|
|
|
: state_(state),
|
|
|
|
first_level_iter_(first_level_iter),
|
2016-04-26 21:41:07 +02:00
|
|
|
need_free_iter_and_state_(need_free_iter_and_state),
|
|
|
|
pinned_iters_mgr_(nullptr) {}
|
2011-03-18 23:37:00 +01:00
|
|
|
|
|
|
|
void TwoLevelIterator::Seek(const Slice& target) {
|
2014-04-25 21:23:07 +02:00
|
|
|
if (state_->check_prefix_may_match &&
|
|
|
|
!state_->PrefixMayMatch(target)) {
|
2014-04-25 21:22:23 +02:00
|
|
|
SetSecondLevelIterator(nullptr);
|
2014-04-25 21:23:07 +02:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
first_level_iter_.Seek(target);
|
|
|
|
|
|
|
|
InitDataBlock();
|
|
|
|
if (second_level_iter_.iter() != nullptr) {
|
|
|
|
second_level_iter_.Seek(target);
|
2014-04-25 21:22:23 +02:00
|
|
|
}
|
2014-04-25 21:23:07 +02:00
|
|
|
SkipEmptyDataBlocksForward();
|
2011-03-18 23:37:00 +01:00
|
|
|
}
|
|
|
|
|
2016-09-28 03:20:57 +02:00
|
|
|
void TwoLevelIterator::SeekForPrev(const Slice& target) {
|
|
|
|
if (state_->check_prefix_may_match && !state_->PrefixMayMatch(target)) {
|
|
|
|
SetSecondLevelIterator(nullptr);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
first_level_iter_.Seek(target);
|
|
|
|
InitDataBlock();
|
|
|
|
if (second_level_iter_.iter() != nullptr) {
|
|
|
|
second_level_iter_.SeekForPrev(target);
|
|
|
|
}
|
|
|
|
if (!Valid()) {
|
|
|
|
if (!first_level_iter_.Valid()) {
|
|
|
|
first_level_iter_.SeekToLast();
|
|
|
|
InitDataBlock();
|
|
|
|
if (second_level_iter_.iter() != nullptr) {
|
|
|
|
second_level_iter_.SeekForPrev(target);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
SkipEmptyDataBlocksBackward();
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2011-03-18 23:37:00 +01:00
|
|
|
void TwoLevelIterator::SeekToFirst() {
|
2014-04-25 21:22:23 +02:00
|
|
|
first_level_iter_.SeekToFirst();
|
2011-03-18 23:37:00 +01:00
|
|
|
InitDataBlock();
|
2014-04-25 21:22:23 +02:00
|
|
|
if (second_level_iter_.iter() != nullptr) {
|
|
|
|
second_level_iter_.SeekToFirst();
|
|
|
|
}
|
2011-03-18 23:37:00 +01:00
|
|
|
SkipEmptyDataBlocksForward();
|
|
|
|
}
|
|
|
|
|
|
|
|
void TwoLevelIterator::SeekToLast() {
|
2014-04-25 21:22:23 +02:00
|
|
|
first_level_iter_.SeekToLast();
|
2011-03-18 23:37:00 +01:00
|
|
|
InitDataBlock();
|
2014-04-25 21:22:23 +02:00
|
|
|
if (second_level_iter_.iter() != nullptr) {
|
|
|
|
second_level_iter_.SeekToLast();
|
|
|
|
}
|
2011-03-18 23:37:00 +01:00
|
|
|
SkipEmptyDataBlocksBackward();
|
|
|
|
}
|
|
|
|
|
|
|
|
void TwoLevelIterator::Next() {
|
|
|
|
assert(Valid());
|
2014-04-25 21:22:23 +02:00
|
|
|
second_level_iter_.Next();
|
2011-03-18 23:37:00 +01:00
|
|
|
SkipEmptyDataBlocksForward();
|
|
|
|
}
|
|
|
|
|
|
|
|
void TwoLevelIterator::Prev() {
|
|
|
|
assert(Valid());
|
2014-04-25 21:22:23 +02:00
|
|
|
second_level_iter_.Prev();
|
2011-03-18 23:37:00 +01:00
|
|
|
SkipEmptyDataBlocksBackward();
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
void TwoLevelIterator::SkipEmptyDataBlocksForward() {
|
2014-04-25 21:22:23 +02:00
|
|
|
while (second_level_iter_.iter() == nullptr ||
|
|
|
|
(!second_level_iter_.Valid() &&
|
|
|
|
!second_level_iter_.status().IsIncomplete())) {
|
2011-03-18 23:37:00 +01:00
|
|
|
// Move to next block
|
2014-04-25 21:22:23 +02:00
|
|
|
if (!first_level_iter_.Valid()) {
|
|
|
|
SetSecondLevelIterator(nullptr);
|
2011-03-18 23:37:00 +01:00
|
|
|
return;
|
|
|
|
}
|
2014-04-25 21:22:23 +02:00
|
|
|
first_level_iter_.Next();
|
2011-03-18 23:37:00 +01:00
|
|
|
InitDataBlock();
|
2014-04-25 21:22:23 +02:00
|
|
|
if (second_level_iter_.iter() != nullptr) {
|
|
|
|
second_level_iter_.SeekToFirst();
|
|
|
|
}
|
2011-03-18 23:37:00 +01:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
void TwoLevelIterator::SkipEmptyDataBlocksBackward() {
|
2014-04-25 21:22:23 +02:00
|
|
|
while (second_level_iter_.iter() == nullptr ||
|
|
|
|
(!second_level_iter_.Valid() &&
|
|
|
|
!second_level_iter_.status().IsIncomplete())) {
|
2011-03-18 23:37:00 +01:00
|
|
|
// Move to next block
|
2014-04-25 21:22:23 +02:00
|
|
|
if (!first_level_iter_.Valid()) {
|
|
|
|
SetSecondLevelIterator(nullptr);
|
2011-03-18 23:37:00 +01:00
|
|
|
return;
|
|
|
|
}
|
2014-04-25 21:22:23 +02:00
|
|
|
first_level_iter_.Prev();
|
2011-03-18 23:37:00 +01:00
|
|
|
InitDataBlock();
|
2014-04-25 21:22:23 +02:00
|
|
|
if (second_level_iter_.iter() != nullptr) {
|
|
|
|
second_level_iter_.SeekToLast();
|
|
|
|
}
|
2011-03-18 23:37:00 +01:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2015-10-13 00:06:38 +02:00
|
|
|
void TwoLevelIterator::SetSecondLevelIterator(InternalIterator* iter) {
|
2014-04-25 21:22:23 +02:00
|
|
|
if (second_level_iter_.iter() != nullptr) {
|
|
|
|
SaveError(second_level_iter_.status());
|
|
|
|
}
|
2016-04-26 21:41:07 +02:00
|
|
|
|
|
|
|
if (pinned_iters_mgr_ && iter) {
|
|
|
|
iter->SetPinnedItersMgr(pinned_iters_mgr_);
|
|
|
|
}
|
|
|
|
|
|
|
|
InternalIterator* old_iter = second_level_iter_.Set(iter);
|
|
|
|
if (pinned_iters_mgr_ && pinned_iters_mgr_->PinningEnabled()) {
|
2016-08-11 20:54:17 +02:00
|
|
|
pinned_iters_mgr_->PinIterator(old_iter);
|
2016-04-26 21:41:07 +02:00
|
|
|
} else {
|
|
|
|
delete old_iter;
|
|
|
|
}
|
2011-03-18 23:37:00 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
void TwoLevelIterator::InitDataBlock() {
|
2014-04-25 21:22:23 +02:00
|
|
|
if (!first_level_iter_.Valid()) {
|
|
|
|
SetSecondLevelIterator(nullptr);
|
2011-03-18 23:37:00 +01:00
|
|
|
} else {
|
2014-04-25 21:22:23 +02:00
|
|
|
Slice handle = first_level_iter_.value();
|
2014-08-29 23:32:37 +02:00
|
|
|
if (second_level_iter_.iter() != nullptr &&
|
|
|
|
!second_level_iter_.status().IsIncomplete() &&
|
|
|
|
handle.compare(data_block_handle_) == 0) {
|
2014-04-25 21:22:23 +02:00
|
|
|
// second_level_iter is already constructed with this iterator, so
|
2011-03-18 23:37:00 +01:00
|
|
|
// no need to change anything
|
|
|
|
} else {
|
2015-10-13 00:06:38 +02:00
|
|
|
InternalIterator* iter = state_->NewSecondaryIterator(handle);
|
2011-03-18 23:37:00 +01:00
|
|
|
data_block_handle_.assign(handle.data(), handle.size());
|
2014-04-25 21:22:23 +02:00
|
|
|
SetSecondLevelIterator(iter);
|
2011-03-18 23:37:00 +01:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2011-10-31 18:22:06 +01:00
|
|
|
} // namespace
|
2011-03-18 23:37:00 +01:00
|
|
|
|
2015-10-13 00:06:38 +02:00
|
|
|
InternalIterator* NewTwoLevelIterator(TwoLevelIteratorState* state,
|
|
|
|
InternalIterator* first_level_iter,
|
|
|
|
Arena* arena,
|
|
|
|
bool need_free_iter_and_state) {
|
In DB::NewIterator(), try to allocate the whole iterator tree in an arena
Summary:
In this patch, try to allocate the whole iterator tree starting from DBIter from an arena
1. ArenaWrappedDBIter is created when serves as the entry point of an iterator tree, with an arena in it.
2. Add an option to create iterator from arena for following iterators: DBIter, MergingIterator, MemtableIterator, all mem table's iterators, all table reader's iterators and two level iterator.
3. MergeIteratorBuilder is created to incrementally build the tree of internal iterators. It is passed to mem table list and version set and add iterators to it.
Limitations:
(1) Only DB::NewIterator() without tailing uses the arena. Other cases, including readonly DB and compactions are still from malloc
(2) Two level iterator itself is allocated in arena, but not iterators inside it.
Test Plan: make all check
Reviewers: ljin, haobo
Reviewed By: haobo
Subscribers: leveldb, dhruba, yhchiang, igor
Differential Revision: https://reviews.facebook.net/D18513
2014-06-03 01:38:00 +02:00
|
|
|
if (arena == nullptr) {
|
2015-06-30 23:15:24 +02:00
|
|
|
return new TwoLevelIterator(state, first_level_iter,
|
|
|
|
need_free_iter_and_state);
|
In DB::NewIterator(), try to allocate the whole iterator tree in an arena
Summary:
In this patch, try to allocate the whole iterator tree starting from DBIter from an arena
1. ArenaWrappedDBIter is created when serves as the entry point of an iterator tree, with an arena in it.
2. Add an option to create iterator from arena for following iterators: DBIter, MergingIterator, MemtableIterator, all mem table's iterators, all table reader's iterators and two level iterator.
3. MergeIteratorBuilder is created to incrementally build the tree of internal iterators. It is passed to mem table list and version set and add iterators to it.
Limitations:
(1) Only DB::NewIterator() without tailing uses the arena. Other cases, including readonly DB and compactions are still from malloc
(2) Two level iterator itself is allocated in arena, but not iterators inside it.
Test Plan: make all check
Reviewers: ljin, haobo
Reviewed By: haobo
Subscribers: leveldb, dhruba, yhchiang, igor
Differential Revision: https://reviews.facebook.net/D18513
2014-06-03 01:38:00 +02:00
|
|
|
} else {
|
|
|
|
auto mem = arena->AllocateAligned(sizeof(TwoLevelIterator));
|
2015-06-30 23:15:24 +02:00
|
|
|
return new (mem)
|
|
|
|
TwoLevelIterator(state, first_level_iter, need_free_iter_and_state);
|
In DB::NewIterator(), try to allocate the whole iterator tree in an arena
Summary:
In this patch, try to allocate the whole iterator tree starting from DBIter from an arena
1. ArenaWrappedDBIter is created when serves as the entry point of an iterator tree, with an arena in it.
2. Add an option to create iterator from arena for following iterators: DBIter, MergingIterator, MemtableIterator, all mem table's iterators, all table reader's iterators and two level iterator.
3. MergeIteratorBuilder is created to incrementally build the tree of internal iterators. It is passed to mem table list and version set and add iterators to it.
Limitations:
(1) Only DB::NewIterator() without tailing uses the arena. Other cases, including readonly DB and compactions are still from malloc
(2) Two level iterator itself is allocated in arena, but not iterators inside it.
Test Plan: make all check
Reviewers: ljin, haobo
Reviewed By: haobo
Subscribers: leveldb, dhruba, yhchiang, igor
Differential Revision: https://reviews.facebook.net/D18513
2014-06-03 01:38:00 +02:00
|
|
|
}
|
2011-03-18 23:37:00 +01:00
|
|
|
}
|
|
|
|
|
2013-10-04 06:49:15 +02:00
|
|
|
} // namespace rocksdb
|