2019-04-18 19:51:19 +02:00
|
|
|
# Copyright (c) Facebook, Inc. and its affiliates. All Rights Reserved.
|
2017-04-05 01:09:31 +02:00
|
|
|
from __future__ import absolute_import
|
|
|
|
from __future__ import division
|
|
|
|
from __future__ import print_function
|
|
|
|
from __future__ import unicode_literals
|
2019-11-06 05:19:17 +01:00
|
|
|
|
2020-05-20 20:35:28 +02:00
|
|
|
rocksdb_target_header_template = \
|
2021-01-28 01:19:43 +01:00
|
|
|
"""# This file \100generated by:
|
|
|
|
#$ python3 buckifier/buckify_rocksdb.py{extra_argv}
|
2019-11-06 05:19:17 +01:00
|
|
|
# --> DO NOT EDIT MANUALLY <--
|
|
|
|
# This file is a Facebook-specific integration for buck builds, so can
|
|
|
|
# only be validated by Facebook employees.
|
|
|
|
#
|
2022-02-03 05:38:41 +01:00
|
|
|
# @noautodeps @nocodemods
|
|
|
|
|
2019-11-06 05:19:17 +01:00
|
|
|
load("@fbcode_macros//build_defs:auto_headers.bzl", "AutoHeaders")
|
2019-02-13 19:54:25 +01:00
|
|
|
load("@fbcode_macros//build_defs:cpp_library.bzl", "cpp_library")
|
2019-01-07 22:35:12 +01:00
|
|
|
load(":defs.bzl", "test_binary")
|
2018-08-29 06:14:52 +02:00
|
|
|
|
|
|
|
REPO_PATH = package_name() + "/"
|
2017-11-15 23:13:39 +01:00
|
|
|
|
2021-06-05 01:28:10 +02:00
|
|
|
ROCKSDB_COMPILER_FLAGS_0 = [
|
2017-11-15 23:13:39 +01:00
|
|
|
"-fno-builtin-memcmp",
|
Use -Wno-invalid-offsetof instead of dangerous offset_of hack (#9563)
Summary:
After https://github.com/facebook/rocksdb/issues/9515 added a unique_ptr to Status, we see some
warnings-as-error in some internal builds like this:
```
stderr: rocksdb/src/db/compaction/compaction_job.cc:2839:7: error:
offset of on non-standard-layout type 'struct CompactionServiceResult'
[-Werror,-Winvalid-offsetof]
{offsetof(struct CompactionServiceResult, status),
^ ~~~~~~
```
I see three potential solutions to resolving this:
* Expand our use of an idiom that works around the warning (see offset_of
functions removed in this change, inspired by
https://gist.github.com/graphitemaster/494f21190bb2c63c5516) However,
this construction is invoking undefined behavior that assumes consistent
layout with no compiler-introduced indirection. A compiler incompatible
with our assumptions will likely compile the code and exhibit undefined
behavior.
* Migrate to something in place of offset, like a function mapping
CompactionServiceResult* to Status* (for the `status` field). This might
be required in the long term.
* **Selected:** Use our new C++17 dependency to use offsetof in a well-defined way
when the compiler allows it. From a comment on
https://gist.github.com/graphitemaster/494f21190bb2c63c5516:
> A final note: in C++17, offsetof is conditionally supported, which
> means that you can use it on any type (not just standard layout
> types) and the compiler will error if it can't compile it correctly.
> That appears to be the best option if you can live with C++17 and
> don't need constexpr support.
The C++17 semantics are confirmed on
https://en.cppreference.com/w/cpp/types/offsetof, so we can suppress the
warning as long as we accept that we might run into a compiler that
rejects the code, and at that point we will find a solution, such as
the more intrusive "migrate" solution above.
Although this is currently only showing in our buck build, it will
surely show up also with make and cmake, so I have updated those
configurations as well.
Also in the buck build, -Wno-expansion-to-defined does not appear to be
needed anymore (both current compiler configurations) so I
removed it.
Pull Request resolved: https://github.com/facebook/rocksdb/pull/9563
Test Plan: Tried out buck builds with both current compiler configurations
Reviewed By: riversand963
Differential Revision: D34220931
Pulled By: pdillinger
fbshipit-source-id: d39436008259bd1eaaa87c77be69fb2a5b559e1f
2022-02-15 18:18:08 +01:00
|
|
|
# Allow offsetof to work on non-standard layout types. Some compiler could
|
|
|
|
# completely reject our usage of offsetof, but we will solve that when it
|
|
|
|
# happens.
|
|
|
|
"-Wno-invalid-offsetof",
|
2018-03-30 23:23:55 +02:00
|
|
|
# Added missing flags from output of build_detect_platform
|
2018-06-21 23:30:00 +02:00
|
|
|
"-Wnarrowing",
|
2019-06-04 07:59:54 +02:00
|
|
|
"-DROCKSDB_NO_DYNAMIC_EXTENSION",
|
2017-04-05 01:09:31 +02:00
|
|
|
]
|
|
|
|
|
2019-01-07 22:35:12 +01:00
|
|
|
ROCKSDB_EXTERNAL_DEPS = [
|
2017-11-15 23:13:39 +01:00
|
|
|
("bzip2", None, "bz2"),
|
|
|
|
("snappy", None, "snappy"),
|
|
|
|
("zlib", None, "z"),
|
|
|
|
("gflags", None, "gflags"),
|
|
|
|
("lz4", None, "lz4"),
|
2021-02-08 23:44:02 +01:00
|
|
|
("zstd", None, "zstd"),
|
2017-04-05 01:09:31 +02:00
|
|
|
]
|
|
|
|
|
2021-06-05 01:28:10 +02:00
|
|
|
ROCKSDB_OS_DEPS_0 = [
|
2019-07-31 00:56:41 +02:00
|
|
|
(
|
|
|
|
"linux",
|
2021-11-01 18:09:50 +01:00
|
|
|
[
|
|
|
|
"third-party//numa:numa",
|
|
|
|
"third-party//liburing:uring",
|
|
|
|
"third-party//tbb:tbb",
|
|
|
|
],
|
2020-09-23 21:54:29 +02:00
|
|
|
),
|
|
|
|
(
|
|
|
|
"macos",
|
|
|
|
["third-party//tbb:tbb"],
|
2019-07-31 00:56:41 +02:00
|
|
|
),
|
|
|
|
]
|
|
|
|
|
2021-06-05 01:28:10 +02:00
|
|
|
ROCKSDB_OS_PREPROCESSOR_FLAGS_0 = [
|
2019-07-31 00:56:41 +02:00
|
|
|
(
|
|
|
|
"linux",
|
|
|
|
[
|
|
|
|
"-DOS_LINUX",
|
|
|
|
"-DROCKSDB_FALLOCATE_PRESENT",
|
|
|
|
"-DROCKSDB_MALLOC_USABLE_SIZE",
|
|
|
|
"-DROCKSDB_PTHREAD_ADAPTIVE_MUTEX",
|
|
|
|
"-DROCKSDB_RANGESYNC_PRESENT",
|
|
|
|
"-DROCKSDB_SCHED_GETCPU_PRESENT",
|
2020-02-25 00:45:47 +01:00
|
|
|
"-DROCKSDB_IOURING_PRESENT",
|
2019-07-31 00:56:41 +02:00
|
|
|
"-DHAVE_SSE42",
|
2020-02-25 00:45:47 +01:00
|
|
|
"-DLIBURING",
|
2019-07-31 00:56:41 +02:00
|
|
|
"-DNUMA",
|
2020-09-23 21:54:29 +02:00
|
|
|
"-DROCKSDB_PLATFORM_POSIX",
|
|
|
|
"-DROCKSDB_LIB_IO_POSIX",
|
|
|
|
"-DTBB",
|
2019-07-31 00:56:41 +02:00
|
|
|
],
|
|
|
|
),
|
|
|
|
(
|
|
|
|
"macos",
|
2020-09-23 21:54:29 +02:00
|
|
|
[
|
|
|
|
"-DOS_MACOSX",
|
|
|
|
"-DROCKSDB_PLATFORM_POSIX",
|
|
|
|
"-DROCKSDB_LIB_IO_POSIX",
|
|
|
|
"-DTBB",
|
|
|
|
],
|
|
|
|
),
|
|
|
|
(
|
|
|
|
"windows",
|
2021-11-01 18:09:50 +01:00
|
|
|
[
|
|
|
|
"-DOS_WIN",
|
|
|
|
"-DWIN32",
|
|
|
|
"-D_MBCS",
|
|
|
|
"-DWIN64",
|
|
|
|
"-DNOMINMAX",
|
|
|
|
],
|
2019-07-31 00:56:41 +02:00
|
|
|
),
|
|
|
|
]
|
|
|
|
|
2019-01-07 22:35:12 +01:00
|
|
|
ROCKSDB_PREPROCESSOR_FLAGS = [
|
2019-07-31 00:56:41 +02:00
|
|
|
"-DROCKSDB_SUPPORT_THREAD_LOCAL",
|
|
|
|
|
|
|
|
# Flags to enable libs we include
|
|
|
|
"-DSNAPPY",
|
|
|
|
"-DZLIB",
|
|
|
|
"-DBZIP2",
|
|
|
|
"-DLZ4",
|
|
|
|
"-DZSTD",
|
|
|
|
"-DZSTD_STATIC_LINKING_ONLY",
|
|
|
|
"-DGFLAGS=gflags",
|
|
|
|
|
|
|
|
# Added missing flags from output of build_detect_platform
|
|
|
|
"-DROCKSDB_BACKTRACE",
|
2021-04-03 23:41:25 +02:00
|
|
|
]
|
2019-07-31 00:56:41 +02:00
|
|
|
|
2021-04-03 23:41:25 +02:00
|
|
|
# Directories with files for #include
|
|
|
|
ROCKSDB_INCLUDE_PATHS = [
|
|
|
|
"",
|
|
|
|
"include",
|
2017-04-05 01:09:31 +02:00
|
|
|
]
|
2017-08-14 02:04:19 +02:00
|
|
|
|
2021-01-28 01:19:43 +01:00
|
|
|
ROCKSDB_ARCH_PREPROCESSOR_FLAGS = {{
|
2018-03-06 21:19:15 +01:00
|
|
|
"x86_64": [
|
|
|
|
"-DHAVE_PCLMUL",
|
|
|
|
],
|
2021-01-28 01:19:43 +01:00
|
|
|
}}
|
2017-11-30 19:40:39 +01:00
|
|
|
|
|
|
|
build_mode = read_config("fbcode", "build_mode")
|
|
|
|
|
|
|
|
is_opt_mode = build_mode.startswith("opt")
|
|
|
|
|
|
|
|
# -DNDEBUG is added by default in opt mode in fbcode. But adding it twice
|
|
|
|
# doesn't harm and avoid forgetting to add it.
|
2021-06-05 01:28:10 +02:00
|
|
|
ROCKSDB_COMPILER_FLAGS = ROCKSDB_COMPILER_FLAGS_0 + (["-DNDEBUG"] if is_opt_mode else [])
|
2018-10-15 20:39:54 +02:00
|
|
|
|
|
|
|
sanitizer = read_config("fbcode", "sanitizer")
|
|
|
|
|
2019-01-04 01:26:31 +01:00
|
|
|
# Do not enable jemalloc if sanitizer presents. RocksDB will further detect
|
|
|
|
# whether the binary is linked with jemalloc at runtime.
|
2021-06-05 01:28:10 +02:00
|
|
|
ROCKSDB_OS_PREPROCESSOR_FLAGS = ROCKSDB_OS_PREPROCESSOR_FLAGS_0 + ([(
|
2019-07-31 00:56:41 +02:00
|
|
|
"linux",
|
|
|
|
["-DROCKSDB_JEMALLOC"],
|
|
|
|
)] if sanitizer == "" else [])
|
|
|
|
|
2021-06-05 01:28:10 +02:00
|
|
|
ROCKSDB_OS_DEPS = ROCKSDB_OS_DEPS_0 + ([(
|
2019-07-31 00:56:41 +02:00
|
|
|
"linux",
|
|
|
|
["third-party//jemalloc:headers"],
|
|
|
|
)] if sanitizer == "" else [])
|
2020-05-17 06:46:21 +02:00
|
|
|
|
|
|
|
ROCKSDB_LIB_DEPS = [
|
|
|
|
":rocksdb_lib",
|
|
|
|
":rocksdb_test_lib",
|
|
|
|
] if not is_opt_mode else [":rocksdb_lib"]
|
2017-04-05 01:09:31 +02:00
|
|
|
"""
|
|
|
|
|
|
|
|
|
|
|
|
library_template = """
|
|
|
|
cpp_library(
|
Change BUCK template files (#4624)
Summary:
Slightly changes the format of generated BUCK files for Facebook consumption. Generated targets end up looking like this:
```
cpp_library(
name = "rocksdb_tools_lib",
srcs = [
"tools/db_bench_tool.cc",
"tools/trace_analyzer_tool.cc",
"util/testutil.cc",
],
auto_headers = AutoHeaders.RECURSIVE_GLOB,
arch_preprocessor_flags = rocksdb_arch_preprocessor_flags,
compiler_flags = rocksdb_compiler_flags,
preprocessor_flags = rocksdb_preprocessor_flags,
deps = [":rocksdb_lib"],
external_deps = rocksdb_external_deps,
)
```
Instead of
```
cpp_library(
name = "rocksdb_tools_lib",
srcs = [
"tools/db_bench_tool.cc",
"tools/trace_analyzer_tool.cc",
"util/testutil.cc",
],
headers = AutoHeaders.RECURSIVE_GLOB,
arch_preprocessor_flags = rocksdb_arch_preprocessor_flags,
compiler_flags = rocksdb_compiler_flags,
preprocessor_flags = rocksdb_preprocessor_flags,
deps = [":rocksdb_lib"],
external_deps = rocksdb_external_deps,
)
```
Pull Request resolved: https://github.com/facebook/rocksdb/pull/4624
Reviewed By: riversand963
Differential Revision: D12906711
Pulled By: philipjameson
fbshipit-source-id: 32ab64a3390cdcf2c4043ff77517ac1ad58a5e2b
2018-11-02 22:20:20 +01:00
|
|
|
name = "{name}",
|
|
|
|
srcs = [{srcs}],
|
|
|
|
{headers_attr_prefix}headers = {headers},
|
2019-01-07 22:35:12 +01:00
|
|
|
arch_preprocessor_flags = ROCKSDB_ARCH_PREPROCESSOR_FLAGS,
|
|
|
|
compiler_flags = ROCKSDB_COMPILER_FLAGS,
|
2021-11-01 18:09:50 +01:00
|
|
|
include_paths = ROCKSDB_INCLUDE_PATHS,
|
|
|
|
link_whole = {link_whole},
|
2019-07-31 00:56:41 +02:00
|
|
|
os_deps = ROCKSDB_OS_DEPS,
|
|
|
|
os_preprocessor_flags = ROCKSDB_OS_PREPROCESSOR_FLAGS,
|
2019-01-07 22:35:12 +01:00
|
|
|
preprocessor_flags = ROCKSDB_PREPROCESSOR_FLAGS,
|
2021-12-17 20:50:30 +01:00
|
|
|
exported_deps = [{deps}],
|
|
|
|
exported_external_deps = ROCKSDB_EXTERNAL_DEPS{extra_external_deps},
|
2017-04-05 01:09:31 +02:00
|
|
|
)
|
|
|
|
"""
|
|
|
|
|
2020-05-17 06:46:21 +02:00
|
|
|
rocksdb_library_template = """
|
|
|
|
cpp_library(
|
|
|
|
name = "{name}",
|
|
|
|
srcs = [{srcs}],
|
|
|
|
{headers_attr_prefix}headers = {headers},
|
|
|
|
arch_preprocessor_flags = ROCKSDB_ARCH_PREPROCESSOR_FLAGS,
|
|
|
|
compiler_flags = ROCKSDB_COMPILER_FLAGS,
|
2021-11-01 18:09:50 +01:00
|
|
|
include_paths = ROCKSDB_INCLUDE_PATHS,
|
2020-05-17 06:46:21 +02:00
|
|
|
os_deps = ROCKSDB_OS_DEPS,
|
|
|
|
os_preprocessor_flags = ROCKSDB_OS_PREPROCESSOR_FLAGS,
|
|
|
|
preprocessor_flags = ROCKSDB_PREPROCESSOR_FLAGS,
|
2021-12-17 20:50:30 +01:00
|
|
|
exported_deps = ROCKSDB_LIB_DEPS,
|
|
|
|
exported_external_deps = ROCKSDB_EXTERNAL_DEPS,
|
2020-05-17 06:46:21 +02:00
|
|
|
)
|
|
|
|
"""
|
|
|
|
|
2017-04-05 01:09:31 +02:00
|
|
|
binary_template = """
|
|
|
|
cpp_binary(
|
2020-09-23 21:54:29 +02:00
|
|
|
name = "{name}",
|
|
|
|
srcs = [{srcs}],
|
2019-01-07 22:35:12 +01:00
|
|
|
arch_preprocessor_flags = ROCKSDB_ARCH_PREPROCESSOR_FLAGS,
|
|
|
|
compiler_flags = ROCKSDB_COMPILER_FLAGS,
|
|
|
|
preprocessor_flags = ROCKSDB_PREPROCESSOR_FLAGS,
|
2021-04-03 23:41:25 +02:00
|
|
|
include_paths = ROCKSDB_INCLUDE_PATHS,
|
2020-09-23 21:54:29 +02:00
|
|
|
deps = [{deps}],
|
2019-01-07 22:35:12 +01:00
|
|
|
external_deps = ROCKSDB_EXTERNAL_DEPS,
|
2017-04-05 01:09:31 +02:00
|
|
|
)
|
|
|
|
"""
|
|
|
|
|
2017-11-15 23:13:39 +01:00
|
|
|
test_cfg_template = """ [
|
|
|
|
"%s",
|
|
|
|
"%s",
|
|
|
|
"%s",
|
2019-08-02 19:40:32 +02:00
|
|
|
%s,
|
|
|
|
%s,
|
2017-11-15 23:13:39 +01:00
|
|
|
],
|
|
|
|
"""
|
|
|
|
|
2017-04-05 01:09:31 +02:00
|
|
|
unittests_template = """
|
2019-08-02 19:40:32 +02:00
|
|
|
# [test_name, test_src, test_type, extra_deps, extra_compiler_flags]
|
2017-11-15 23:13:39 +01:00
|
|
|
ROCKS_TESTS = [
|
2020-09-23 21:54:29 +02:00
|
|
|
{tests}]
|
2017-04-05 01:09:31 +02:00
|
|
|
|
|
|
|
# Generate a test rule for each entry in ROCKS_TESTS
|
2017-11-30 19:40:39 +01:00
|
|
|
# Do not build the tests in opt mode, since SyncPoint and other test code
|
|
|
|
# will not be included.
|
2019-01-07 22:35:12 +01:00
|
|
|
[
|
2020-06-05 21:14:42 +02:00
|
|
|
cpp_unittest(
|
|
|
|
name = test_name,
|
|
|
|
srcs = [test_cc],
|
|
|
|
arch_preprocessor_flags = ROCKSDB_ARCH_PREPROCESSOR_FLAGS,
|
2020-09-26 01:43:23 +02:00
|
|
|
compiler_flags = ROCKSDB_COMPILER_FLAGS + extra_compiler_flags,
|
2021-04-03 23:41:25 +02:00
|
|
|
include_paths = ROCKSDB_INCLUDE_PATHS,
|
2021-11-01 18:09:50 +01:00
|
|
|
os_preprocessor_flags = ROCKSDB_OS_PREPROCESSOR_FLAGS,
|
|
|
|
preprocessor_flags = ROCKSDB_PREPROCESSOR_FLAGS,
|
2020-06-05 21:14:42 +02:00
|
|
|
deps = [":rocksdb_test_lib"] + extra_deps,
|
|
|
|
external_deps = ROCKSDB_EXTERNAL_DEPS + [
|
|
|
|
("googletest", None, "gtest"),
|
|
|
|
],
|
2019-01-07 22:35:12 +01:00
|
|
|
)
|
2019-08-02 19:40:32 +02:00
|
|
|
for test_name, test_cc, parallelism, extra_deps, extra_compiler_flags in ROCKS_TESTS
|
2019-01-07 22:35:12 +01:00
|
|
|
if not is_opt_mode
|
|
|
|
]
|
2017-04-05 01:09:31 +02:00
|
|
|
"""
|