2018-08-01 09:14:43 +02:00
|
|
|
// Copyright (c) 2011-present, Facebook, Inc. All rights reserved.
|
|
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
|
|
// (found in the LICENSE.Apache file in the root directory).
|
|
|
|
|
|
|
|
#include "utilities/trace/file_trace_reader_writer.h"
|
|
|
|
|
Introduce a new storage specific Env API (#5761)
Summary:
The current Env API encompasses both storage/file operations, as well as OS related operations. Most of the APIs return a Status, which does not have enough metadata about an error, such as whether its retry-able or not, scope (i.e fault domain) of the error etc., that may be required in order to properly handle a storage error. The file APIs also do not provide enough control over the IO SLA, such as timeout, prioritization, hinting about placement and redundancy etc.
This PR separates out the file/storage APIs from Env into a new FileSystem class. The APIs are updated to return an IOStatus with metadata about the error, as well as to take an IOOptions structure as input in order to allow more control over the IO.
The user can set both ```options.env``` and ```options.file_system``` to specify that RocksDB should use the former for OS related operations and the latter for storage operations. Internally, a ```CompositeEnvWrapper``` has been introduced that inherits from ```Env``` and redirects individual methods to either an ```Env``` implementation or the ```FileSystem``` as appropriate. When options are sanitized during ```DB::Open```, ```options.env``` is replaced with a newly allocated ```CompositeEnvWrapper``` instance if both env and file_system have been specified. This way, the rest of the RocksDB code can continue to function as before.
This PR also ports PosixEnv to the new API by splitting it into two - PosixEnv and PosixFileSystem. PosixEnv is defined as a sub-class of CompositeEnvWrapper, and threading/time functions are overridden with Posix specific implementations in order to avoid an extra level of indirection.
The ```CompositeEnvWrapper``` translates ```IOStatus``` return code to ```Status```, and sets the severity to ```kSoftError``` if the io_status is retryable. The error handling code in RocksDB can then recover the DB automatically.
Pull Request resolved: https://github.com/facebook/rocksdb/pull/5761
Differential Revision: D18868376
Pulled By: anand1976
fbshipit-source-id: 39efe18a162ea746fabac6360ff529baba48486f
2019-12-13 23:47:08 +01:00
|
|
|
#include "env/composite_env_wrapper.h"
|
2019-09-16 19:31:27 +02:00
|
|
|
#include "file/random_access_file_reader.h"
|
|
|
|
#include "file/writable_file_writer.h"
|
2019-06-03 22:21:02 +02:00
|
|
|
#include "trace_replay/trace_replay.h"
|
2018-08-01 09:14:43 +02:00
|
|
|
#include "util/coding.h"
|
|
|
|
|
|
|
|
namespace rocksdb {
|
|
|
|
|
|
|
|
const unsigned int FileTraceReader::kBufferSize = 1024; // 1KB
|
|
|
|
|
|
|
|
FileTraceReader::FileTraceReader(
|
|
|
|
std::unique_ptr<RandomAccessFileReader>&& reader)
|
|
|
|
: file_reader_(std::move(reader)),
|
|
|
|
offset_(0),
|
|
|
|
buffer_(new char[kBufferSize]) {}
|
|
|
|
|
|
|
|
FileTraceReader::~FileTraceReader() {
|
|
|
|
Close();
|
|
|
|
delete[] buffer_;
|
|
|
|
}
|
|
|
|
|
|
|
|
Status FileTraceReader::Close() {
|
|
|
|
file_reader_.reset();
|
|
|
|
return Status::OK();
|
|
|
|
}
|
|
|
|
|
|
|
|
Status FileTraceReader::Read(std::string* data) {
|
|
|
|
assert(file_reader_ != nullptr);
|
|
|
|
Status s = file_reader_->Read(offset_, kTraceMetadataSize, &result_, buffer_);
|
|
|
|
if (!s.ok()) {
|
|
|
|
return s;
|
|
|
|
}
|
|
|
|
if (result_.size() == 0) {
|
|
|
|
// No more data to read
|
|
|
|
// Todo: Come up with a better way to indicate end of data. May be this
|
|
|
|
// could be avoided once footer is introduced.
|
|
|
|
return Status::Incomplete();
|
|
|
|
}
|
|
|
|
if (result_.size() < kTraceMetadataSize) {
|
|
|
|
return Status::Corruption("Corrupted trace file.");
|
|
|
|
}
|
|
|
|
*data = result_.ToString();
|
|
|
|
offset_ += kTraceMetadataSize;
|
|
|
|
|
|
|
|
uint32_t payload_len =
|
|
|
|
DecodeFixed32(&buffer_[kTraceTimestampSize + kTraceTypeSize]);
|
|
|
|
|
|
|
|
// Read Payload
|
|
|
|
unsigned int bytes_to_read = payload_len;
|
|
|
|
unsigned int to_read =
|
|
|
|
bytes_to_read > kBufferSize ? kBufferSize : bytes_to_read;
|
|
|
|
while (to_read > 0) {
|
|
|
|
s = file_reader_->Read(offset_, to_read, &result_, buffer_);
|
|
|
|
if (!s.ok()) {
|
|
|
|
return s;
|
|
|
|
}
|
|
|
|
if (result_.size() < to_read) {
|
|
|
|
return Status::Corruption("Corrupted trace file.");
|
|
|
|
}
|
|
|
|
data->append(result_.data(), result_.size());
|
|
|
|
|
|
|
|
offset_ += to_read;
|
|
|
|
bytes_to_read -= to_read;
|
|
|
|
to_read = bytes_to_read > kBufferSize ? kBufferSize : bytes_to_read;
|
|
|
|
}
|
|
|
|
|
|
|
|
return s;
|
|
|
|
}
|
|
|
|
|
|
|
|
FileTraceWriter::~FileTraceWriter() { Close(); }
|
|
|
|
|
|
|
|
Status FileTraceWriter::Close() {
|
|
|
|
file_writer_.reset();
|
|
|
|
return Status::OK();
|
|
|
|
}
|
|
|
|
|
|
|
|
Status FileTraceWriter::Write(const Slice& data) {
|
|
|
|
return file_writer_->Append(data);
|
|
|
|
}
|
|
|
|
|
2018-11-27 23:24:24 +01:00
|
|
|
uint64_t FileTraceWriter::GetFileSize() { return file_writer_->GetFileSize(); }
|
|
|
|
|
2018-08-01 09:14:43 +02:00
|
|
|
Status NewFileTraceReader(Env* env, const EnvOptions& env_options,
|
|
|
|
const std::string& trace_filename,
|
|
|
|
std::unique_ptr<TraceReader>* trace_reader) {
|
2018-11-09 20:17:34 +01:00
|
|
|
std::unique_ptr<RandomAccessFile> trace_file;
|
2018-08-01 09:14:43 +02:00
|
|
|
Status s = env->NewRandomAccessFile(trace_filename, &trace_file, env_options);
|
|
|
|
if (!s.ok()) {
|
|
|
|
return s;
|
|
|
|
}
|
|
|
|
|
2018-11-09 20:17:34 +01:00
|
|
|
std::unique_ptr<RandomAccessFileReader> file_reader;
|
Introduce a new storage specific Env API (#5761)
Summary:
The current Env API encompasses both storage/file operations, as well as OS related operations. Most of the APIs return a Status, which does not have enough metadata about an error, such as whether its retry-able or not, scope (i.e fault domain) of the error etc., that may be required in order to properly handle a storage error. The file APIs also do not provide enough control over the IO SLA, such as timeout, prioritization, hinting about placement and redundancy etc.
This PR separates out the file/storage APIs from Env into a new FileSystem class. The APIs are updated to return an IOStatus with metadata about the error, as well as to take an IOOptions structure as input in order to allow more control over the IO.
The user can set both ```options.env``` and ```options.file_system``` to specify that RocksDB should use the former for OS related operations and the latter for storage operations. Internally, a ```CompositeEnvWrapper``` has been introduced that inherits from ```Env``` and redirects individual methods to either an ```Env``` implementation or the ```FileSystem``` as appropriate. When options are sanitized during ```DB::Open```, ```options.env``` is replaced with a newly allocated ```CompositeEnvWrapper``` instance if both env and file_system have been specified. This way, the rest of the RocksDB code can continue to function as before.
This PR also ports PosixEnv to the new API by splitting it into two - PosixEnv and PosixFileSystem. PosixEnv is defined as a sub-class of CompositeEnvWrapper, and threading/time functions are overridden with Posix specific implementations in order to avoid an extra level of indirection.
The ```CompositeEnvWrapper``` translates ```IOStatus``` return code to ```Status```, and sets the severity to ```kSoftError``` if the io_status is retryable. The error handling code in RocksDB can then recover the DB automatically.
Pull Request resolved: https://github.com/facebook/rocksdb/pull/5761
Differential Revision: D18868376
Pulled By: anand1976
fbshipit-source-id: 39efe18a162ea746fabac6360ff529baba48486f
2019-12-13 23:47:08 +01:00
|
|
|
file_reader.reset(new RandomAccessFileReader(
|
|
|
|
NewLegacyRandomAccessFileWrapper(trace_file), trace_filename));
|
2018-08-01 09:14:43 +02:00
|
|
|
trace_reader->reset(new FileTraceReader(std::move(file_reader)));
|
|
|
|
return s;
|
|
|
|
}
|
|
|
|
|
|
|
|
Status NewFileTraceWriter(Env* env, const EnvOptions& env_options,
|
|
|
|
const std::string& trace_filename,
|
|
|
|
std::unique_ptr<TraceWriter>* trace_writer) {
|
2018-11-09 20:17:34 +01:00
|
|
|
std::unique_ptr<WritableFile> trace_file;
|
2018-08-01 09:14:43 +02:00
|
|
|
Status s = env->NewWritableFile(trace_filename, &trace_file, env_options);
|
|
|
|
if (!s.ok()) {
|
|
|
|
return s;
|
|
|
|
}
|
|
|
|
|
2018-11-09 20:17:34 +01:00
|
|
|
std::unique_ptr<WritableFileWriter> file_writer;
|
Introduce a new storage specific Env API (#5761)
Summary:
The current Env API encompasses both storage/file operations, as well as OS related operations. Most of the APIs return a Status, which does not have enough metadata about an error, such as whether its retry-able or not, scope (i.e fault domain) of the error etc., that may be required in order to properly handle a storage error. The file APIs also do not provide enough control over the IO SLA, such as timeout, prioritization, hinting about placement and redundancy etc.
This PR separates out the file/storage APIs from Env into a new FileSystem class. The APIs are updated to return an IOStatus with metadata about the error, as well as to take an IOOptions structure as input in order to allow more control over the IO.
The user can set both ```options.env``` and ```options.file_system``` to specify that RocksDB should use the former for OS related operations and the latter for storage operations. Internally, a ```CompositeEnvWrapper``` has been introduced that inherits from ```Env``` and redirects individual methods to either an ```Env``` implementation or the ```FileSystem``` as appropriate. When options are sanitized during ```DB::Open```, ```options.env``` is replaced with a newly allocated ```CompositeEnvWrapper``` instance if both env and file_system have been specified. This way, the rest of the RocksDB code can continue to function as before.
This PR also ports PosixEnv to the new API by splitting it into two - PosixEnv and PosixFileSystem. PosixEnv is defined as a sub-class of CompositeEnvWrapper, and threading/time functions are overridden with Posix specific implementations in order to avoid an extra level of indirection.
The ```CompositeEnvWrapper``` translates ```IOStatus``` return code to ```Status```, and sets the severity to ```kSoftError``` if the io_status is retryable. The error handling code in RocksDB can then recover the DB automatically.
Pull Request resolved: https://github.com/facebook/rocksdb/pull/5761
Differential Revision: D18868376
Pulled By: anand1976
fbshipit-source-id: 39efe18a162ea746fabac6360ff529baba48486f
2019-12-13 23:47:08 +01:00
|
|
|
file_writer.reset(new WritableFileWriter(
|
|
|
|
NewLegacyWritableFileWrapper(std::move(trace_file)), trace_filename,
|
|
|
|
env_options));
|
2018-08-01 09:14:43 +02:00
|
|
|
trace_writer->reset(new FileTraceWriter(std::move(file_writer)));
|
|
|
|
return s;
|
|
|
|
}
|
|
|
|
|
|
|
|
} // namespace rocksdb
|