crash_test: disable atomic flush with pipelined write (#5986)
Summary: Recently, pipelined write is enabled even if atomic flush is enabled, which causing sanitizing failure in db_stress. Revert this change. Pull Request resolved: https://github.com/facebook/rocksdb/pull/5986 Test Plan: Run "make crash_test_with_atomic_flush" and see it to run for some while so that the old sanitizing error (which showed up quickly) doesn't show up. Differential Revision: D18228278 fbshipit-source-id: 27fdf2f8e3e77068c9725a838b9bef4ab25a2553
This commit is contained in:
parent
15119f08e2
commit
0337d87b42
@ -145,7 +145,6 @@ cf_consistency_params = {
|
||||
# use small value for write_buffer_size so that RocksDB triggers flush
|
||||
# more frequently
|
||||
"write_buffer_size": 1024 * 1024,
|
||||
# disable pipelined write when test_atomic_flush is true
|
||||
"enable_pipelined_write": lambda: random.randint(0, 1),
|
||||
}
|
||||
|
||||
@ -181,9 +180,11 @@ def finalize_and_sanitize(src_params):
|
||||
dest_params["partition_filters"] = 0
|
||||
else:
|
||||
dest_params["use_block_based_filter"] = 0
|
||||
if dest_params.get("atomic_flush", 0) == 1:
|
||||
# disable pipelined write when atomic flush is used.
|
||||
dest_params["enable_pipelined_write"] = 0
|
||||
return dest_params
|
||||
|
||||
|
||||
def gen_cmd_params(args):
|
||||
params = {}
|
||||
|
||||
|
Loading…
Reference in New Issue
Block a user