andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Remove assertion from FaultInjectionTestFS::NewDirectory (#7220)

Browse Source 
Summary:
FaultInjectionTestFS::NewDirectory currently asserts that the directory
creation on the target filesystem succeeds. This is actually not
guaranteed since there might be a legitimate I/O error when creating the
directory. The patch removes this assertion.

Pull Request resolved: https://github.com/facebook/rocksdb/pull/7220

Test Plan: `make check`

Reviewed By: zhichao-cao

Differential Revision: D22957990

Pulled By: ltamasi

fbshipit-source-id: b2e221320d8ce7235cb4897ef5936072412a25b6
This commit is contained in:
Levi Tamasi 2020-08-05 16:24:06 -07:00 committed by Facebook GitHub Bot
parent 5c1a544122
commit 124fbd96d8
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
utilities/fault_injection_fs.cc
View File

@ -227,7 +227,6 @@ IOStatus FaultInjectionTestFS::NewDirectory(
std::unique_ptr<FSDirectory>* result, IODebugContext* dbg) {
std::unique_ptr<FSDirectory> r;
IOStatus io_s = target()->NewDirectory(name, options, &r, dbg);
assert(io_s.ok());
if (!io_s.ok()) {
return io_s;
}