From 12fd9b1868764441717c328ee6081e0dcc0d430b Mon Sep 17 00:00:00 2001 From: sdong Date: Mon, 29 Feb 2016 15:02:32 -0800 Subject: [PATCH] Change BlockBasedTableOptions.format_version default to 2 Summary: BlockBasedTableOptions.format_version = 2 uses better encoding format. Now it's the time to make it default. Test Plan: Run all existing tests. Reviewers: igor, yhchiang, anthony, kradhakrishnan, andrewkr, IslamAbdelRahman Reviewed By: IslamAbdelRahman Subscribers: MarkCallaghan, leveldb, dhruba Differential Revision: https://reviews.facebook.net/D54879 --- HISTORY.md | 2 ++ include/rocksdb/table.h | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/HISTORY.md b/HISTORY.md index 6561e520e..567d40d08 100644 --- a/HISTORY.md +++ b/HISTORY.md @@ -1,5 +1,7 @@ # Rocksdb Change Log ## Unreleased +### Public API Changes +* Change default of BlockBasedTableOptions.format_version to 2. It means default DB created by 4.6 or up cannot be opened by RocksDB version 3.9 or earlier. ### New Features * Add CompactionPri::kMinOverlappingRatio, a compaction picking mode friendly to write amplification. * Deprecate Iterator::IsKeyPinned() and replace it with Iterator::GetProperty() with prop_name="rocksdb.iterator.is.key.pinned" diff --git a/include/rocksdb/table.h b/include/rocksdb/table.h index 157d4274c..cb4d850e8 100644 --- a/include/rocksdb/table.h +++ b/include/rocksdb/table.h @@ -166,7 +166,7 @@ struct BlockBasedTableOptions { // this. // This option only affects newly written tables. When reading exising tables, // the information about version is read from the footer. - uint32_t format_version = 0; + uint32_t format_version = 2; }; // Table Properties that are specific to block-based table properties.