andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix pre_release callback argument list.

Browse Source 
Summary:
Primitive types constness does not affect the signature of the
  method and has no influence on whether the overriding method would
  actually have that const bool instead of just bool. In addition,
  it is rarely useful but does produce a compatibility warnings
  in VS 2015 compiler.
Closes https://github.com/facebook/rocksdb/pull/3663

Differential Revision: D7475739

Pulled By: ajkr

fbshipit-source-id: fb275378b5acc397399420ae6abb4b6bfe5bd32f
This commit is contained in:
Dmitri Smirnov 2018-04-05 11:05:11 -07:00 committed by Facebook Github Bot
parent 36a9f22931
commit 147dfc7bdf
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
db/pre_release_callback.h
View File

@ -26,7 +26,7 @@ class PreReleaseCallback {
// released. // released.
// is_mem_disabled is currently used for debugging purposes to assert that // is_mem_disabled is currently used for debugging purposes to assert that
// the callback is done from the right write queue. // the callback is done from the right write queue.
virtual Status Callback(SequenceNumber seq, const bool is_mem_disabled) = 0; virtual Status Callback(SequenceNumber seq, bool is_mem_disabled) = 0;
}; };
} // namespace rocksdb } // namespace rocksdb

2
db/write_callback_test.cc
View File

@ -295,7 +295,7 @@ TEST_F(WriteCallbackTest, WriteWithCallbackTest) {
PublishSeqCallback(DBImpl* db_impl_in) PublishSeqCallback(DBImpl* db_impl_in)
: db_impl_(db_impl_in) {} : db_impl_(db_impl_in) {}
virtual Status Callback(SequenceNumber last_seq, virtual Status Callback(SequenceNumber last_seq,
const bool /*not used*/) override { bool /*not used*/) override {
db_impl_->SetLastPublishedSequence(last_seq); db_impl_->SetLastPublishedSequence(last_seq);
return Status::OK(); return Status::OK();
} }