andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Remove key length assertion LRUHandle::CalcTotalCharge (#6115)

Browse Source 
Summary:
Inserting an entry in the block cache with 0 length key is a valid use case. Remove the assertion in ```LRUHandle::CalcTotalCharge```.
Pull Request resolved: https://github.com/facebook/rocksdb/pull/6115

Differential Revision: D18769693

Pulled By: anand1976

fbshipit-source-id: 34cc159650300dda6d7273480640478f28392cda
This commit is contained in:
anand76 2019-12-02 14:58:22 -08:00 committed by Facebook Github Bot
parent 048472f620
commit 16fa6fd2a6
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
cache/lru_cache.h vendored
View File

@ -133,7 +133,6 @@ struct LRUHandle {
// Caclculate the memory usage by metadata // Caclculate the memory usage by metadata
inline size_t CalcTotalCharge( inline size_t CalcTotalCharge(
CacheMetadataChargePolicy metadata_charge_policy) { CacheMetadataChargePolicy metadata_charge_policy) {
assert(key_length);
size_t meta_charge = 0; size_t meta_charge = 0;
if (metadata_charge_policy == kFullChargeCacheMetadata) { if (metadata_charge_policy == kFullChargeCacheMetadata) {
#ifdef ROCKSDB_MALLOC_USABLE_SIZE #ifdef ROCKSDB_MALLOC_USABLE_SIZE