andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Allow intentionally swallowed errors in BlockBasedFilterBlockReader (#8695)

Browse Source 
Summary:
To avoid getting "Didn't get expected error from Get" from
crash test by enabling block-based filter in crash test in https://github.com/facebook/rocksdb/issues/8679.
Basically, this applies the pattern of IGNORE_STATUS_IF_ERROR in
full_filter_block.cc to block_based_filter_block.cc

Pull Request resolved: https://github.com/facebook/rocksdb/pull/8695

Test Plan: watch for resolution of crash test runs

Reviewed By: ltamasi

Differential Revision: D30496748

Pulled By: pdillinger

fbshipit-source-id: f7808fcf14c0e787fe81da03fa8303244590d273
This commit is contained in:
Peter Dillinger 2021-08-23 15:49:27 -07:00 committed by Facebook GitHub Bot
parent 0637c8d36c
commit 1a5eb33d91
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
table/block_based/block_based_filter_block.cc
View File

@ -257,6 +257,7 @@ bool BlockBasedFilterBlockReader::MayMatch(
const Status s = const Status s =
GetOrReadFilterBlock(no_io, get_context, lookup_context, &filter_block); GetOrReadFilterBlock(no_io, get_context, lookup_context, &filter_block);
if (!s.ok()) { if (!s.ok()) {
IGNORE_STATUS_IF_ERROR(s);
return true; return true;
} }
@ -315,6 +316,7 @@ std::string BlockBasedFilterBlockReader::ToString() const {
GetOrReadFilterBlock(false /* no_io */, nullptr /* get_context */, GetOrReadFilterBlock(false /* no_io */, nullptr /* get_context */,
nullptr /* lookup_context */, &filter_block); nullptr /* lookup_context */, &filter_block);
if (!s.ok()) { if (!s.ok()) {
IGNORE_STATUS_IF_ERROR(s);
return std::string("Unable to retrieve filter block"); return std::string("Unable to retrieve filter block");
} }