andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Do not track WAL in MANIFEST when fsync is disabled in a test (#7669)

Browse Source 
Summary:
If fsync is disabled in a unit test, then do not track WAL in MANIFEST, because on DB recovery, the WAL might be missing because the directory is not fsynced.

Pull Request resolved: https://github.com/facebook/rocksdb/pull/7669

Test Plan: Tests with fsync enabled should pass.

Reviewed By: riversand963

Differential Revision: D24941431

Pulled By: cheng-chang

fbshipit-source-id: ab3ff0f90769795cfb4e4d6dcf084ea5545d1975
This commit is contained in:
Cheng Chang 2020-11-13 13:36:00 -08:00 committed by Facebook GitHub Bot
parent 9aa1b1dc19
commit 1aae41786a
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
db/db_test_util.cc
View File

@ -340,7 +340,9 @@ Options DBTestBase::GetDefaultOptions() const {
options.wal_recovery_mode = WALRecoveryMode::kTolerateCorruptedTailRecords; options.wal_recovery_mode = WALRecoveryMode::kTolerateCorruptedTailRecords;
options.compaction_pri = CompactionPri::kByCompensatedSize; options.compaction_pri = CompactionPri::kByCompensatedSize;
options.env = env_; options.env = env_;
options.track_and_verify_wals_in_manifest = true; if (!env_->skip_fsync_) {
options.track_and_verify_wals_in_manifest = true;
}
return options; return options;
} }