andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[RocksDB] Universal compaction trigger condition minor fix

Browse Source 
Summary: Currently, when total number of files reaches level0_file_num_compaction_trigger, universal compaction will schedule a compaction job, but the job will not honor the compaction until the total number of files is level0_file_num_compaction_trigger+1. Fixed the condition for consistent behavior (start compaction on reaching level0_file_num_compaction_trigger).

Test Plan: make check; db_stress

Reviewers: dhruba

CC: leveldb

Differential Revision: https://reviews.facebook.net/D12945
This commit is contained in:
Haobo Xu 2013-09-15 10:21:03 -07:00
parent 5f2c136c32
commit 1d8c57db23
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
db/version_set.cc
View File

@ -2367,7 +2367,7 @@ Compaction* VersionSet::PickCompactionUniversalReadAmp(
Compaction* VersionSet::PickCompactionUniversal(int level, double score) { Compaction* VersionSet::PickCompactionUniversal(int level, double score) {
assert (level == 0); assert (level == 0);
if ((current_->files_[level].size() <= if ((current_->files_[level].size() <
(unsigned int)options_->level0_file_num_compaction_trigger)) { (unsigned int)options_->level0_file_num_compaction_trigger)) {
Log(options_->info_log, "Universal: nothing to do\n"); Log(options_->info_log, "Universal: nothing to do\n");
return nullptr; return nullptr;