andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

crash_test to skip compaction TTL for FIFO compaction. (#5749)

Browse Source 
Summary:
https://github.com/facebook/rocksdb/pull/5741 added compaction TTL to crash test, but it causes assertion fails for FIFO compaction. Disable this combination for now while we debug the assertion failure.
Pull Request resolved: https://github.com/facebook/rocksdb/pull/5749

Test Plan: Run crash test and observe that when compaction_style=2, compaction_ttl is always 0.

Differential Revision: D17078292

fbshipit-source-id: 446821a3b9739956094d5e4f9be1251a15b57f5d
This commit is contained in:
sdong 2019-08-27 17:54:18 -07:00 committed by Facebook Github Bot
parent 1b4c104a67
commit 1daff8f85a
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tools/db_crashtest.py
View File

@ -170,6 +170,10 @@ def finalize_and_sanitize(src_params):
# with open_files = -1 # with open_files = -1
dest_params["compaction_ttl"] = 0 dest_params["compaction_ttl"] = 0
dest_params["periodic_compaction_seconds"] = 0 dest_params["periodic_compaction_seconds"] = 0
if dest_params.get("compaction_style", 0) == 2:
# Disable compaction TTL in FIFO compaction, because right
# now assertion failures are triggered.
dest_params["compaction_ttl"] = 0
return dest_params return dest_params