andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Add mmap DBGet microbench parameters (#9903)

Browse Source 
Summary:
I tried evaluating https://github.com/facebook/rocksdb/issues/9611 using DBGet microbenchmarks but mostly found the change is well within the noise even for hundreds of repetitions; meanwhile, the InternalKeyComparator CPU it saves is 1-2% according to perf so it should be measurable. In this PR I tried adding a mmap mode that will bypass compression/checksum/block cache/file read to focus more on the block lookup paths, and also increased the Get() count.

Pull Request resolved: https://github.com/facebook/rocksdb/pull/9903

Reviewed By: jay-zhuang, riversand963

Differential Revision: D35907375

Pulled By: ajkr

fbshipit-source-id: 69490d5040ef0863e1ce296724104d0aa7667215
This commit is contained in:
Andrew Kryczka 2022-04-26 16:46:39 -07:00 committed by Facebook GitHub Bot
parent c5d367f472
commit 1eb279dcce
1 changed files with 20 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
microbench/db_basic_bench.cc
View File

@ -525,6 +525,7 @@ static void DBGet(benchmark::State& state) {
bool enable_statistics = state.range(3); bool enable_statistics = state.range(3);
bool negative_query = state.range(4); bool negative_query = state.range(4);
bool enable_filter = state.range(5); bool enable_filter = state.range(5);
bool mmap = state.range(6);
uint64_t key_num = max_data / per_key_size; uint64_t key_num = max_data / per_key_size;
// setup DB // setup DB
@ -533,13 +534,21 @@ static void DBGet(benchmark::State& state) {
if (enable_statistics) { if (enable_statistics) {
options.statistics = CreateDBStatistics(); options.statistics = CreateDBStatistics();
} }
if (mmap) {
options.allow_mmap_reads = true;
options.compression = kNoCompression;
}
options.compaction_style = compaction_style; options.compaction_style = compaction_style;
if (enable_filter) {
BlockBasedTableOptions table_options; BlockBasedTableOptions table_options;
if (enable_filter) {
table_options.filter_policy.reset(NewBloomFilterPolicy(10, false)); table_options.filter_policy.reset(NewBloomFilterPolicy(10, false));
options.table_factory.reset(NewBlockBasedTableFactory(table_options));
} }
if (mmap) {
table_options.no_block_cache = true;
table_options.block_restart_interval = 1;
}
options.table_factory.reset(NewBlockBasedTableFactory(table_options));
auto rnd = Random(301 + state.thread_index()); auto rnd = Random(301 + state.thread_index());
KeyGenerator kg(&rnd, key_num); KeyGenerator kg(&rnd, key_num);
@ -573,6 +582,9 @@ static void DBGet(benchmark::State& state) {
} }
auto ro = ReadOptions(); auto ro = ReadOptions();
if (mmap) {
ro.verify_checksums = false;
}
size_t not_found = 0; size_t not_found = 0;
if (negative_query) { if (negative_query) {
for (auto _ : state) { for (auto _ : state) {
@ -616,8 +628,10 @@ static void DBGetArguments(benchmark::internal::Benchmark* b) {
for (bool enable_statistics : {false, true}) { for (bool enable_statistics : {false, true}) {
for (bool negative_query : {false, true}) { for (bool negative_query : {false, true}) {
for (bool enable_filter : {false, true}) { for (bool enable_filter : {false, true}) {
for (bool mmap : {false, true}) {
b->Args({comp_style, max_data, per_key_size, enable_statistics, b->Args({comp_style, max_data, per_key_size, enable_statistics,
negative_query, enable_filter}); negative_query, enable_filter, mmap});
}
} }
} }
} }
@ -625,10 +639,10 @@ static void DBGetArguments(benchmark::internal::Benchmark* b) {
} }
} }
b->ArgNames({"comp_style", "max_data", "per_key_size", "enable_statistics", b->ArgNames({"comp_style", "max_data", "per_key_size", "enable_statistics",
"negative_query", "enable_filter"}); "negative_query", "enable_filter", "mmap"});
} }
static constexpr uint64_t kDBGetNum = 10l << 10; static constexpr uint64_t kDBGetNum = 1l << 20;
BENCHMARK(DBGet)->Threads(1)->Iterations(kDBGetNum)->Apply(DBGetArguments); BENCHMARK(DBGet)->Threads(1)->Iterations(kDBGetNum)->Apply(DBGetArguments);
BENCHMARK(DBGet)->Threads(8)->Iterations(kDBGetNum / 8)->Apply(DBGetArguments); BENCHMARK(DBGet)->Threads(8)->Iterations(kDBGetNum / 8)->Apply(DBGetArguments);